From 6a63ac6764a40b8dc922933792bd0b473ff9a4db Mon Sep 17 00:00:00 2001 From: Andrew Chong Li Date: Thu, 15 Oct 2020 18:13:58 -0400 Subject: [PATCH] Allow frozen parameters with requires_grad=False --- torch_ac/algos/ppo.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/torch_ac/algos/ppo.py b/torch_ac/algos/ppo.py index b270d06..03425ab 100644 --- a/torch_ac/algos/ppo.py +++ b/torch_ac/algos/ppo.py @@ -103,8 +103,8 @@ def update_parameters(self, exps): self.optimizer.zero_grad() batch_loss.backward() - grad_norm = sum(p.grad.data.norm(2).item() ** 2 for p in self.acmodel.parameters()) ** 0.5 - torch.nn.utils.clip_grad_norm_(self.acmodel.parameters(), self.max_grad_norm) + grad_norm = sum(p.grad.data.norm(2).item() ** 2 for p in self.acmodel.parameters() if p.requires_grad) ** 0.5 + torch.nn.utils.clip_grad_norm_([p for p in self.acmodel.parameters() if p.requires_grad], self.max_grad_norm) self.optimizer.step() # Update log values