fix: hide check updates preference when updater disabled. remove debug output

Fixes #1051

Author: mfisher31

src/pluginprocessor.cpp

@@ -627,7 +627,6 @@ void PluginProcessor::updateLatencySamples()
     int latency = 0;
     if (! forceZeroLatency && engine != nullptr)
     {
-        std::clog << "update latency from change signal\n";
         latency = engine->getExternalLatencySamples();
     }
     setLatencySamples (latency);

src/services/engineservice.cpp

@@ -939,13 +939,15 @@ void EngineService::sessionReloaded()
     {
         Logger::writeToLog ("[element] model and engine graph counts do not match");
     }
+#if JUCE_DEBUG
     else
     {
         String msg ("[element] session reloaded");
         if (session->getName().isNotEmpty())
             msg << ": " << session->getName();
-        Logger::writeToLog (msg);
+        DBG (msg);
     }
+#endif
 }
 
 Node EngineService::addPlugin (GraphManager& c, const PluginDescription& desc)

src/sparkle.mm

@@ -76,7 +76,6 @@ - (void)dealloc
     void check(bool async) override
     {
         juce::ignoreUnused(async);
-        std::cout << "checking for updates: async=" << (int)async << std::endl;
         @autoreleasepool
         {
             [_updaterDelegate.updaterController checkForUpdates:nil];

src/ui/preferences.cpp

@@ -341,15 +341,15 @@ class GeneralSettingsPage : public SettingsPage,
         clockSourceBox.addItem ("Internal", ClockSourceInternal);
         clockSourceBox.addItem ("MIDI Clock", ClockSourceMidiClock);
         clockSource.referTo (clockSourceBox.getSelectedIdAsValue());
-
+#if ELEMENT_UPDATER
         addAndMakeVisible (checkForUpdatesLabel);
         checkForUpdatesLabel.setText ("Check for updates on startup", dontSendNotification);
         checkForUpdatesLabel.setFont (Font (FontOptions (12.0, Font::bold)));
         addAndMakeVisible (checkForUpdates);
         checkForUpdates.setClickingTogglesState (true);
         checkForUpdates.setToggleState (settings.checkForUpdates(), dontSendNotification);
         checkForUpdates.getToggleStateValue().addListener (this);
-
+#endif
         addAndMakeVisible (scanForPlugsLabel);
         scanForPlugsLabel.setText ("Scan plugins on startup", dontSendNotification);
         scanForPlugsLabel.setFont (Font (FontOptions (12.0, Font::bold)));
@@ -516,13 +516,13 @@ class GeneralSettingsPage : public SettingsPage,
         auto r2 = r.removeFromTop (settingHeight);
         clockSourceLabel.setBounds (r2.removeFromLeft (getWidth() / 2));
         clockSourceBox.setBounds (r2.withSizeKeepingCentre (r2.getWidth(), settingHeight));
-
+#if ELEMENT_UPDATER
         r.removeFromTop (spacingBetweenSections);
         r2 = r.removeFromTop (settingHeight);
         checkForUpdatesLabel.setBounds (r2.removeFromLeft (getWidth() / 2));
         checkForUpdates.setBounds (r2.removeFromLeft (toggleWidth)
                                        .withSizeKeepingCentre (toggleWidth, toggleHeight));
-
+#endif
         r.removeFromTop (spacingBetweenSections);
         r2 = r.removeFromTop (settingHeight);
         scanForPlugsLabel.setBounds (r2.removeFromLeft (getWidth() / 2));
@@ -561,15 +561,17 @@ class GeneralSettingsPage : public SettingsPage,
 
     void valueChanged (Value& value) override
     {
-        if (value.refersToSameSourceAs (checkForUpdates.getToggleStateValue()))
+        if (value.refersToSameSourceAs (legacyCtl.getToggleStateValue()))
         {
-            settings.setCheckForUpdates (checkForUpdates.getToggleState());
-            jassert (settings.checkForUpdates() == checkForUpdates.getToggleState());
+            settings.set ("legacyControllers", legacyCtl.getToggleState());
         }
-        else if (value.refersToSameSourceAs (legacyCtl.getToggleStateValue()))
+#if ELEMENT_UPDATER
+        else if (value.refersToSameSourceAs (checkForUpdates.getToggleStateValue()))
         {
-            settings.set ("legacyControllers", legacyCtl.getToggleState());
+            settings.setCheckForUpdates (checkForUpdates.getToggleState());
+            jassert (settings.checkForUpdates() == checkForUpdates.getToggleState());
         }
+#endif
         // clock source
         else if (value.refersToSameSourceAs (clockSource))
         {