We can easily miss build issues in the post-submit jobs. If a build fails and we later try to make a release from that same commit, we get no release artifacts.
We should try to include a check in the release workflow that would detect these issues. I am fairly sure it is possible to get the "status context" of a specific commit. If we can check that on release note PRs then we can block accidents.
What post-submit build am I talking about? You can see it at the top of any commit page, e.g. here: 2bfcd2a. There is a little ✔️ 1/1. That links to the build.
We can easily miss build issues in the post-submit jobs. If a build fails and we later try to make a release from that same commit, we get no release artifacts.
We should try to include a check in the release workflow that would detect these issues. I am fairly sure it is possible to get the "status context" of a specific commit. If we can check that on release note PRs then we can block accidents.
What post-submit build am I talking about? You can see it at the top of any commit page, e.g. here: 2bfcd2a. There is a little ✔️ 1/1. That links to the build.