[patch] Fix SonarCloud issues in library and benchmark code

Library (9 issues):
- S1939 (8): drop interfaces already implied by another interface in the
  base list. ContiguousCollection/InsertionOrderCollection/
  OrderedCollection drop IReadOnlyCollection<T> (implied by
  IReadOnlyList<T>); RingBuffer drops IEnumerable<T> and
  IReadOnlyCollection<T> for the same reason.
  For the three Set types IReadOnlySet<T> only exists on
  NET5_0_OR_GREATER, and the library still targets netstandard2.0/2.1,
  so IReadOnlyCollection<T> moved into an #else branch rather than being
  removed outright - removing it would have dropped the interface from
  the lower targets.
- S4136 (1): ContiguousMap.Entry - move Equals(Entry) next to
  Equals(object?) so the overloads are adjacent.

Benchmarks (2 issues):
- S4487 (1, HIGH): remove the unread keyValuePairs field in
  OrderedMapBenchmarks and its GlobalSetup assignment.
- S1481 (1): discard the intentional indexer read in
  CacheUsagePatternRingBuffer instead of binding an unused local.

Build clean on all 8 TFMs, 351/351 tests pass.

Author: matt-edmondson

Containers.Benchmarks/CrossCollectionComparisonBenchmarks.cs

@@ -462,7 +462,7 @@ public RingBuffer<int> CacheUsagePatternRingBuffer()
 			if (cache.Count > 10 && random.Next(5) == 0)
 			{
 				int index = random.Next(Math.Min(cache.Count, 10));
-				int value = cache[index]; // Access recent item
+				_ = cache[index]; // Access recent item; result intentionally unused
 			}
 		}
 

Containers.Benchmarks/OrderedMapBenchmarks.cs

@@ -14,7 +14,6 @@ public class OrderedMapBenchmarks
 	private readonly Random random = new(42);
 	private int[] keys = [];
 	private string[] values = [];
-	private KeyValuePair<int, string>[] keyValuePairs = [];
 
 	/// <summary>
 	/// Gets or sets the number of elements to use in benchmarks.
@@ -30,7 +29,6 @@ public void Setup()
 	{
 		keys = [.. Enumerable.Range(1, ElementCount).OrderBy(x => random.Next())];
 		values = [.. keys.Select(k => $"value{k}")];
-		keyValuePairs = [.. keys.Zip(values, (k, v) => new KeyValuePair<int, string>(k, v))];
 	}
 
 	/// <summary>

Containers/ContiguousCollection.cs

@@ -42,7 +42,7 @@ namespace ktsu.Containers;
 	"CA1710:Identifiers should have correct suffix",
 	Justification = "ContiguousCollection is a known collection name"
 )]
-public class ContiguousCollection<T> : ICollection<T>, IReadOnlyCollection<T>, IReadOnlyList<T>
+public class ContiguousCollection<T> : ICollection<T>, IReadOnlyList<T>
 {
 	/// <summary>
 	/// The backing array that stores elements in contiguous memory.

Containers/ContiguousMap.cs

@@ -79,6 +79,15 @@ obj is Entry other
 			&& EqualityComparer<TKey>.Default.Equals(Key, other.Key)
 			&& EqualityComparer<TValue>.Default.Equals(Value, other.Value);
 
+		/// <summary>
+		/// Determines whether the current entry is equal to another entry.
+		/// </summary>
+		/// <param name="other">An entry to compare with this entry.</param>
+		/// <returns>true if the current entry is equal to the other parameter; otherwise, false.</returns>
+		public bool Equals(Entry other) =>
+			EqualityComparer<TKey>.Default.Equals(Key, other.Key)
+			&& EqualityComparer<TValue>.Default.Equals(Value, other.Value);
+
 		/// <summary>
 		/// Returns the hash code for this entry.
 		/// </summary>
@@ -95,15 +104,6 @@ public override int GetHashCode()
 #endif
 		}
 
-		/// <summary>
-		/// Determines whether the current entry is equal to another entry.
-		/// </summary>
-		/// <param name="other">An entry to compare with this entry.</param>
-		/// <returns>true if the current entry is equal to the other parameter; otherwise, false.</returns>
-		public bool Equals(Entry other) =>
-			EqualityComparer<TKey>.Default.Equals(Key, other.Key)
-			&& EqualityComparer<TValue>.Default.Equals(Value, other.Value);
-
 		/// <summary>
 		/// Determines whether two entries are equal.
 		/// </summary>

Containers/ContiguousSet.cs

@@ -47,8 +47,9 @@ namespace ktsu.Containers;
 public class ContiguousSet<T> : ISet<T>
 #if NET5_0_OR_GREATER
 		, IReadOnlySet<T>
-#endif
+#else
 		, IReadOnlyCollection<T>
+#endif
 {
 	/// <summary>
 	/// The backing array that stores elements in contiguous memory.

Containers/InsertionOrderCollection.cs

@@ -30,7 +30,7 @@ namespace ktsu.Containers;
 	"CA1710:Identifiers should have correct suffix",
 	Justification = "InsertionOrderCollection is a known collection name"
 )]
-public class InsertionOrderCollection<T> : ICollection<T>, IReadOnlyCollection<T>, IReadOnlyList<T>
+public class InsertionOrderCollection<T> : ICollection<T>, IReadOnlyList<T>
 {
 	/// <summary>
 	/// The internal list that stores elements in insertion order.

Containers/InsertionOrderSet.cs

@@ -34,8 +34,9 @@ namespace ktsu.Containers;
 public class InsertionOrderSet<T> : ISet<T>
 #if NET5_0_OR_GREATER
 		, IReadOnlySet<T>
-#endif
+#else
 		, IReadOnlyCollection<T>
+#endif
 {
 	/// <summary>
 	/// The internal list that stores elements in insertion order.

Containers/OrderedCollection.cs

@@ -32,7 +32,7 @@ namespace ktsu.Containers;
 	"CA1710:Identifiers should have correct suffix",
 	Justification = "OrderedCollection is a known collection name"
 )]
-public class OrderedCollection<T> : ICollection<T>, IReadOnlyCollection<T>, IReadOnlyList<T>
+public class OrderedCollection<T> : ICollection<T>, IReadOnlyList<T>
 {
 	/// <summary>
 	/// The internal list that stores elements in sorted order.

Containers/OrderedSet.cs

@@ -36,8 +36,9 @@ namespace ktsu.Containers;
 public class OrderedSet<T> : ISet<T>
 #if NET5_0_OR_GREATER
 		, IReadOnlySet<T>
-#endif
+#else
 		, IReadOnlyCollection<T>
+#endif
 {
 	/// <summary>
 	/// The internal list that stores elements in sorted order.

Containers/RingBuffer.cs

@@ -31,7 +31,7 @@ namespace ktsu.Containers;
 	"CA1710:Identifiers should have correct suffix",
 	Justification = "RingBuffer is a known collection name"
 )]
-public class RingBuffer<T> : IEnumerable<T>, IReadOnlyCollection<T>, IReadOnlyList<T>
+public class RingBuffer<T> : IReadOnlyList<T>
 {
 	/// <summary>
 	/// Gets or sets the internal buffer array.