Treat warnings as errors

[atifaziz]

Following on from the comment as part of issue #30:

I'm adamant that we maintain "Treat Warnings as Errors" when building. I think Warnings are a weird concept - if the compiler guys are warning you, you should be worried. Almost every .net project that I've worked on in the past decade has had that setting enabled and I've never regretted it.

I'm absolutely fine on this as long as we suppress warning CS1591, “Missing XML comment for publicly visible type or member…”. When XML docs generation is on and any members of the public API are not documented then those warnings become errors and you can't build, experiment and spike anymore. It kills the speed of your thought & drains creative juices.

[SurajGupta]

My concern is that I often seen projects where the documentation has been totally neglected or where developers simply forget to go back and document after a spike. Maybe we can turn this off in local development so we can iterate more rapidly, but make sure it's part of the build so that documentation is required to generate new nuget packages?

[atifaziz]

Warnings are already being treated as errors but only for release builds. Was the idea here to have the same for debug builds?