Skip to content
This repository was archived by the owner on Mar 19, 2021. It is now read-only.
This repository was archived by the owner on Mar 19, 2021. It is now read-only.

Unusable with not-QWERTY keyboard layouts #35

Description

@excelkobayashi

Expected behaviour

Pressing CTRL+C opens XenonTrade.

Actual behaviour

Pressing CTRL+C does nothing.

To reproduce

Set your keyboard layout to anything where C is in a different location, such as Dvorak.

Your specifications

  • Platform: Windows 7
  • XenonTrade Version: 0.5a

I have tried the following

  • Running XenonTrade as admin
  • Exclude XenonTrade in my antivirus program
  • Closed similar tools that might interfere with XenonTrade

Also tried pressing the key that would be in the QWERTY C location (J on my keyboard), which is what Xenon is actually listening for, but that also doesn't work because PoE is not listening for that key, it's listening for the correct key.

Additional context

Caused by hard-coding the scancode when attaching the keydown listener.
Ideally this could just be configured in the settings to be whatever we like, but at the very least should respect the current keyboard layout instead of assuming the scancode.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions