From c81d00bf3a85da4e69f44b28248c04b9aaa59973 Mon Sep 17 00:00:00 2001 From: jborodinsky Date: Thu, 24 Jul 2025 09:12:53 -0400 Subject: [PATCH 01/25] windows ci-cd --- .github/workflows/build-action.yml | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build-action.yml b/.github/workflows/build-action.yml index 6a4bf78a7..fb894abd6 100644 --- a/.github/workflows/build-action.yml +++ b/.github/workflows/build-action.yml @@ -163,8 +163,8 @@ jobs: with: files: ${{ github.workspace }}/build/output/*.tar.gz - build-windows-2019: - runs-on: windows-2019 + build-windows-latest: + runs-on: windows-latest timeout-minutes: 60 steps: - @@ -178,6 +178,11 @@ jobs: uses: actions/setup-python@v5 with: python-version: '3.7.9' + - + name: install-VS2010-redistributable + run: | + Invoke-WebRequest "https://download.microsoft.com/download/1/6/5/165255E7-1014-4D0A-B094-B6A430A6BFFC/vcredist_x64.exe" -OutFile vcredist2010_x64.exe + .\vcredist2010_x64.exe /quiet /norestart - name: build shell: cmd @@ -185,7 +190,7 @@ jobs: python --version python -m pip install --upgrade setuptools six mkdir build && cd build - cmake -DCMAKE_INSTALL_PREFIX=gravity -G"Visual Studio 16 2019" -A x64 .. + cmake -DCMAKE_INSTALL_PREFIX=gravity -G"Visual Studio 17 2022" -A x64 .. cmake --build . --target install --config Release --parallel start /B gravity/bin/ServiceDirectory.exe ctest --test-dir gravity_external_examples_tests-prefix/src/gravity_external_examples_tests-build -C Release --verbose From 7ffc90d99ce1585dcd85d8419b5ff0b388efa60f Mon Sep 17 00:00:00 2001 From: jborodinsky Date: Thu, 24 Jul 2025 09:26:38 -0400 Subject: [PATCH 02/25] windows ci-cd --- .github/workflows/build-action.yml | 6 ------ 1 file changed, 6 deletions(-) diff --git a/.github/workflows/build-action.yml b/.github/workflows/build-action.yml index fb894abd6..a78c15f12 100644 --- a/.github/workflows/build-action.yml +++ b/.github/workflows/build-action.yml @@ -172,12 +172,6 @@ jobs: uses: actions/checkout@v3 with: fetch-depth: 0 - # Use a set working python version and VS-2019 as newer versions can't seem to load _gravity.pyd on Windows - - - name: setup-python - uses: actions/setup-python@v5 - with: - python-version: '3.7.9' - name: install-VS2010-redistributable run: | From 161b3553631dd51b05bfda5f43127e7fd1617022 Mon Sep 17 00:00:00 2001 From: jborodinsky Date: Thu, 24 Jul 2025 09:45:21 -0400 Subject: [PATCH 03/25] windows ci-cd --- .github/workflows/build-action.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build-action.yml b/.github/workflows/build-action.yml index a78c15f12..96a6025db 100644 --- a/.github/workflows/build-action.yml +++ b/.github/workflows/build-action.yml @@ -172,6 +172,8 @@ jobs: uses: actions/checkout@v3 with: fetch-depth: 0 + + # The pthreads-win32 build depends on the VS2010 runtime - which isn't on the latest runners - name: install-VS2010-redistributable run: | @@ -182,7 +184,7 @@ jobs: shell: cmd run: | python --version - python -m pip install --upgrade setuptools six + python -m pip install --upgrade six mkdir build && cd build cmake -DCMAKE_INSTALL_PREFIX=gravity -G"Visual Studio 17 2022" -A x64 .. cmake --build . --target install --config Release --parallel From 28f11ce1c8f7c79dea10bafe8fabb80732824873 Mon Sep 17 00:00:00 2001 From: jborodinsky Date: Thu, 24 Jul 2025 09:53:00 -0400 Subject: [PATCH 04/25] windows ci-cd --- .github/workflows/build-action.yml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/.github/workflows/build-action.yml b/.github/workflows/build-action.yml index 96a6025db..e603a96cb 100644 --- a/.github/workflows/build-action.yml +++ b/.github/workflows/build-action.yml @@ -173,6 +173,13 @@ jobs: with: fetch-depth: 0 + # Use a set working python version compatible with the older version of protobuf pulled in + - + name: setup-python + uses: actions/setup-python@v5 + with: + python-version: '3.7.9' + # The pthreads-win32 build depends on the VS2010 runtime - which isn't on the latest runners - name: install-VS2010-redistributable From ffd08ef5ea9bdf645586989b49dc27e4ebb8ccc3 Mon Sep 17 00:00:00 2001 From: jborodinsky Date: Thu, 24 Jul 2025 09:56:14 -0400 Subject: [PATCH 05/25] windows ci-cd --- .github/workflows/build-action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-action.yml b/.github/workflows/build-action.yml index e603a96cb..82be6c8a0 100644 --- a/.github/workflows/build-action.yml +++ b/.github/workflows/build-action.yml @@ -178,7 +178,7 @@ jobs: name: setup-python uses: actions/setup-python@v5 with: - python-version: '3.7.9' + python-version: '3.11' # The pthreads-win32 build depends on the VS2010 runtime - which isn't on the latest runners - From 0437c5b206bdd2a5b5cb948a450fda005f371ff3 Mon Sep 17 00:00:00 2001 From: jborodinsky Date: Thu, 24 Jul 2025 10:07:04 -0400 Subject: [PATCH 06/25] windows ci-cd --- .github/workflows/build-action.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build-action.yml b/.github/workflows/build-action.yml index 82be6c8a0..87333d39f 100644 --- a/.github/workflows/build-action.yml +++ b/.github/workflows/build-action.yml @@ -173,12 +173,12 @@ jobs: with: fetch-depth: 0 - # Use a set working python version compatible with the older version of protobuf pulled in + # Use a set working python version as newer versions can't seem to load _gravity.pyd on Windows - name: setup-python uses: actions/setup-python@v5 with: - python-version: '3.11' + python-version: '3.7.9' # The pthreads-win32 build depends on the VS2010 runtime - which isn't on the latest runners - From ba9e820490e5c44270a2f1c8bbcf96fcf7ebc9b8 Mon Sep 17 00:00:00 2001 From: jborodinsky Date: Thu, 24 Jul 2025 10:20:24 -0400 Subject: [PATCH 07/25] windows ci-cd --- .github/workflows/build-action.yml | 2 +- cmake/GravityExternalUrls.cmake | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build-action.yml b/.github/workflows/build-action.yml index 87333d39f..a54007079 100644 --- a/.github/workflows/build-action.yml +++ b/.github/workflows/build-action.yml @@ -178,7 +178,7 @@ jobs: name: setup-python uses: actions/setup-python@v5 with: - python-version: '3.7.9' + python-version: '3.11' # The pthreads-win32 build depends on the VS2010 runtime - which isn't on the latest runners - diff --git a/cmake/GravityExternalUrls.cmake b/cmake/GravityExternalUrls.cmake index 12273fd76..71d9f25f6 100644 --- a/cmake/GravityExternalUrls.cmake +++ b/cmake/GravityExternalUrls.cmake @@ -16,7 +16,7 @@ set(spdlog_url "https://github.com/gabime/spdlog/archive/refs/tags/v1.9.2.zip") set(boost_url "https://dl.bintray.com/boostorg/release/1.72.0/source/boost_1_72_0.zip") -set(swigwin_url "http://prdownloads.sourceforge.net/swig/swigwin-4.0.1.zip") +set(swigwin_url "http://prdownloads.sourceforge.net/swig/swigwin-4.3.1.zip") set(lexyacc_win_url "https://master.dl.sourceforge.net/project/winflexbison/old_versions/win_flex_bison-2.5.22.zip") From 3342c59c07d6a2f4ee709e66d1debb3ff7c8b836 Mon Sep 17 00:00:00 2001 From: jborodinsky Date: Thu, 24 Jul 2025 10:30:14 -0400 Subject: [PATCH 08/25] windows ci-cd --- .github/workflows/build-action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-action.yml b/.github/workflows/build-action.yml index a54007079..6c225c7d8 100644 --- a/.github/workflows/build-action.yml +++ b/.github/workflows/build-action.yml @@ -178,7 +178,7 @@ jobs: name: setup-python uses: actions/setup-python@v5 with: - python-version: '3.11' + python-version: '3.10' # The pthreads-win32 build depends on the VS2010 runtime - which isn't on the latest runners - From ee2a5507df5252872794d25dcd26e63ab264c29f Mon Sep 17 00:00:00 2001 From: jborodinsky Date: Thu, 24 Jul 2025 10:39:27 -0400 Subject: [PATCH 09/25] windows ci-cd --- .github/workflows/build-action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-action.yml b/.github/workflows/build-action.yml index 6c225c7d8..4d547a5ef 100644 --- a/.github/workflows/build-action.yml +++ b/.github/workflows/build-action.yml @@ -178,7 +178,7 @@ jobs: name: setup-python uses: actions/setup-python@v5 with: - python-version: '3.10' + python-version: '3.9' # The pthreads-win32 build depends on the VS2010 runtime - which isn't on the latest runners - From 37d8468438622c3b95122ea0747dc2fabbedb696 Mon Sep 17 00:00:00 2001 From: jborodinsky Date: Thu, 24 Jul 2025 10:40:04 -0400 Subject: [PATCH 10/25] windows ci-cd --- .github/workflows/build-action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-action.yml b/.github/workflows/build-action.yml index 4d547a5ef..86a3e689c 100644 --- a/.github/workflows/build-action.yml +++ b/.github/workflows/build-action.yml @@ -178,7 +178,7 @@ jobs: name: setup-python uses: actions/setup-python@v5 with: - python-version: '3.9' + python-version: '3.8' # The pthreads-win32 build depends on the VS2010 runtime - which isn't on the latest runners - From c9a3a51033c62400c67cfd06591e5e731d815d52 Mon Sep 17 00:00:00 2001 From: jborodinsky Date: Thu, 24 Jul 2025 10:40:48 -0400 Subject: [PATCH 11/25] windows ci-cd --- .github/workflows/build-action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-action.yml b/.github/workflows/build-action.yml index 86a3e689c..87333d39f 100644 --- a/.github/workflows/build-action.yml +++ b/.github/workflows/build-action.yml @@ -178,7 +178,7 @@ jobs: name: setup-python uses: actions/setup-python@v5 with: - python-version: '3.8' + python-version: '3.7.9' # The pthreads-win32 build depends on the VS2010 runtime - which isn't on the latest runners - From aa2804f23e612fd4be3d4fcc0a7e0bab079edf16 Mon Sep 17 00:00:00 2001 From: jborodinsky Date: Thu, 24 Jul 2025 20:22:31 -0400 Subject: [PATCH 12/25] Call os.add_dll_directory on windows in python >= 3.8 --- src/api/python/src/python/gravity/__init__.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/api/python/src/python/gravity/__init__.py b/src/api/python/src/python/gravity/__init__.py index 63dc6f740..c10ddee25 100644 --- a/src/api/python/src/python/gravity/__init__.py +++ b/src/api/python/src/python/gravity/__init__.py @@ -14,7 +14,11 @@ # License along with this program; # If not, see . # - +import os +if hasattr(os, "add_dll_directory"): # Python >=3.8 on Windows does not search using PATH + bin_dir = os.path.join(os.path.abspath(os.path.dirname(__file__)), "..", "..", "bin") + os.add_dll_directory(bin_dir) + from .gravity import GravityNode, GravitySubscriber, GravityRequestor, GravityServiceProvider, GravityHeartbeatListener, Log, Logger, SpdLog from .GravityDataProduct import GravityDataProduct from .GravityLogHandler import GravityLogHandler From 1a1e71ee0c3582dcf179fd7061567fd33d19a24d Mon Sep 17 00:00:00 2001 From: jborodinsky Date: Thu, 24 Jul 2025 20:24:23 -0400 Subject: [PATCH 13/25] ci-cd build, on windows use python 3.11 --- .github/workflows/build-action.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/build-action.yml b/.github/workflows/build-action.yml index 87333d39f..e7949e229 100644 --- a/.github/workflows/build-action.yml +++ b/.github/workflows/build-action.yml @@ -172,13 +172,11 @@ jobs: uses: actions/checkout@v3 with: fetch-depth: 0 - - # Use a set working python version as newer versions can't seem to load _gravity.pyd on Windows - name: setup-python uses: actions/setup-python@v5 with: - python-version: '3.7.9' + python-version: '3.11' # The pthreads-win32 build depends on the VS2010 runtime - which isn't on the latest runners - From f6d9c466a4a25cb712b6df84a1e1d625ab8cb370 Mon Sep 17 00:00:00 2001 From: jborodinsky Date: Tue, 29 Jul 2025 15:36:05 -0400 Subject: [PATCH 14/25] CI: try adding container credentials to workflow --- .github/workflows/build-action.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/build-action.yml b/.github/workflows/build-action.yml index e7949e229..94596662a 100644 --- a/.github/workflows/build-action.yml +++ b/.github/workflows/build-action.yml @@ -11,6 +11,9 @@ jobs: runs-on: ubuntu-latest container: image: ghcr.io/aphysci/gravity_base:bionic + credentials: + username: ${{ github.actor }} + password: ${{ secrets.GHCR_TOKEN }} volumes: - /node20217:/node20217:rw,rshared - /node20217:/__e/node20:ro,rshared From a9f88757ee445ff24b360363929ed812e8c03563 Mon Sep 17 00:00:00 2001 From: jborodinsky Date: Tue, 29 Jul 2025 15:39:22 -0400 Subject: [PATCH 15/25] CI: try adding container credentials to workflow --- .github/workflows/build-action.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build-action.yml b/.github/workflows/build-action.yml index 94596662a..72997028b 100644 --- a/.github/workflows/build-action.yml +++ b/.github/workflows/build-action.yml @@ -12,8 +12,8 @@ jobs: container: image: ghcr.io/aphysci/gravity_base:bionic credentials: - username: ${{ github.actor }} - password: ${{ secrets.GHCR_TOKEN }} + username: ${{ github.actor }} + password: ${{ secrets.github_token }} volumes: - /node20217:/node20217:rw,rshared - /node20217:/__e/node20:ro,rshared From d7561693d6c335efc79824a5871c1d57908a785e Mon Sep 17 00:00:00 2001 From: jborodinsky Date: Tue, 29 Jul 2025 15:43:35 -0400 Subject: [PATCH 16/25] CI: try adding container credentials to workflow --- .github/workflows/build-action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-action.yml b/.github/workflows/build-action.yml index 72997028b..f741535d7 100644 --- a/.github/workflows/build-action.yml +++ b/.github/workflows/build-action.yml @@ -13,7 +13,7 @@ jobs: image: ghcr.io/aphysci/gravity_base:bionic credentials: username: ${{ github.actor }} - password: ${{ secrets.github_token }} + password: ${{ secrets.GITHUB_TOKEN }} volumes: - /node20217:/node20217:rw,rshared - /node20217:/__e/node20:ro,rshared From 026ad2c365a6d9c5ab906bb94feda6e43c8e8017 Mon Sep 17 00:00:00 2001 From: jborodinsky Date: Tue, 29 Jul 2025 15:57:00 -0400 Subject: [PATCH 17/25] CI: try adding container credentials to workflow --- .github/workflows/build-action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-action.yml b/.github/workflows/build-action.yml index f741535d7..32bf93b48 100644 --- a/.github/workflows/build-action.yml +++ b/.github/workflows/build-action.yml @@ -13,7 +13,7 @@ jobs: image: ghcr.io/aphysci/gravity_base:bionic credentials: username: ${{ github.actor }} - password: ${{ secrets.GITHUB_TOKEN }} + password: ${{ secrets.PAT }} volumes: - /node20217:/node20217:rw,rshared - /node20217:/__e/node20:ro,rshared From 7a5ada2b120803e39f509d82020270f4cb1545d7 Mon Sep 17 00:00:00 2001 From: jborodinsky Date: Tue, 29 Jul 2025 15:59:54 -0400 Subject: [PATCH 18/25] CI: container credentials added --- .github/workflows/build-action.yml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.github/workflows/build-action.yml b/.github/workflows/build-action.yml index 32bf93b48..92922f923 100644 --- a/.github/workflows/build-action.yml +++ b/.github/workflows/build-action.yml @@ -59,6 +59,9 @@ jobs: runs-on: ubuntu-latest container: image: ghcr.io/aphysci/gravity_base:focal + credentials: + username: ${{ github.actor }} + password: ${{ secrets.PAT }} steps: - name: clone @@ -96,6 +99,9 @@ jobs: runs-on: ubuntu-latest container: image: ghcr.io/aphysci/gravity_base:jammy + credentials: + username: ${{ github.actor }} + password: ${{ secrets.PAT }} steps: - name: clone @@ -133,6 +139,9 @@ jobs: runs-on: ubuntu-latest container: image: ghcr.io/aphysci/gravity_base:alma + credentials: + username: ${{ github.actor }} + password: ${{ secrets.PAT }} steps: - name: clone From 55ba1bb9d6aad5e0705b314681287fe5bc84afa1 Mon Sep 17 00:00:00 2001 From: jborodinsky Date: Tue, 29 Jul 2025 16:21:11 -0400 Subject: [PATCH 19/25] CI: container credentials added --- .github/workflows/build-action.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build-action.yml b/.github/workflows/build-action.yml index 92922f923..88b8d7372 100644 --- a/.github/workflows/build-action.yml +++ b/.github/workflows/build-action.yml @@ -9,11 +9,13 @@ on: jobs: build-bionic: runs-on: ubuntu-latest + permissions: + packages: read container: image: ghcr.io/aphysci/gravity_base:bionic credentials: username: ${{ github.actor }} - password: ${{ secrets.PAT }} + password: ${{ secrets.GITHUB_TOKEN }} volumes: - /node20217:/node20217:rw,rshared - /node20217:/__e/node20:ro,rshared From 5bdd1ba9363690b6b32e084363167c9504629980 Mon Sep 17 00:00:00 2001 From: jborodinsky Date: Tue, 29 Jul 2025 16:30:18 -0400 Subject: [PATCH 20/25] Revert "CI: container credentials added" This reverts commit 55ba1bb9d6aad5e0705b314681287fe5bc84afa1. --- .github/workflows/build-action.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/build-action.yml b/.github/workflows/build-action.yml index 88b8d7372..92922f923 100644 --- a/.github/workflows/build-action.yml +++ b/.github/workflows/build-action.yml @@ -9,13 +9,11 @@ on: jobs: build-bionic: runs-on: ubuntu-latest - permissions: - packages: read container: image: ghcr.io/aphysci/gravity_base:bionic credentials: username: ${{ github.actor }} - password: ${{ secrets.GITHUB_TOKEN }} + password: ${{ secrets.PAT }} volumes: - /node20217:/node20217:rw,rshared - /node20217:/__e/node20:ro,rshared From c633e3f0ec774e5f39499b286e97adfe92fb49c8 Mon Sep 17 00:00:00 2001 From: jborodinsky Date: Tue, 29 Jul 2025 16:30:28 -0400 Subject: [PATCH 21/25] Revert "CI: container credentials added" This reverts commit 7a5ada2b120803e39f509d82020270f4cb1545d7. --- .github/workflows/build-action.yml | 9 --------- 1 file changed, 9 deletions(-) diff --git a/.github/workflows/build-action.yml b/.github/workflows/build-action.yml index 92922f923..32bf93b48 100644 --- a/.github/workflows/build-action.yml +++ b/.github/workflows/build-action.yml @@ -59,9 +59,6 @@ jobs: runs-on: ubuntu-latest container: image: ghcr.io/aphysci/gravity_base:focal - credentials: - username: ${{ github.actor }} - password: ${{ secrets.PAT }} steps: - name: clone @@ -99,9 +96,6 @@ jobs: runs-on: ubuntu-latest container: image: ghcr.io/aphysci/gravity_base:jammy - credentials: - username: ${{ github.actor }} - password: ${{ secrets.PAT }} steps: - name: clone @@ -139,9 +133,6 @@ jobs: runs-on: ubuntu-latest container: image: ghcr.io/aphysci/gravity_base:alma - credentials: - username: ${{ github.actor }} - password: ${{ secrets.PAT }} steps: - name: clone From 01afb0e000bf4900fd68323c566899d3f27d4bfc Mon Sep 17 00:00:00 2001 From: jborodinsky Date: Tue, 29 Jul 2025 16:30:36 -0400 Subject: [PATCH 22/25] Revert "CI: try adding container credentials to workflow" This reverts commit 026ad2c365a6d9c5ab906bb94feda6e43c8e8017. --- .github/workflows/build-action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-action.yml b/.github/workflows/build-action.yml index 32bf93b48..f741535d7 100644 --- a/.github/workflows/build-action.yml +++ b/.github/workflows/build-action.yml @@ -13,7 +13,7 @@ jobs: image: ghcr.io/aphysci/gravity_base:bionic credentials: username: ${{ github.actor }} - password: ${{ secrets.PAT }} + password: ${{ secrets.GITHUB_TOKEN }} volumes: - /node20217:/node20217:rw,rshared - /node20217:/__e/node20:ro,rshared From e73ea3d04b9776e5d91dc926b30186389d6a2aed Mon Sep 17 00:00:00 2001 From: jborodinsky Date: Tue, 29 Jul 2025 16:30:44 -0400 Subject: [PATCH 23/25] Revert "CI: try adding container credentials to workflow" This reverts commit d7561693d6c335efc79824a5871c1d57908a785e. --- .github/workflows/build-action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-action.yml b/.github/workflows/build-action.yml index f741535d7..72997028b 100644 --- a/.github/workflows/build-action.yml +++ b/.github/workflows/build-action.yml @@ -13,7 +13,7 @@ jobs: image: ghcr.io/aphysci/gravity_base:bionic credentials: username: ${{ github.actor }} - password: ${{ secrets.GITHUB_TOKEN }} + password: ${{ secrets.github_token }} volumes: - /node20217:/node20217:rw,rshared - /node20217:/__e/node20:ro,rshared From e34e828954154882fcdfaf482505a474a04093c1 Mon Sep 17 00:00:00 2001 From: jborodinsky Date: Tue, 29 Jul 2025 16:30:50 -0400 Subject: [PATCH 24/25] Revert "CI: try adding container credentials to workflow" This reverts commit a9f88757ee445ff24b360363929ed812e8c03563. --- .github/workflows/build-action.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build-action.yml b/.github/workflows/build-action.yml index 72997028b..94596662a 100644 --- a/.github/workflows/build-action.yml +++ b/.github/workflows/build-action.yml @@ -12,8 +12,8 @@ jobs: container: image: ghcr.io/aphysci/gravity_base:bionic credentials: - username: ${{ github.actor }} - password: ${{ secrets.github_token }} + username: ${{ github.actor }} + password: ${{ secrets.GHCR_TOKEN }} volumes: - /node20217:/node20217:rw,rshared - /node20217:/__e/node20:ro,rshared From 327a69307d913d0105a3c1f905794195f3f67591 Mon Sep 17 00:00:00 2001 From: jborodinsky Date: Tue, 29 Jul 2025 16:32:46 -0400 Subject: [PATCH 25/25] manually revert a section --- .github/workflows/build-action.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/build-action.yml b/.github/workflows/build-action.yml index 94596662a..e7949e229 100644 --- a/.github/workflows/build-action.yml +++ b/.github/workflows/build-action.yml @@ -11,9 +11,6 @@ jobs: runs-on: ubuntu-latest container: image: ghcr.io/aphysci/gravity_base:bionic - credentials: - username: ${{ github.actor }} - password: ${{ secrets.GHCR_TOKEN }} volumes: - /node20217:/node20217:rw,rshared - /node20217:/__e/node20:ro,rshared