Fix model constant issue

Author: kennethphough

src/Core/Logger.php

@@ -139,7 +139,7 @@ private static function log($level, $message, array $context = [])
         }
 
         try {
-            $error = new ModelObject('KyteError');
+            $error = new ModelObject(KyteError);
 
             // Get caller information for file/line
             $backtrace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, 3);

src/Mvc/Controller/CronJobController.php

@@ -451,7 +451,7 @@ private function getNextRunTime(int $jobId): ?int
      */
     private function handleTrigger(int $jobId): void
     {
-        $job = new ModelObject('CronJob');
+        $job = new ModelObject(CronJob);
         $job->retrieve('id', $jobId);
 
         if (!$job->id) {
@@ -505,7 +505,7 @@ private function handleTrigger(int $jobId): void
      */
     private function handleRecover(int $jobId): void
     {
-        $job = new ModelObject('CronJob');
+        $job = new ModelObject(CronJob);
         $job->retrieve('id', $jobId);
 
         if (!$job->id) {
@@ -542,7 +542,7 @@ private function handleRecover(int $jobId): void
      */
     private function handleRollback(int $jobId, array $data): void
     {
-        $job = new ModelObject('CronJob');
+        $job = new ModelObject(CronJob);
         $job->retrieve('id', $jobId);
 
         if (!$job->id) {
@@ -571,7 +571,7 @@ private function handleRollback(int $jobId, array $data): void
      */
     private function handleStats(int $jobId): void
     {
-        $job = new ModelObject('CronJob');
+        $job = new ModelObject(CronJob);
         $job->retrieve('id', $jobId);
 
         if (!$job->id) {
@@ -616,7 +616,7 @@ private function handleStats(int $jobId): void
      */
     private function createDefaultFunctions(int $jobId, ?int $userId): void
     {
-        $job = new ModelObject('CronJob');
+        $job = new ModelObject(CronJob);
         $job->retrieve('id', $jobId);
         if (!$job->id) {
             return;
@@ -645,7 +645,7 @@ private function createDefaultFunctions(int $jobId, ?int $userId): void
             $contentHash = hash('sha256', $functionBody);
 
             // Check if content exists (unlikely for defaults, but check anyway)
-            $existingContent = new ModelObject('CronJobFunctionContent');
+            $existingContent = new ModelObject(CronJobFunctionContent);
             $existingContent->retrieve('content_hash', $contentHash);
 
             if (!$existingContent->id) {
@@ -660,7 +660,7 @@ private function createDefaultFunctions(int $jobId, ?int $userId): void
                     'date_created' => time()
                 ];
 
-                $contentObj = new ModelObject('CronJobFunctionContent');
+                $contentObj = new ModelObject(CronJobFunctionContent);
                 $contentObj->create($contentData, $userId);
             } else {
                 // Increment reference count
@@ -679,7 +679,7 @@ private function createDefaultFunctions(int $jobId, ?int $userId): void
                 'date_created' => time()
             ];
 
-            $functionObj = new ModelObject('CronJobFunction');
+            $functionObj = new ModelObject(CronJobFunction);
             $functionObj->create($functionData, $userId);
 
             // Create initial version (version 1)

src/Mvc/Controller/CronJobFunctionController.php

@@ -41,7 +41,7 @@ public function new($data)
             return;
         }
 
-        $cronJob = new ModelObject('CronJob');
+        $cronJob = new ModelObject(CronJob);
         $cronJob->retrieve('id', $data['cron_job']);
         if (!$cronJob->id) {
             $this->respondError('Cron job not found', 404);
@@ -63,7 +63,7 @@ public function new($data)
         $contentHash = hash('sha256', $functionBody);
 
         // Check if content already exists
-        $existingContent = new ModelObject('CronJobFunctionContent');
+        $existingContent = new ModelObject(CronJobFunctionContent);
         $existingContent->retrieve('content_hash', $contentHash);
 
         if ($existingContent->id) {
@@ -82,7 +82,7 @@ public function new($data)
                 'date_created' => time()
             ];
 
-            $contentObj = new ModelObject('CronJobFunctionContent');
+            $contentObj = new ModelObject(CronJobFunctionContent);
             $contentObj->create($contentData, $this->api->user ? $this->api->user->id : null);
         }
 
@@ -116,7 +116,7 @@ public function update($field, $value, $data)
     {
         $functionId = $value;
 
-        $function = new ModelObject('CronJobFunction');
+        $function = new ModelObject(CronJobFunction);
         $function->retrieve('id', $functionId);
         if (!$function->id) {
             $this->respondError('Function not found', 404);
@@ -150,7 +150,7 @@ public function update($field, $value, $data)
                 $nextVersion = ($versionResult[0]['max_version'] ?? 0) + 1;
 
                 // Check if new content already exists
-                $existingContent = new ModelObject('CronJobFunctionContent');
+                $existingContent = new ModelObject(CronJobFunctionContent);
                 $existingContent->retrieve('content_hash', $newContentHash);
 
                 if (!$existingContent->id) {
@@ -165,7 +165,7 @@ public function update($field, $value, $data)
                         'date_created' => time()
                     ];
 
-                    $contentObj = new ModelObject('CronJobFunctionContent');
+                    $contentObj = new ModelObject(CronJobFunctionContent);
                     $contentObj->create($contentData, $this->api->user ? $this->api->user->id : null);
                 } else {
                     // Increment reference count
@@ -175,7 +175,7 @@ public function update($field, $value, $data)
 
                 // Decrement old content reference count
                 if ($function->content_hash) {
-                    $oldContent = new ModelObject('CronJobFunctionContent');
+                    $oldContent = new ModelObject(CronJobFunctionContent);
                     $oldContent->retrieve('content_hash', $function->content_hash);
                     if ($oldContent->id && $oldContent->reference_count > 0) {
                         $oldContent->reference_count--;