You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Follow-ups deferred from #88's review loop (3 rounds, Copilot + subagent). #88 established utils/domain.sh (domain::resolve / domain::driver / domain::require_driver) as the single domain-resolution + driver-identity point; these sites still derive independently:
libs/image:33 — image::_registry_tls keys off DOMAIN_NAME while image::list/cache use the inherited domain local: --domain X can mix X's cache IP with DOMAIN_NAME's TLS scheme.
libs/image — the driver gate now precedes the LOK8S_REGISTRY_IP_CACHE check, so the documented env override is unreachable for non-lo domains (previously env-only worked, e.g. a shared cache). Decide: allow the override to bypass the gate, or drop the claim from the error text.
lo clean on a driver-migrated/deleted domain skips registry cleanup (visible warn + manual docker rm hint) — consider a name-based sweep.
LOK8S_DOMAIN_EXPLICIT can be set by a post-positional --domain that argsh never parses (no reachable consumer divergence today — main::use positionals win — but it's an exported env a future consumer could trust).
Nested lo invocations (Tilt local()) re-print the env-vs-.active notice per call — consider dedup via an env marker.
Follow-ups deferred from #88's review loop (3 rounds, Copilot + subagent). #88 established
utils/domain.sh(domain::resolve/domain::driver/domain::require_driver) as the single domain-resolution + driver-identity point; these sites still derive independently:Independent
yq '.kind'sniffs →domain::driver:lo:203(_lo_header),lo:284(main::down— ALSO missing// "": a kind-less spec yields the literalnulland routes toprovision::dispatch_destroy; and it still uses the maskableyq | trpipeline fix(cli): single domain-resolution point — env precedence, driver gates, honest errors #88 removed elsewhere)libs/provision:180/319/367,libs/status:140,libs/kubehz/main:82/108,libs/kubehz/hosted:21,libs/bootstrap:100/937,libs/addons:53/271,libs/inventory/main:71,libs/audit:142,libs/lint:459,libs/use:74(display-only),libs/doctor:96Behavioral leftovers:
libs/image:33—image::_registry_tlskeys offDOMAIN_NAMEwhileimage::list/cacheuse the inheriteddomainlocal:--domain Xcan mix X's cache IP with DOMAIN_NAME's TLS scheme.libs/image— the driver gate now precedes theLOK8S_REGISTRY_IP_CACHEcheck, so the documented env override is unreachable for non-lo domains (previously env-only worked, e.g. a shared cache). Decide: allow the override to bypass the gate, or drop the claim from the error text.lo cleanon a driver-migrated/deleted domain skips registry cleanup (visible warn + manualdocker rmhint) — consider a name-based sweep.LOK8S_DOMAIN_EXPLICITcan be set by a post-positional--domainthat argsh never parses (no reachable consumer divergence today —main::usepositionals win — but it's an exported env a future consumer could trust).loinvocations (Tiltlocal()) re-print the env-vs-.active notice per call — consider dedup via an env marker.🤖 Generated with Claude Code