Merge pull request #378 from oyarzun/transfer-action-support

Add required TFERACTION to TRANSFER

Author: kedder

src/ofxstatement/ofx.py

@@ -248,8 +248,11 @@ def buildInvestTransaction(self, line: InvestStatementLine) -> None:
             inner_tran_type_tag_name = (
                 None  # income transactions don't have an envelope element
             )
+        elif line.trntype == "TRANSFER":
+            tran_type_detailed_tag_name = "TFERACTION"
+            inner_tran_type_tag_name = None
         else:
-            # INVEXPENSE and TRANSFER transactions don't have details or an envelope
+            # INVEXPENSE transactions don't have details or an envelope
             tran_type_detailed_tag_name = None
             inner_tran_type_tag_name = None
 

src/ofxstatement/statement.py

@@ -55,6 +55,10 @@
     "SELLSHORT",  # open short sale
 ]
 
+INVEST_TRANSACTION_TFERACTION = [
+    "IN",
+    "OUT",
+]
 INVEST_TRANSACTION_INCOMETYPES = [
     "CGLONG",
     "CGSHORT",
@@ -376,8 +380,11 @@ def assert_valid_sellstock(self):
 
     def assert_valid_transfer(self):
         assert (
-            self.trntype_detailed is None
-        ), f"trntype_detailed '{self.trntype_detailed}' should be empty for {self.trntype}"
+            self.trntype_detailed in INVEST_TRANSACTION_TFERACTION
+        ), "trntype_detailed %s is not valid, must be one of %s" % (
+            self.trntype_detailed,
+            INVEST_TRANSACTION_TFERACTION,
+        )
         assert self.security_id
         assert self.units
 

src/ofxstatement/tests/test_ofx_invest.py

@@ -137,6 +137,7 @@
                         <SUBACCTFUND>OTHER</SUBACCTFUND>
                     </INVBANKTRAN>
                     <TRANSFER>
+                        <TFERACTION>IN</TFERACTION>
                         <INVTRAN>
                             <FITID>7</FITID>
                             <DTTRADE>20210103</DTTRADE>
@@ -239,7 +240,7 @@ def test_ofxWriter(self) -> None:
         statement.invest_lines.append(invest_line)
 
         invest_line = InvestStatementLine(
-            "7", datetime(2021, 1, 3), "Journaled Shares", "TRANSFER"
+            "7", datetime(2021, 1, 3), "Journaled Shares", "TRANSFER", "IN"
         )
         invest_line.security_id = "MSFT"
         invest_line.units = Decimal("4")

src/ofxstatement/tests/test_statement.py

@@ -54,6 +54,7 @@ def test_generate_unique_transaction_id(self) -> None:
     def test_transfer_line_validation(self) -> None:
         line = statement.InvestStatementLine("id", datetime(2020, 3, 25))
         line.trntype = "TRANSFER"
+        line.trntype_detailed = "IN"
         line.security_id = "ABC"
         line.units = Decimal(2)
         line.assert_valid()