Fails to build with MinGW

[NTULINUX]

[ 20%] Building CXX object fmt-11.2.0/CMakeFiles/dsoal.fmt.dir/src/os.cc.obj
cd /home/fedora/dev/dsoal/fmt-11.2.0 && /home/fedora/llvm-mingw/bin/i686-w64-mingw32-clang++ -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_FAST @CMakeFiles/dsoal.fmt.dir/includes_CXX.rsp -O3 -DNDEBUG -std=gnu++20 -fvisibility=hidden -MD -MT fmt-11.2.0/CMakeFiles/dsoal.fmt.dir/src/os.cc.obj -MF CMakeFiles/dsoal.fmt.dir/src/os.cc.obj.d -o CMakeFiles/dsoal.fmt.dir/src/os.cc.obj -c /home/fedora/dev/dsoal/fmt-11.2.0/src/os.cc
In file included from /home/fedora/dev/dsoal/fmt-11.2.0/src/os.cc:13:
In file included from /home/fedora/dev/dsoal/fmt-11.2.0/include/fmt/os.h:11:
/home/fedora/dev/dsoal/fmt-11.2.0/include/fmt/format.h:747:28: error: use of undeclared identifier 'malloc'
  747 |     T* p = static_cast<T*>(malloc(n * sizeof(T)));
      |                            ^~~~~~
/home/fedora/dev/dsoal/fmt-11.2.0/include/fmt/format.h:752:35: error: call to function 'free' that is neither visible in the template definition nor found by argument-dependent
      lookup
  752 |   void deallocate(T* p, size_t) { free(p); }
      |                                   ^
/home/fedora/dev/dsoal/fmt-11.2.0/include/fmt/format.h:812:46: note: in instantiation of member function 'fmt::detail::allocator<int>::deallocate' requested here
  812 |     if (old_data != self.store_) self.alloc_.deallocate(old_data, old_capacity);
      |                                              ^
/home/fedora/llvm-mingw/i686-w64-mingw32/include/stdlib.h:456:16: note: 'free' should be declared prior to the call site
  456 |   void __cdecl free(void *_Memory);
      |                ^
In file included from /home/fedora/dev/dsoal/fmt-11.2.0/src/os.cc:13:
In file included from /home/fedora/dev/dsoal/fmt-11.2.0/include/fmt/os.h:11:
/home/fedora/dev/dsoal/fmt-11.2.0/include/fmt/format.h:752:35: error: call to function 'free' that is neither visible in the template definition nor found by argument-dependent
      lookup
  752 |   void deallocate(T* p, size_t) { free(p); }
      |                                   ^
/home/fedora/dev/dsoal/fmt-11.2.0/include/fmt/format.h:812:46: note: in instantiation of member function 'fmt::detail::allocator<char>::deallocate' requested here
  812 |     if (old_data != self.store_) self.alloc_.deallocate(old_data, old_capacity);
      |                                              ^
/home/fedora/llvm-mingw/i686-w64-mingw32/include/stdlib.h:456:16: note: 'free' should be declared prior to the call site
  456 |   void __cdecl free(void *_Memory);
      |                ^
In file included from /home/fedora/dev/dsoal/fmt-11.2.0/src/os.cc:13:
In file included from /home/fedora/dev/dsoal/fmt-11.2.0/include/fmt/os.h:11:
/home/fedora/dev/dsoal/fmt-11.2.0/include/fmt/format.h:752:35: error: call to function 'free' that is neither visible in the template definition nor found by argument-dependent
      lookup
  752 |   void deallocate(T* p, size_t) { free(p); }
      |                                   ^
/home/fedora/dev/dsoal/fmt-11.2.0/include/fmt/format.h:812:46: note: in instantiation of member function 'fmt::detail::allocator<unsigned int>::deallocate' requested here
  812 |     if (old_data != self.store_) self.alloc_.deallocate(old_data, old_capacity);
      |                                              ^
/home/fedora/llvm-mingw/i686-w64-mingw32/include/stdlib.h:456:16: note: 'free' should be declared prior to the call site
  456 |   void __cdecl free(void *_Memory);
      |                ^
4 errors generated.
make[2]: *** [fmt-11.2.0/CMakeFiles/dsoal.fmt.dir/build.make:95: fmt-11.2.0/CMakeFiles/dsoal.fmt.dir/src/os.cc.obj] Error 1
make[2]: Leaving directory '/home/fedora/dev/dsoal'
make[1]: *** [CMakeFiles/Makefile2:208: fmt-11.2.0/CMakeFiles/dsoal.fmt.dir/all] Error 2
make[1]: Leaving directory '/home/fedora/dev/dsoal'
make: *** [Makefile:156: all] Error 2

I had to make this file called mingw.conf:

set(CMAKE_SYSTEM_NAME Windows)
set(CMAKE_C_COMPILER i686-w64-mingw32-clang)
set(CMAKE_CXX_COMPILER i686-w64-mingw32-clang++)
set(CMAKE_RC_COMPILER i686-w64-mingw32-windres)
set(CMAKE_FIND_ROOT_PATH /home/fedora/llvm-mingw/generic-w64-mingw32/include)

and then specified -DCMAKE_TOOLCHAIN_FILE=mingw.conf on cmake line. Not sure how you're supposed to build DSOAL outside of MSVC so I might have hooked this up wrong. I am on Linux but intend to use with Wine, thanks!

Btw, my exact toolchain is hosted here: https://github.com/NTULINUX/llvm-mingw/releases/tag/03122026

For now I will just use your binary release. If you have any info on building with MinGW please let me know!

[WinterSnowfall]

Works just fine with MinGW on Arch, see attached logs: dsound_mingw.log

So whatever problem you're running into, it isn't one of the codebase's making. As to my build script: https://github.com/WinterSnowfall/wroshyr_builder/blob/main/misc/package-release_dsoal.sh

[kcat]

The issue is in fmtlib, which uses malloc and free without explicitly including stdlib.h to declare the functions. With most compilers/libc implementations, the headers fmtlib does include will implicitly include stdlib.h to declare those functions, so most people don't see a problem. But on some versions of some compilers/libc implementations, stdlib.h won't be implicitly included, and give that error.

fmtlib did fix that problem, but it was after the 11.2.0 version that DSOAL uses. I could either fix the code manually, or update to a newer version of fmtlib. Or update to C++23 and use the standard format/print functions instead of a third-party library.

[NTULINUX]

I tried updating fmtlib to 12.1 but I am more familiar with GNU autotools than cmake.

I ran into:

-- {fmt} version: 12.1.0
-- Build type: 
-- 
-- STL hardening level: Default
-- 
-- Configuring done (0.0s)
CMake Error at CMakeLists.txt:226 (target_link_libraries):
  Target "dsound" links to:

    dsoal::fmt

  but the target was not found.  Possible reasons include:

    * There is a typo in the target name.
    * A find_package call is missing for an IMPORTED target.
    * An ALIAS target is missing.



-- Generating done (0.0s)
CMake Generate step failed.  Build files cannot be regenerated correctly.
[ 12%] Generating version_witness.txt
[ 12%] Building CXX object fmt-12.1.0/CMakeFiles/fmt.dir/src/os.cc.obj
[ 18%] Building CXX object fmt-12.1.0/CMakeFiles/fmt.dir/src/format.cc.obj
[ 18%] Built target dsoal.build_version
[ 31%] Building CXX object CMakeFiles/dsound.dir/src/eax.cpp.obj
[ 31%] Building CXX object CMakeFiles/dsound.dir/src/dsoal.cpp.obj
[ 37%] Building CXX object CMakeFiles/dsound.dir/src/buffer.cpp.obj
[ 50%] Building CXX object CMakeFiles/dsound.dir/src/dsoundoal.cpp.obj
[ 50%] Building CXX object CMakeFiles/dsound.dir/src/capture.cpp.obj
[ 56%] Building CXX object CMakeFiles/dsound.dir/src/factory.cpp.obj
[ 62%] Building CXX object CMakeFiles/dsound.dir/src/logging.cpp.obj
[ 68%] Building CXX object CMakeFiles/dsound.dir/src/primarybuffer.cpp.obj
[ 75%] Building CXX object CMakeFiles/dsound.dir/src/propset.cpp.obj
[ 81%] Building CXX object CMakeFiles/dsound.dir/src/fullduplex.cpp.obj
[ 87%] Building RC object CMakeFiles/dsound.dir/version.rc.obj
make[2]: windres: No such file or directory
make[2]: *** [CMakeFiles/dsound.dir/build.make:228: CMakeFiles/dsound.dir/version.rc.obj] Error 127
make[2]: *** Waiting for unfinished jobs....
In file included from /home/fedora/dev/dsoal/src/buffer.cpp:1:
In file included from /home/fedora/dev/dsoal/src/buffer.h:18:
/home/fedora/dev/dsoal/src/dsoal.h:26:31: warning: identifier '_i64' preceded by whitespace in a literal operator declaration is deprecated [-Wdeprecated-literal-operator]
   26 | constexpr int64_t operator "" _i64(unsigned long long int n) noexcept { return static_cast<int64_t>(n); }
      |                   ~~~~~~~~~~~~^~~~
      |                   operator""_i64
/home/fedora/dev/dsoal/src/dsoal.h:27:32: warning: identifier '_u64' preceded by whitespace in a literal operator declaration is deprecated [-Wdeprecated-literal-operator]
   27 | constexpr uint64_t operator "" _u64(unsigned long long int n) noexcept { return static_cast<uint64_t>(n); }
      |                    ~~~~~~~~~~~~^~~~
      |                    operator""_u64
In file included from /home/fedora/dev/dsoal/src/dsoal.cpp:3:
/home/fedora/dev/dsoal/src/dsoal.h:26:31: warning: identifier '_i64' preceded by whitespace in a literal operator declaration is deprecated [-Wdeprecated-literal-operator]
   26 | constexpr int64_t operator "" _i64(unsigned long long int n) noexcept { return static_cast<int64_t>(n); }
      |                   ~~~~~~~~~~~~^~~~
      |                   operator""_i64
/home/fedora/dev/dsoal/src/dsoal.h:27:32: warning: identifier '_u64' preceded by whitespace in a literal operator declaration is deprecated [-Wdeprecated-literal-operator]
   27 | constexpr uint64_t operator "" _u64(unsigned long long int n) noexcept { return static_cast<uint64_t>(n); }
      |                    ~~~~~~~~~~~~^~~~
      |                    operator""_u64
In file included from /home/fedora/dev/dsoal/src/capture.cpp:12:
/home/fedora/dev/dsoal/src/dsoal.h:26:31: warning: identifier '_i64' preceded by whitespace in a literal operator declaration is deprecated [-Wdeprecated-literal-operator]
   26 | constexpr int64_t operator "" _i64(unsigned long long int n) noexcept { return static_cast<int64_t>(n); }
      |                   ~~~~~~~~~~~~^~~~
      |                   operator""_i64
/home/fedora/dev/dsoal/src/dsoal.h:27:32: warning: identifier '_u64' preceded by whitespace in a literal operator declaration is deprecated [-Wdeprecated-literal-operator]
   27 | constexpr uint64_t operator "" _u64(unsigned long long int n) noexcept { return static_cast<uint64_t>(n); }
      |                    ~~~~~~~~~~~~^~~~
      |                    operator""_u64
In file included from /home/fedora/dev/dsoal/src/primarybuffer.cpp:7:
In file included from /home/fedora/dev/dsoal/src/buffer.h:18:
/home/fedora/dev/dsoal/src/dsoal.h:26:31: warning: identifier '_i64' preceded by whitespace in a literal operator declaration is deprecated [-Wdeprecated-literal-operator]
   26 | constexpr int64_t operator "" _i64(unsigned long long int n) noexcept { return static_cast<int64_t>(n); }
      |                   ~~~~~~~~~~~~^~~~
      |                   operator""_i64
/home/fedora/dev/dsoal/src/dsoal.h:27:32: warning: identifier '_u64' preceded by whitespace in a literal operator declaration is deprecated [-Wdeprecated-literal-operator]
   27 | constexpr uint64_t operator "" _u64(unsigned long long int n) noexcept { return static_cast<uint64_t>(n); }
      |                    ~~~~~~~~~~~~^~~~
      |                    operator""_u64
/home/fedora/dev/dsoal/src/logging.cpp:11:10: fatal error: 'fmt/core.h' file not found
   11 | #include "fmt/core.h"
      |          ^~~~~~~~~~~~
1 error generated.
make[2]: *** [CMakeFiles/dsound.dir/build.make:185: CMakeFiles/dsound.dir/src/logging.cpp.obj] Error 1
In file included from /home/fedora/dev/dsoal/src/propset.cpp:15:
In file included from /home/fedora/dev/dsoal/src/enumerate.h:14:
/home/fedora/dev/dsoal/src/dsoal.h:26:31: warning: identifier '_i64' preceded by whitespace in a literal operator declaration is deprecated [-Wdeprecated-literal-operator]
   26 | constexpr int64_t operator "" _i64(unsigned long long int n) noexcept { return static_cast<int64_t>(n); }
      |                   ~~~~~~~~~~~~^~~~
      |                   operator""_i64
/home/fedora/dev/dsoal/src/dsoal.h:27:32: warning: identifier '_u64' preceded by whitespace in a literal operator declaration is deprecated [-Wdeprecated-literal-operator]
   27 | constexpr uint64_t operator "" _u64(unsigned long long int n) noexcept { return static_cast<uint64_t>(n); }
      |                    ~~~~~~~~~~~~^~~~
      |                    operator""_u64
/home/fedora/dev/dsoal/src/buffer.cpp:391:56: warning: lambda capture 'exts' is not used [-Wunused-lambda-capture]
  391 |     auto const fmtpair = std::invoke([&shared, format, exts]
      |                                                      ~~^~~~
In file included from /home/fedora/dev/dsoal/src/dsoundoal.cpp:18:
In file included from /home/fedora/dev/dsoal/src/buffer.h:18:
/home/fedora/dev/dsoal/src/dsoal.h:26:31: warning: identifier '_i64' preceded by whitespace in a literal operator declaration is deprecated [-Wdeprecated-literal-operator]
   26 | constexpr int64_t operator "" _i64(unsigned long long int n) noexcept { return static_cast<int64_t>(n); }
      |                   ~~~~~~~~~~~~^~~~
      |                   operator""_i64
/home/fedora/dev/dsoal/src/dsoal.h:27:32: warning: identifier '_u64' preceded by whitespace in a literal operator declaration is deprecated [-Wdeprecated-literal-operator]
   27 | constexpr uint64_t operator "" _u64(unsigned long long int n) noexcept { return static_cast<uint64_t>(n); }
      |                    ~~~~~~~~~~~~^~~~
      |                    operator""_u64
2 warnings generated.
[ 93%] Linking CXX static library libfmt.a
2 warnings generated.
[ 93%] Built target fmt
2 warnings generated.
2 warnings generated.
3 warnings generated.
2 warnings generated.
make[1]: *** [CMakeFiles/Makefile2:143: CMakeFiles/dsound.dir/all] Error 2
make: *** [Makefile:156: all] Error 2

Also, windres with my LLVM mingw toolchain is i686-w64-mingw32-windres but not sure how to change it.

[kcat]

The fmtlib in DSOAL is modified to rename the targets. It probably doesn't need to though, since unlike OpenAL Soft, DSOAL isn't expected to be used as a sub-project, so isn't likely to have target name clashes from multiple copies of fmtlib. DSOAL's CMakeLists.txt could also do with a cleanup to more closely follow modern CMake practices.

For windres, that could probably be changed on line 181 in CMakeLists.txt. I might be able to remove that too now though, since https://gitlab.kitware.com/cmake/cmake/-/work_items/20500 says setting CMAKE_RC_COMPILER should work properly now when cross-compiling with MinGW.

[mirh]

DSOAL isn't expected to be used as a sub-project

Ehrm, about that...