Skip to content

Cannot dismiss popper window with popper-toggle from within a transient. #76

Description

@MagicRB

With the following reproducer:

(defvar bootstrap-version)
(let ((bootstrap-file
       (expand-file-name
        "straight/repos/straight.el/bootstrap.el"
        (or (bound-and-true-p straight-base-dir)
            user-emacs-directory)))
      (bootstrap-version 7))
  (unless (file-exists-p bootstrap-file)
    (with-current-buffer
        (url-retrieve-synchronously
         "https://raw.githubusercontent.com/radian-software/straight.el/develop/install.el"
         'silent 'inhibit-cookies)
      (goto-char (point-max))
      (eval-print-last-sexp)))
  (load bootstrap-file nil 'nomessage))
(setq package-enable-at-startup nil)

(straight-use-package 'transient)
(require 'transient)
(straight-use-package 'popper)
(require 'popper)
(popper-mode 1)

(transient-define-prefix magic-quick-popper ()
  "Prefix with popper related commands."
  ["Popper"
   ("c" "cycle popped windows" popper-cycle)
   ("p" "toggle latest popped window" popper-toggle)
   ("t" "toggle window being popped" popper-toggle-type)
   ])

(bind-key "C-c p" #'magic-quick-popper)

calling popper-toggle via the key sequence C-c p p works to bring up the popper but not to dismiss it. However M-x popper-toggle works as expected. This started happening after bumping popper from 570b0820f884a9c0e3d9cb07e7f7f523b39b836f to 66b47699975fd47541c50959af47a48bb4f938cf

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions