Remove newline characters from worker lifecycle log messages and add test for log format

Author: kaatinga

worker.go

@@ -56,8 +56,8 @@ func (w *Worker) Start(ctx context.Context) {
 	}
 
 	go func() {
-		w.logger.Printf(w.name + " started\n")
-		defer w.logger.Printf(w.name + " stopped\n")
+		w.logger.Printf(w.name + " started")
+		defer w.logger.Printf(w.name + " stopped")
 		defer wg.Done()
 		defer ticker.Stop()
 

worker_test.go

@@ -3,6 +3,7 @@ package phudong
 import (
 	"context"
 	"errors"
+	"reflect"
 	"sync"
 	"testing"
 	"time"
@@ -15,6 +16,35 @@ func TestNewWorker(t *testing.T) {
 	}
 }
 
+type lifecycleLogger struct {
+	formats []string
+}
+
+func (l *lifecycleLogger) Printf(format string, args ...any) {
+	l.formats = append(l.formats, format)
+}
+
+func (l *lifecycleLogger) Errorf(format string, args ...any) {}
+
+func TestWorkerLifecycleLogFormats(t *testing.T) {
+	logger := &lifecycleLogger{}
+	worker := NewWorker(
+		WithLogger(logger),
+		WithDuration(time.Hour),
+	)
+
+	ctx, cancel := context.WithCancel(context.Background())
+	cancel()
+
+	worker.Start(ctx)
+	worker.Wait()
+
+	expected := []string{"noName worker started", "noName worker stopped"}
+	if !reflect.DeepEqual(logger.formats, expected) {
+		t.Errorf("Expected lifecycle log formats %q, got %q", expected, logger.formats)
+	}
+}
+
 func TestWorkerWithOptions(t *testing.T) {
 	var executed bool
 	var mu sync.Mutex