From 2aba6c033621d2d419e98326c9fe0c1e9ad7bd2b Mon Sep 17 00:00:00 2001 From: constanze Date: Fri, 17 Jul 2026 16:18:29 +0000 Subject: [PATCH] lint: fix arc-lint breakage on main (suite exclude, skaffold indent, copy.bara dup) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Main's lint broke after #68/#83 merged the adaptive_export_loadtest tree: - .arclint didn't exclude the suite/ nested go module ('aeloadsuite') → golangci-lint typecheck fails on it from the root module (tools/loadgen/ was already excluded). - src/e2e_test/adaptive_export_loadtest/skaffold.yaml: requires: block indented wrong for yamllint (indent-sequences:false; expected 0/4, was 2/6). - tools/private/copybara/copy.bara.sky: malformed duplicate line (md_udtfs/** + shared/manager BUILD.bazel concatenated behind a comment) rode in via #83. Co-Authored-By: Claude Opus 4.8 (1M context) Claude-Session: https://claude.ai/code/session_017k7uYSNUctQvkTAZYJbaB3 --- .arclint | 1 + .../adaptive_export_loadtest/skaffold.yaml | 24 +++++++++---------- tools/private/copybara/copy.bara.sky | 1 - 3 files changed, 13 insertions(+), 13 deletions(-) diff --git a/.arclint b/.arclint index ee012631a12..93cb5c90280 100644 --- a/.arclint +++ b/.arclint @@ -21,6 +21,7 @@ "(^src/operator/client/versioned/)", "(^src/operator/apis/px.dev/v1alpha1/zz_generated.deepcopy.go)", "(^src/e2e_test/adaptive_export_loadtest/tools/loadgen/)", + "(^src/e2e_test/adaptive_export_loadtest/suite/)", "(^src/stirling/bpf_tools/bcc_bpf/system-headers)", "(^src/stirling/mysql/testing/.*\\.json$)", "(^src/stirling/obj_tools/testdata/go/test_go_binary.go)", diff --git a/src/e2e_test/adaptive_export_loadtest/skaffold.yaml b/src/e2e_test/adaptive_export_loadtest/skaffold.yaml index 4b708e71047..5dacb8103d5 100644 --- a/src/e2e_test/adaptive_export_loadtest/skaffold.yaml +++ b/src/e2e_test/adaptive_export_loadtest/skaffold.yaml @@ -22,15 +22,15 @@ kind: Config metadata: name: e2e-nonpixie requires: - - git: - repo: https://github.com/k8sstormcenter/soc - path: skaffold.yaml - ref: main - configs: - - soc-stack - - git: - repo: https://github.com/k8sstormcenter/bob - path: example/java-poc/skaffold.yaml - ref: main - configs: - - java-poc-apps +- git: + repo: https://github.com/k8sstormcenter/soc + path: skaffold.yaml + ref: main + configs: + - soc-stack +- git: + repo: https://github.com/k8sstormcenter/bob + path: example/java-poc/skaffold.yaml + ref: main + configs: + - java-poc-apps diff --git a/tools/private/copybara/copy.bara.sky b/tools/private/copybara/copy.bara.sky index f97304f74ce..9a54dddb6bb 100644 --- a/tools/private/copybara/copy.bara.sky +++ b/tools/private/copybara/copy.bara.sky @@ -107,7 +107,6 @@ ignored_dirs = [ "src/vizier/services/agent/pem/pem_main.cc", "src/vizier/services/agent/pem/pem_manager.cc", "src/vizier/services/agent/pem/pem_manager.h", - "src/vizier/funcs/md_udtfs/**", # Clickhouse UDTF changes "src/vizier/services/agent/shared/manager/BUILD.bazel", # ASAN build changes. Likely to be upstreamed "src/vizier/services/cloud_connector/bridge/**", # should be made generic and upstreamed "src/vizier/services/metadata/metadatapb/BUILD.bazel", "src/vizier/services/metadata/local/**", # clickhouse testing changes, likely can be removed