Skip to content

Consider less intrusive cargo manifest updating #7

Description

@justinrubek

#3 brought in the ability to edit cargo manifest files directly. However, extra fields are written to Cargo.lock and existing fields get reordered (see 12572ae#diff-13ee4b2252c9e516a0547f2891aa2105c3ca71c6d7a1e682c69be97998dfc87e).

I'm not sure how much work it would be to prevent this from happening, but I anticipate that it could be a non-trivial change. In the meantime it should be sufficient to either

  1. Use by_file replacement (just like how was done in 0.5.0)
  2. Accept the modified files. It doesn't break them but just makes them more explicit

I'm not entirely against leaving things as they are but it is something worth considering

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions