Advancements

[jtljac]

I don't like the current advancements system, It creates a copy of the character in order to demonstrate the changes without affecting the main one and never uses it. It's a pain.

I want to change the advancement system to be simpler, and to perform most of it's changes via the Modifier and rules systems

The Plan

• Get rid of any actor updates and convert all the changes into rules/modifiers that are pulled from the items at _prepareEmbeddedItems
• Make items added by advancements have an origin variable that points back to the advancement item and the level it was added This is already done
• Stop the AdvancementManager from creating a clone of the actor
  • Change the steps to store the changes in the manager then apply them on confirm
• Add more advancement types
  • ASI - Pick ability scores to improve + optional feat
  • Item Choice - Like item-grant, but giving the player a choice between items
  • Money - Grants money
  • Skills/Traits - Lets the player pick from a list of skills/traits
  • Spells - Allow the player to pick from a list of spells - Also handling scaling - Multilevel
  • Subclass - Allow picking a subclass