Description
The current Input component in src/components/ui/input.tsx does not use React.forwardRef, which means consumers cannot attach refs to this component.
Proposed Change
Wrap the component with forwardRef and type the ref as HTMLInputElement:
import * as React from "react"
import { forwardRef } from "react"
import { cn } from "@/lib/utils"
const Input = forwardRef<HTMLInputElement, React.ComponentProps<"input">>(
({ className, type, ...props }, ref) => {
return (
<input
type={type}
data-slot="input"
className={cn(
"file:text-foreground placeholder:text-muted-foreground selection:bg-primary selection:text-primary-foreground dark:bg-input/30 border-input flex h-9 w-full min-w-0 rounded-md border bg-transparent px-3 py-1 text-base shadow-xs transition-[color,box-shadow] outline-none file:inline-flex file:h-7 file:border-0 file:bg-transparent file:text-sm file:font-medium disabled:pointer-events-none disabled:cursor-not-allowed disabled:opacity-50 md:text-sm",
"focus-visible:border-ring focus-visible:ring-ring/50 focus-visible:ring-[3px]",
"aria-invalid:ring-destructive/20 dark:aria-invalid:ring-destructive/40 aria-invalid:border-destructive",
className
)}
ref={ref}
{...props}
/>
)
}
)
Input.displayName = "Input"
export { Input }
Benefits
- Allows consumers to attach refs to the Input component
- Follows React best practices for component design
- Improves component reusability and flexibility
Related Discussion
This issue was created from a discussion in PR #1.
Description
The current Input component in
src/components/ui/input.tsxdoes not useReact.forwardRef, which means consumers cannot attach refs to this component.Proposed Change
Wrap the component with
forwardRefand type the ref asHTMLInputElement:Benefits
Related Discussion
This issue was created from a discussion in PR #1.