Skip to content

Consolidate validation logic #357

Description

@mnzaki

Description

Currently in two places: utils/validation and identityWallet.validateJWT. Perhaps it needs a "Validator" class/interface of some sort? or perhaps just keep them as utils?

Note that the validation logic paths are the only ones that needs to be able to resolve non-jolo DIDs and so require a resolver function. Containing that requirement into a new class/interface can be helpful.

Part of #355

TODO

  • decide about class vs utils and refactor accordingly
  • move out validateJWT logic and deprecate its usage
  • what about SoftwareKeyProvider.verifyDigestable ?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    tech debtIssues we need to address to make improve code quality

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions