Skip to content

Cleanup JolocomRegistry creation #356

Description

@mnzaki

Description

In an effort to differentiate between the "jolocom method based registry" and the canonical jolocom registry, the createJolocomRegistry helper should return the canonical jolocom registry (no configurable anything). The logic inside createJolocomRegistry is construction logic that needs to go into the constructor

The registry class itself can get a name that better reflects that it is the "jolocom method based registry" and strictly for jolocom's own canonical registry, because JolocomRegistry is ambiguous

Part of #355

TODO

  • rename registry?
  • move out logic from createJolocomRegistry and make it non-configurable

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    tech debtIssues we need to address to make improve code quality

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions