Goal
Bring every spec in service/notification/registry.py into line with the notification copy style guide.
Context
civil_disorder, civil_disorder_recovery and removed_from_staging override the title, so they arrive without a game name — a player in several games cannot tell which one a civil-disorder push refers to. Capitalisation, tense and actor naming vary across the rest.
Approach
Depends on the style guide landing first. The known changes:
- Restore the game name as the title on
civil_disorder, civil_disorder_recovery and removed_from_staging, moving the event into the body.
- Normalise capitalisation, and settle on present perfect throughout.
- Drop the inline "Respond to it now" from
draw_proposal.
- Reword
nmr_extension_used so it states what happened rather than what the player did not do.
- Replace the three actor-naming strategies —
actor_name(), manager_label(), and raw nation names — with one helper.
- Omit the deadline clause in
game_resumed and game_deadline_extended when there is no scheduled resolution, instead of rendering the literal "N/A".
- Drop the ellipsis from
game_start.
service/notification/tests.py pins per-event content, so those assertions move with the copy.
Goal
Bring every spec in
service/notification/registry.pyinto line with the notification copy style guide.Context
civil_disorder,civil_disorder_recoveryandremoved_from_stagingoverride the title, so they arrive without a game name — a player in several games cannot tell which one a civil-disorder push refers to. Capitalisation, tense and actor naming vary across the rest.Approach
Depends on the style guide landing first. The known changes:
civil_disorder,civil_disorder_recoveryandremoved_from_staging, moving the event into the body.draw_proposal.nmr_extension_usedso it states what happened rather than what the player did not do.actor_name(),manager_label(), and raw nation names — with one helper.game_resumedandgame_deadline_extendedwhen there is no scheduled resolution, instead of rendering the literal"N/A".game_start.service/notification/tests.pypins per-event content, so those assertions move with the copy.