From 8837ac136b235b62002297b537c1b660c7c1867b Mon Sep 17 00:00:00 2001 From: John Carmack Date: Mon, 6 Jul 2026 23:24:11 -0700 Subject: [PATCH] tooling: opinion lint tier on (unwrap/panic/todo/missing_docs) [skip release] The workspace lint floor gains clippy::unwrap_used/panic/todo and missing_docs as warnings (CI's -D warnings enforces them). The only findings were 8 test-module unwraps, allowed per the test idiom: unwrap is the assertion. --- crates/Cargo.toml | 4 ++++ crates/weather-ingest/src/contract.rs | 1 + crates/weather-ingest/src/gfs.rs | 1 + 3 files changed, 6 insertions(+) diff --git a/crates/Cargo.toml b/crates/Cargo.toml index 858b0ed..d8416a7 100644 --- a/crates/Cargo.toml +++ b/crates/Cargo.toml @@ -16,6 +16,10 @@ strip = true # enforced). Members opt in via [lints] workspace = true. [workspace.lints.rust] unsafe_code = "forbid" +missing_docs = "warn" [workspace.lints.clippy] all = { level = "warn", priority = -1 } +unwrap_used = "warn" +panic = "warn" +todo = "warn" diff --git a/crates/weather-ingest/src/contract.rs b/crates/weather-ingest/src/contract.rs index ea4d0ad..1cce693 100644 --- a/crates/weather-ingest/src/contract.rs +++ b/crates/weather-ingest/src/contract.rs @@ -276,6 +276,7 @@ mod export { } #[cfg(test)] +#[allow(clippy::unwrap_used)] // test code: unwrap IS the assertion mod tests { use super::{AlertProps, Severity, Snapshot}; use typed_geojson::{Feature, Point}; diff --git a/crates/weather-ingest/src/gfs.rs b/crates/weather-ingest/src/gfs.rs index 350a734..40af007 100644 --- a/crates/weather-ingest/src/gfs.rs +++ b/crates/weather-ingest/src/gfs.rs @@ -286,6 +286,7 @@ fn civil_from_days(z: i64) -> (i64, u32, u32) { } #[cfg(test)] +#[allow(clippy::unwrap_used)] // test code: unwrap IS the assertion mod tests { use super::*;