Skip to content

rate-limit errors when excessively checking a specific site #122

Description

@kattni

Describe the bug
After updating from 0.2.5 to latest, markdown-checker is now hitting rate limiters on major domains.

To Reproduce
Steps to reproduce the behavior:

  1. Run markdown-checker URL checker on any significant number of GitHub or Wikipedia URLs.

Expected behavior
It should run successfully.

Desktop (please complete the following information):

  • OS: MacOS / GitHub CI
  • Browser: Waterfox (not related)

Additional context
There are two updates that may be causing issues here.

  1. httpx uses http-2, which is faster, but it has different connection symantics, and is quite possibly triggering rate-limiters as a result.
  2. There is a subtle difference between the way head requests are handled between requests and httpx, with regard to allowing redirects. It appears that you are allowing redirects, but it may not be working properly.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions