Check crc of downloaded zip

[mad4hit]

Sometime happens that the zip file is corrupted and the program crash.

Is it possible to add the signature check of the downloaded files? and in case the crc test is not passed try to download again the file?

Thanks

[joelverhagen]

This is a great idea. In general, for a checksum to be performed we would need an authoritative source for the expected checksum value. CRC is one such option but many software distribution platforms (such as Debian .deb packages) use SHA256 due to its desirable properties. Just to make sure I am not misunderstanding you, is there a reading you mentioned CRC specifically? (maybe I am misunderstanding).

Do you know if it's Tor or Privoxy failing to unzip? My gut says probably Privoxy since 3 sources are used:

TorSharp/src/TorSharp/Tools/Privoxy/PrivoxyFetcher.cs

Lines 16 to 18 in 30aeeaa

	private static readonly Uri PrivoxyBaseUrl = new Uri("https://www.privoxy.org/feeds/privoxy-releases.xml");
	private static readonly Uri SourceForgeBaseUrl = new Uri("https://sourceforge.net/projects/ijbswa/rss");
	private static readonly Uri PrivoxyMirrorBaseUrl = new Uri("https://www.silvester.org.uk/privoxy/");

Perhaps I need to enhance the tool fetching to trip another source if the first one returns a bad ZIP.

[mad4hit]

@joelverhagen , sorry when i was writing this issue i was falling asleep (3am in italy);
To clarify: I was intending the .asc file present in each source of Privoxy, and also present in tor page download. The files uses PGP encryption, so checking that will be fine.

And the download problem is often Privoxy, but once it occurred with tor.

Thanks for the fast reply
Alex