mouseenter targets vs focusin targets

[mjau-mjau]

Is there any reason why the mouseenter event is applied to targets option, while focusin event is hardcoded to 'li, or am I missing some vital functionality?

$menu.on('mouseenter.superfish', targets, over)

vs

$menu.on('focusin.superfish', 'li', over)

[joeldbirch]

You know… there may not be a good reason for that! It’s been so long since I’ve been familiar with this code but, at a glance, it does look like a bug. If you could confirm this and submit a pull request I’d be overjoyed to merge a fix. Thanks for the heads-up.

…

On 25 Feb 2019, at 12:31 am, Karl Ward ***@***.***> wrote: Is there any reason why the mouseenter event is applied to targets option, while focusin event is hardcoded to 'li, or am I missing some vital functionality? $menu.on('mouseenter.superfish', targets, over) vs $menu.on('focusin.superfish', 'li', over) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[mjau-mjau]

Hi Joel, thanks for the fast reply! Messing around with some old code here myself, and stumbled upon an issue where focusin was being triggered for excluded items, although I'm not 100% sure it's "wrong" ... In my case, it simply crashes with custom behavior for excluded items that trigger on click (which also triggers focusin).

Initial tests showed nothing wrong in replacing 'li' with targets, but I probably won't make a pull request unless I fully understand the logic and test from various input devices.

Cheers!