elm-review wiped out my elm.json and then gave a bad error message when I ran it again

[MartinSStewart]

I ran elm-review --fix-all and it made some automatic fixes which I accepted. It didn't apply them though because I didn't have elm-format installed. I didn't noticed it at the time but elm-review also deleted the contents of my elm.json file.

I then got this error when I tried running elm-review again (with an empty elm.json file)

Martins-MBP-2:program-test martinstewart$ npx elm-review --fix-all
-- UNEXPECTED ERROR ------------------------------------------------------------

I ran into an unexpected error. Please open an issue at the following link:
  https://github.com/jfmengels/node-elm-review/issues/new

Please include this error message and as much detail as you can provide. Running
with --debug might give additional information. If you can, please provide a
setup that makes it easy to reproduce the error. That will make it much easier
to fix the issue.

Below is the error that was encountered.
--------------------------------------------------------------------------------
SyntaxError: Unexpected end of JSON input
    at JSON.parse (<anonymous>)
    at getProjectFiles (/Users/martinstewart/Desktop/program-test/node_modules/elm-review/lib/elm-files.js:41:24)
    at async Object.initializeApp (/Users/martinstewart/Desktop/program-test/node_modules/elm-review/lib/runner.js:195:5)
    at async /Users/martinstewart/Desktop/program-test/node_modules/elm-review/lib/main.js:102:14
    at async Promise.all (index 0)
    at async runElmReview (/Users/martinstewart/Desktop/program-test/node_modules/elm-review/lib/main.js:100:19)
    at async app (/Users/martinstewart/Desktop/program-test/node_modules/elm-review/lib/main.js:314:5)
    at async main (/Users/martinstewart/Desktop/program-test/node_modules/elm-review/lib/main.js:214:3)

Here it is with --debug

Martins-MBP-2:program-test martinstewart$ npx elm-review --fix-all --debug
Starting review application build
Compiling review application
Finished review application build
Building parser app for elm-syntax v7.3.9
-- UNEXPECTED ERROR ------------------------------------------------------------

I ran into an unexpected error. Please open an issue at the following link:
  https://github.com/jfmengels/node-elm-review/issues/new

Please include this error message and as much detail as you can provide. Running
with --debug might give additional information. If you can, please provide a
setup that makes it easy to reproduce the error. That will make it much easier
to fix the issue.

Below is the error that was encountered.
--------------------------------------------------------------------------------
SyntaxError: Unexpected end of JSON input
    at JSON.parse (<anonymous>)
    at getProjectFiles (/Users/martinstewart/Desktop/program-test/node_modules/elm-review/lib/elm-files.js:41:24)
    at async Object.initializeApp (/Users/martinstewart/Desktop/program-test/node_modules/elm-review/lib/runner.js:195:5)
    at async /Users/martinstewart/Desktop/program-test/node_modules/elm-review/lib/main.js:102:14
    at async Promise.all (index 0)
    at async runElmReview (/Users/martinstewart/Desktop/program-test/node_modules/elm-review/lib/main.js:100:19)
    at async app (/Users/martinstewart/Desktop/program-test/node_modules/elm-review/lib/main.js:314:5)
    at async main (/Users/martinstewart/Desktop/program-test/node_modules/elm-review/lib/main.js:214:3)
SyntaxError: Unexpected end of JSON input
    at JSON.parse (<anonymous>)
    at getProjectFiles (/Users/martinstewart/Desktop/program-test/node_modules/elm-review/lib/elm-files.js:41:24)
    at async Object.initializeApp (/Users/martinstewart/Desktop/program-test/node_modules/elm-review/lib/runner.js:195:5)
    at async /Users/martinstewart/Desktop/program-test/node_modules/elm-review/lib/main.js:102:14
    at async Promise.all (index 0)
    at async runElmReview (/Users/martinstewart/Desktop/program-test/node_modules/elm-review/lib/main.js:100:19)
    at async app (/Users/martinstewart/Desktop/program-test/node_modules/elm-review/lib/main.js:314:5)
    at async main (/Users/martinstewart/Desktop/program-test/node_modules/elm-review/lib/main.js:214:3)

This is on Mac, intel CPU, Node verison v20.10.0

Martins-MBP-2:program-test martinstewart$ npx elm-review --version
2.13.5

[jfmengels]

We can definitely improve the error message when elm.json is not valid JSON 👍

Do you have a way to reproduce the original error that wiped out elm.json? Maybe a branch I could run elm-review on?

[MartinSStewart]

I can reproduce it by:

1. Clone this commit lamdera/program-test@7f0dec2
2. Make sure you don't have elm-format available for elm-review
3. Run npx elm-review --fix-all
4. Accept the fixes
5. Note that it says it was unable to apply the fixes due to elm-format missing and that elm.json is now empty

[MartinSStewart]

One of the changes is removing an unused dependency from elm.json. I'm guessing the bug is caused by elm.json changes getting reverted due to elm-format missing.