[JENKINS-75896] Gerrit Trigger commentAdded Configuration Fails for Specific verdictCategory in Pipeline Projects

<h2><a name="Summary"></a>Summary</h2>

<p>In Jenkins Pipeline projects, the Gerrit Trigger plugin's commentAdded event trigger fails to work when using verdictCategory: 'Code Review', while the same configuration works correctly in Freestyle projects and verdictCategory: 'Verified' works fine in Pipeline projects.</p>
<h2><a name="IssueType"></a>Issue Type</h2>

<p>Bug</p>
<h2><a name="Environment"></a>Environment</h2>
<ul>
	<li>Jenkins Version: 2.510</li>
</ul>


<ul>
	<li>Gerrit Trigger Plugin Version: 2.42.0</li>
</ul>


<ul>
	<li>Gerrit Server Version: 3.11.2</li>
</ul>


<ul>
	<li>Operating System: Linux</li>
</ul>


<h2><a name="Description"></a>Description</h2>
<h3><a name="Issue%C2%A0Summary"></a>Issue Summary</h3>

<p>When configuring Gerrit Trigger's commentAdded event in Jenkins Pipeline projects, we observed inconsistent behavior:</p>
<ol>
	<li>✅ Freestyle Project + verdictCategory: 'Code Review' → Works correctly</li>
</ol>


<ol>
	<li>❌ Pipeline Project + verdictCategory: 'Code Review' → Does not work</li>
</ol>


<ol>
	<li>✅ Pipeline Project + verdictCategory: 'Verified' → Works correctly</li>
</ol>


<ol>
	<li>✅ Pipeline Project + patchsetCreated → Works correctly</li>
</ol>


<h3><a name="StepstoReproduce"></a>Steps to Reproduce</h3>
<h4><a name="Step1%3ACreate%C2%A0PipelineProject"></a>Step 1: Create Pipeline Project</h4>

<p>Configuration:<br/>
 groovy<br/>
 <br/>
pipeline {<br/>
    agent { node </p>

{ label 'manual' }

<p> }<br/>
    <br/>
    triggers </p>

{         gerrit(             serverName: 'mifit',             silentMode: true,             gerritProjects: [[                 branches: [[compareType: 'ANT', pattern: '**']],                 compareType: 'ANT',                 pattern: 'devops/dashboard2'             ]],             triggerOnEvents: [                 commentAdded(verdictCategory: 'Code Review', commentAddedTriggerApprovalValue: '+2')             ]         )     }

<p>    <br/>
    stages {<br/>
        stage('Test') {<br/>
            steps </p>

{                 echo "Pipeline triggered by Code Review"             }

<p>        }<br/>
    }<br/>
}<br/>
 <br/>
<font color="#d24939">Step 2: Create Comparable Freestyle Project</font><br/>
Using identical Gerrit Trigger configuration:</p>
<ul>
	<li>Server: mifit</li>
</ul>


<ul>
	<li>Project: devops/dashboard2</li>
</ul>


<ul>
	<li>Trigger: Comment Added</li>
</ul>


<ul>
	<li>Verdict Category: Code Review</li>
</ul>


<ul>
	<li>Approval Value: +2</li>
</ul>


<h4><a name="Step3%3ATest%C2%A0Triggering"></a>Step 3: Test Triggering</h4>

<p>In Gerrit, perform the following actions on the same patch:</p>
<ol>
	<li>Give Code Review +2</li>
</ol>


<ol>
	<li>Give Verified +1</li>
</ol>


<h3><a name="ExpectedResult"></a>Expected Result</h3>
<ul>
	<li>Both Pipeline and Freestyle projects should be triggered when receiving Code Review +2</li>
</ul>


<ul>
	<li>Pipeline project should be triggered when receiving Verified +1</li>
</ul>


<h3><a name="ActualResult"></a>Actual Result</h3>

<p>Based on Jenkins log observations:</p>
<h4><a name="When%C2%A0givingVerified1%3A"></a>When giving Verified +1:</h4>

<p> <br/>
 <br/>
2025-07-16 15:04:19.065+0000 <span class="error">&#91;id=599070&#93;</span> INFO c.s.h.p.g.t.h.EventListener#schedule: Project TEST_TRIGGER_BY_PIPELINE Build Scheduled: true By event: 927580/1<br/>
2025-07-16 15:04:19.065+0000 <span class="error">&#91;id=599070&#93;</span> INFO c.s.h.p.g.t.h.EventListener#schedule: Project TEST_TRIGGER_BY_CODEREVIEW Build Scheduled: true By event: 927580/1<br/>
 <br/>
 <br/>
✅ Both projects were triggered</p>
<h4><a name="WhengivingCodeReview2%3A"></a>When giving Code Review +2:</h4>

<p> <br/>
2025-07-16 15:05:22.204+0000 <span class="error">&#91;id=598997&#93;</span> INFO c.s.h.p.g.t.h.EventListener#schedule: Project TEST_TRIGGER_BY_CODEREVIEW Build Scheduled: true By event: 927580/1<br/>
 <br/>
❌ Only Freestyle project was triggered, Pipeline project was not triggered</p>
<h3><a name="AdditionalInformation"></a>Additional Information</h3>
<h4><a name="RuledOutPotential%C2%A0Causes%3A"></a>Ruled Out Potential Causes:</h4>
<ol>
	<li>❌ "New Pipeline needs manual run once" - Project was already manually executed</li>
</ol>


<ol>
	<li>❌ Configuration syntax errors - Same syntax works for verdictCategory: 'Verified'</li>
</ol>


<ol>
	<li>❌ Server connection issues - Freestyle project works fine, Verified triggering also works</li>
</ol>


<ol>
	<li>❌ Permission issues - Same user and project in Freestyle configuration works correctly</li>
</ol>


<h4><a name="TestedConfiguration%C2%A0Variants%3A"></a>Tested Configuration Variants:</h4>
<ul>
	<li>verdictCategory: 'Code Review' ❌</li>
</ul>


<ul>
	<li>verdictCategory: 'Huami Code Review' ❌</li>
</ul>


<ul>
	<li>commentAddedTriggerApprovalValue: '+2' / '2' / '+1' ❌</li>
</ul>


<ul>
	<li>Without specifying verdictCategory (catch all comments) ✅</li>
</ul>


<h4><a name="ConfirmedWorking%C2%A0Configurations%3A"></a>Confirmed Working Configurations:</h4>

<p> <br/>
 <br/>
// ✅ Works correctly in Pipeline<br/>
commentAdded(verdictCategory: 'Verified', commentAddedTriggerApprovalValue: '+1')<br/>
 <br/>
// ✅ Works correctly in Freestyle  <br/>
commentAdded(verdictCategory: 'Code Review', commentAddedTriggerApprovalValue: '+2')<br/>
 <br/>
 <br/>
 <br/>
<font color="#d24939">Impact</font><br/>
This issue prevents teams using Pipeline for CI/CD from properly configuring triggers based on Code Review scores, forcing them to either use patchsetCreated (triggers on every commit) or revert to Freestyle projects, impacting adoption of modern Jenkins Pipeline.</p>
<h2><a name="SuggestedFix"></a>Suggested Fix</h2>

<p>Recommend investigating the Gerrit Trigger plugin's handling of commentAdded events in Pipeline projects, specifically examining if there are differences in processing logic for different verdictCategory values, particularly Code Review-related categories.</p>

---
<details><summary><i>Originally reported by <a href="https://issues.jenkins.io/secure/ViewProfile.jspa?name=junxian">junxian</a>, imported from: <a class="original-jira-link" href="https://issues.jenkins.io/browse/JENKINS-75896" target="_blank">Gerrit Trigger commentAdded Configuration Fails for Specific verdictCategory in Pipeline Projects</a></i></summary>
<i><ul>
<li><b>assignee</b>: <img align="left" width="20" src="https://raw.githubusercontent.com/jenkinsci/artifacts-from-jira-issues/refs/heads/main/avatars/rsandell.png" title="rsandell's avatar" /> <a href="https://issues.jenkins.io/secure/ViewProfile.jspa?name=rsandell">rsandell</a>
<li><b>status</b>: Open
<li><b>priority</b>: Blocker
<li><b>component(s)</b>: gerrit-trigger-plugin
<li><b>resolution</b>: Unresolved
<li><b>votes</b>: 0
<li><b>watchers</b>: 1
<li><b>imported</b>: 2025-12-07
</ul></i>
<details><summary>Raw content of original issue</summary>

<pre>
<h2><a name="Summary"></a>Summary</h2>

<p>In Jenkins Pipeline projects, the Gerrit Trigger plugin's commentAdded event trigger fails to work when using verdictCategory: 'Code Review', while the same configuration works correctly in Freestyle projects and verdictCategory: 'Verified' works fine in Pipeline projects.</p>
<h2><a name="IssueType"></a>Issue Type</h2>

<p>Bug</p>
<h2><a name="Environment"></a>Environment</h2>
<ul>
	<li>Jenkins Version: 2.510</li>
</ul>


<ul>
	<li>Gerrit Trigger Plugin Version: 2.42.0</li>
</ul>


<ul>
	<li>Gerrit Server Version: 3.11.2</li>
</ul>


<ul>
	<li>Operating System: Linux</li>
</ul>


<h2><a name="Description"></a>Description</h2>
<h3><a name="Issue%C2%A0Summary"></a>Issue Summary</h3>

<p>When configuring Gerrit Trigger's commentAdded event in Jenkins Pipeline projects, we observed inconsistent behavior:</p>
<ol>
	<li>✅ Freestyle Project + verdictCategory: 'Code Review' → Works correctly</li>
</ol>


<ol>
	<li>❌ Pipeline Project + verdictCategory: 'Code Review' → Does not work</li>
</ol>


<ol>
	<li>✅ Pipeline Project + verdictCategory: 'Verified' → Works correctly</li>
</ol>


<ol>
	<li>✅ Pipeline Project + patchsetCreated → Works correctly</li>
</ol>


<h3><a name="StepstoReproduce"></a>Steps to Reproduce</h3>
<h4><a name="Step1%3ACreate%C2%A0PipelineProject"></a>Step 1: Create Pipeline Project</h4>

<p>Configuration:
 groovy
 
pipeline {
    agent { node </p>

{ label 'manual' }

<p> }
    
    triggers </p>

{         gerrit(             serverName: 'mifit',             silentMode: true,             gerritProjects: [[                 branches: [[compareType: 'ANT', pattern: '**']],                 compareType: 'ANT',                 pattern: 'devops/dashboard2'             ]],             triggerOnEvents: [                 commentAdded(verdictCategory: 'Code Review', commentAddedTriggerApprovalValue: '+2')             ]         )     }

<p>    
    stages {
        stage('Test') {
            steps </p>

{                 echo "Pipeline triggered by Code Review"             }

<p>        }
    }
}
 
<font color="#d24939">Step 2: Create Comparable Freestyle Project</font>
Using identical Gerrit Trigger configuration:</p>
<ul>
	<li>Server: mifit</li>
</ul>


<ul>
	<li>Project: devops/dashboard2</li>
</ul>


<ul>
	<li>Trigger: Comment Added</li>
</ul>


<ul>
	<li>Verdict Category: Code Review</li>
</ul>


<ul>
	<li>Approval Value: +2</li>
</ul>


<h4><a name="Step3%3ATest%C2%A0Triggering"></a>Step 3: Test Triggering</h4>

<p>In Gerrit, perform the following actions on the same patch:</p>
<ol>
	<li>Give Code Review +2</li>
</ol>


<ol>
	<li>Give Verified +1</li>
</ol>


<h3><a name="ExpectedResult"></a>Expected Result</h3>
<ul>
	<li>Both Pipeline and Freestyle projects should be triggered when receiving Code Review +2</li>
</ul>


<ul>
	<li>Pipeline project should be triggered when receiving Verified +1</li>
</ul>


<h3><a name="ActualResult"></a>Actual Result</h3>

<p>Based on Jenkins log observations:</p>
<h4><a name="When%C2%A0givingVerified1%3A"></a>When giving Verified +1:</h4>

<p> 
 
2025-07-16 15:04:19.065+0000 <span class="error">&#91;id=599070&#93;</span> INFO c.s.h.p.g.t.h.EventListener#schedule: Project TEST_TRIGGER_BY_PIPELINE Build Scheduled: true By event: 927580/1
2025-07-16 15:04:19.065+0000 <span class="error">&#91;id=599070&#93;</span> INFO c.s.h.p.g.t.h.EventListener#schedule: Project TEST_TRIGGER_BY_CODEREVIEW Build Scheduled: true By event: 927580/1
 
 
✅ Both projects were triggered</p>
<h4><a name="WhengivingCodeReview2%3A"></a>When giving Code Review +2:</h4>

<p> 
2025-07-16 15:05:22.204+0000 <span class="error">&#91;id=598997&#93;</span> INFO c.s.h.p.g.t.h.EventListener#schedule: Project TEST_TRIGGER_BY_CODEREVIEW Build Scheduled: true By event: 927580/1
 
❌ Only Freestyle project was triggered, Pipeline project was not triggered</p>
<h3><a name="AdditionalInformation"></a>Additional Information</h3>
<h4><a name="RuledOutPotential%C2%A0Causes%3A"></a>Ruled Out Potential Causes:</h4>
<ol>
	<li>❌ "New Pipeline needs manual run once" - Project was already manually executed</li>
</ol>


<ol>
	<li>❌ Configuration syntax errors - Same syntax works for verdictCategory: 'Verified'</li>
</ol>


<ol>
	<li>❌ Server connection issues - Freestyle project works fine, Verified triggering also works</li>
</ol>


<ol>
	<li>❌ Permission issues - Same user and project in Freestyle configuration works correctly</li>
</ol>


<h4><a name="TestedConfiguration%C2%A0Variants%3A"></a>Tested Configuration Variants:</h4>
<ul>
	<li>verdictCategory: 'Code Review' ❌</li>
</ul>


<ul>
	<li>verdictCategory: 'Huami Code Review' ❌</li>
</ul>


<ul>
	<li>commentAddedTriggerApprovalValue: '+2' / '2' / '+1' ❌</li>
</ul>


<ul>
	<li>Without specifying verdictCategory (catch all comments) ✅</li>
</ul>


<h4><a name="ConfirmedWorking%C2%A0Configurations%3A"></a>Confirmed Working Configurations:</h4>

<p> 
 
// ✅ Works correctly in Pipeline
commentAdded(verdictCategory: 'Verified', commentAddedTriggerApprovalValue: '+1')
 
// ✅ Works correctly in Freestyle  
commentAdded(verdictCategory: 'Code Review', commentAddedTriggerApprovalValue: '+2')
 
 
 
<font color="#d24939">Impact</font>
This issue prevents teams using Pipeline for CI/CD from properly configuring triggers based on Code Review scores, forcing them to either use patchsetCreated (triggers on every commit) or revert to Freestyle projects, impacting adoption of modern Jenkins Pipeline.</p>
<h2><a name="SuggestedFix"></a>Suggested Fix</h2>

<p>Recommend investigating the Gerrit Trigger plugin's handling of commentAdded events in Pipeline projects, specifically examining if there are differences in processing logic for different verdictCategory values, particularly Code Review-related categories.</p></pre>
</details>
</details>

Uh oh!

[JENKINS-75896] Gerrit Trigger commentAdded Configuration Fails for Specific verdictCategory in Pipeline Projects #999

Description

Summary

Issue Type

Environment

Description

Issue Summary

Steps to Reproduce

Step 1: Create Pipeline Project

Step 3: Test Triggering

Expected Result

Actual Result

When giving Verified +1:

When giving Code Review +2:

Additional Information

Ruled Out Potential Causes:

Tested Configuration Variants:

Confirmed Working Configurations:

Suggested Fix

Summary

Issue Type

Environment

Description

Issue Summary

Steps to Reproduce

Step 1: Create Pipeline Project

Step 3: Test Triggering

Expected Result

Actual Result

When giving Verified +1:

When giving Code Review +2:

Additional Information

Ruled Out Potential Causes:

Tested Configuration Variants:

Confirmed Working Configurations:

Suggested Fix

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions