[JENKINS-75943] Credentials IDs can be created with illegal characters

[jenkins-infra-bot]

While the UI warns us that the Credentials ID contains illegal characters, it's still possible to create it with those characters.

I suppose the validation is missing Jenkins.checkGoodName or similar.

---

Originally reported by kevingrdj, imported from: Credentials IDs can be created with illegal characters

• status: Open
• priority: Minor
• component(s): credentials-plugin
• resolution: Unresolved
• votes: 0
• watchers: 1
• imported: 2025-12-08

Raw content of original issue

While the UI warns us that the Credentials ID contains illegal characters, it's still possible to create it with those characters.



I suppose the validation is missing Jenkins.checkGoodName or similar.

1 attachment

• image-2025-07-31-11-15-59-070.png

  

[Aadigarg111]

I’d like to contribute to this issue.

Proposed implementation:

1. Add validation for credential IDs against an allowed-character rule.
2. Enforce validation consistently in both UI form handling and backend save path.
3. Add tests for valid/invalid IDs and migration-safe behavior for existing entries.

If this plan aligns with expectations, I can start with a focused PR.

[timja]

Just adding Jenkins.checkGoodName should be enough. Tests would be good too.

I don't think you'll be able to migrate them safely, so pre-stored ones should probably be allowed.