The modifier does not have cleanup logic. In most cases that's okay. The element is destroyed anyways when modifier is removed. But it likely breaks when the modifier is applied conditionally.
Adding cleanup logic in a destructor may have negative impact on performance. See emberjs/rfcs#1007 (comment) on that topic. We should investigate the trade-off before shipping.
Conditionally applying this modifier does not seem to be a common case. At least no one reported a bug regarding missing cleanup. We should make sure to not harm everyone for a theoretical bug affecting no actual use case.
The modifier does not have cleanup logic. In most cases that's okay. The element is destroyed anyways when modifier is removed. But it likely breaks when the modifier is applied conditionally.
Adding cleanup logic in a destructor may have negative impact on performance. See emberjs/rfcs#1007 (comment) on that topic. We should investigate the trade-off before shipping.
Conditionally applying this modifier does not seem to be a common case. At least no one reported a bug regarding missing cleanup. We should make sure to not harm everyone for a theoretical bug affecting no actual use case.