Skip to content

Commit eafb889

Browse files
authored
Merge pull request #58 from jcode-works/develop
release: promote landing lighthouse accessibility fix
2 parents d328588 + d981222 commit eafb889

6 files changed

Lines changed: 36 additions & 32 deletions

File tree

packages/ragmir-landing/src/components/hero-demo.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -282,7 +282,7 @@ export function HeroDemo({ translations }: HeroDemoProps): React.JSX.Element {
282282
style={{ fontSize: "0.58rem" }}
283283
type="button"
284284
>
285-
<span className="text-muted-foreground/70" style={{ fontSize: "0.46rem" }}>
285+
<span className="text-foreground/70" style={{ fontSize: "0.46rem" }}>
286286
{String(index + 1).padStart(2, "0")}
287287
</span>
288288
<Icon aria-hidden="true" className="size-2.5 shrink-0" />

packages/ragmir-landing/src/components/landing-navbar.tsx

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -30,14 +30,11 @@ const GITHUB_URL = "https://github.com/jcode-works/jcode-ragmir"
3030

3131
export function RagmirLogo(): React.JSX.Element {
3232
return (
33-
<span className="logo-stack font-black text-2xl text-foreground leading-none tracking-tight md:text-3xl">
34-
<span className="logo-index-1">Ragmir</span>
35-
<span aria-hidden="true" className="logo-index-2">
36-
Ragmir
37-
</span>
38-
<span aria-hidden="true" className="logo-index-3">
39-
Ragmir
40-
</span>
33+
<span
34+
className="logo-stack font-black text-2xl text-foreground leading-none tracking-tight md:text-3xl"
35+
data-logo-text="Ragmir"
36+
>
37+
<span className="logo-index-1 logo-text">Ragmir</span>
4138
</span>
4239
)
4340
}

packages/ragmir-landing/src/components/ragmir-logo.astro

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,9 @@
22
33
---
44

5-
<span class="logo-stack font-black text-2xl text-foreground leading-none tracking-tight md:text-3xl">
6-
<span class="logo-index-1">Ragmir</span>
7-
<span aria-hidden="true" class="logo-index-2">Ragmir</span>
8-
<span aria-hidden="true" class="logo-index-3">Ragmir</span>
5+
<span
6+
class="logo-stack font-black text-2xl text-foreground leading-none tracking-tight md:text-3xl"
7+
data-logo-text="Ragmir"
8+
>
9+
<span class="logo-index-1 logo-text">Ragmir</span>
910
</span>

packages/ragmir-landing/src/pages/404.astro

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,9 @@ const homeUrl = getLocalizedUrl("/", defaultLang)
2525
<a aria-label="Ragmir" class="flex items-center transition hover:opacity-80" href={homeUrl}>
2626
<span
2727
class="logo-stack font-black text-2xl text-foreground leading-none tracking-tight md:text-3xl"
28+
data-logo-text="Ragmir"
2829
>
29-
<span class="logo-index-1">Ragmir</span>
30-
<span aria-hidden="true" class="logo-index-2">Ragmir</span>
31-
<span aria-hidden="true" class="logo-index-3">Ragmir</span>
30+
<span class="logo-index-1 logo-text">Ragmir</span>
3231
</span>
3332
</a>
3433

packages/ragmir-landing/src/pages/500.astro

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,9 @@ const homeUrl = getLocalizedUrl("/", defaultLang)
2525
<a aria-label="Ragmir" class="flex items-center transition hover:opacity-80" href={homeUrl}>
2626
<span
2727
class="logo-stack font-black text-2xl text-foreground leading-none tracking-tight md:text-3xl"
28+
data-logo-text="Ragmir"
2829
>
29-
<span class="logo-index-1">Ragmir</span>
30-
<span aria-hidden="true" class="logo-index-2">Ragmir</span>
31-
<span aria-hidden="true" class="logo-index-3">Ragmir</span>
30+
<span class="logo-index-1 logo-text">Ragmir</span>
3231
</span>
3332
</a>
3433

packages/ragmir-landing/src/styles/global.css

Lines changed: 21 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,9 @@ textarea {
166166
--logo-glitch-b: #22d3ee;
167167
}
168168

169-
.logo-stack span {
169+
.logo-stack::before,
170+
.logo-stack::after,
171+
.logo-stack .logo-text {
170172
grid-row-start: 1;
171173
grid-column-start: 1;
172174
--stack-height: calc(100% / var(--stacks) - 1px);
@@ -177,28 +179,34 @@ textarea {
177179
animation: logo-glitch ease infinite 2s alternate-reverse;
178180
}
179181

180-
.logo-stack span:nth-child(odd) {
181-
--glitch-translate: 8px;
182+
.logo-stack::before,
183+
.logo-stack::after {
184+
content: attr(data-logo-text);
185+
pointer-events: none;
182186
}
183187

184-
.logo-stack span:nth-child(even) {
188+
.logo-stack::before {
189+
--index: 1;
185190
--glitch-translate: -8px;
186191
}
187192

188-
.logo-index-1 {
189-
--index: 0;
190-
}
191-
192-
.logo-index-2 {
193-
--index: 1;
193+
.logo-stack::after {
194+
--index: 2;
195+
--glitch-translate: 8px;
194196
}
195197

196-
.logo-index-3 {
197-
--index: 2;
198+
.logo-index-1 {
199+
--index: 0;
200+
--glitch-translate: 8px;
198201
}
199202

200203
@media (prefers-reduced-motion: reduce) {
201-
.logo-stack span {
204+
.logo-stack::before,
205+
.logo-stack::after {
206+
content: none;
207+
}
208+
209+
.logo-stack .logo-text {
202210
animation: none;
203211
clip-path: none;
204212
}

0 commit comments

Comments
 (0)