|
| 1 | +package command |
| 2 | + |
| 3 | +import ( |
| 4 | + "context" |
| 5 | + "errors" |
| 6 | + "testing" |
| 7 | + |
| 8 | + "github.com/jbeshir/alignment-research-feed/internal/datasources/mocks" |
| 9 | + "github.com/jbeshir/alignment-research-feed/internal/domain" |
| 10 | + "github.com/stretchr/testify/assert" |
| 11 | + "github.com/stretchr/testify/mock" |
| 12 | + "github.com/stretchr/testify/require" |
| 13 | +) |
| 14 | + |
| 15 | +func TestDivideVector(t *testing.T) { |
| 16 | + cases := []struct { |
| 17 | + name string |
| 18 | + vector []float32 |
| 19 | + divisor float32 |
| 20 | + expected []float32 |
| 21 | + }{ |
| 22 | + { |
| 23 | + name: "simple_division", |
| 24 | + vector: []float32{2.0, 4.0, 6.0}, |
| 25 | + divisor: 2.0, |
| 26 | + expected: []float32{1.0, 2.0, 3.0}, |
| 27 | + }, |
| 28 | + { |
| 29 | + name: "divide_by_one", |
| 30 | + vector: []float32{1.0, 2.0, 3.0}, |
| 31 | + divisor: 1.0, |
| 32 | + expected: []float32{1.0, 2.0, 3.0}, |
| 33 | + }, |
| 34 | + { |
| 35 | + name: "empty_vector", |
| 36 | + vector: []float32{}, |
| 37 | + divisor: 2.0, |
| 38 | + expected: []float32{}, |
| 39 | + }, |
| 40 | + { |
| 41 | + name: "fractional_result", |
| 42 | + vector: []float32{1.0, 2.0, 3.0}, |
| 43 | + divisor: 2.0, |
| 44 | + expected: []float32{0.5, 1.0, 1.5}, |
| 45 | + }, |
| 46 | + } |
| 47 | + |
| 48 | + for _, tc := range cases { |
| 49 | + t.Run(tc.name, func(t *testing.T) { |
| 50 | + result := divideVector(tc.vector, tc.divisor) |
| 51 | + assert.Equal(t, tc.expected, result) |
| 52 | + }) |
| 53 | + } |
| 54 | +} |
| 55 | + |
| 56 | +func TestRecommendArticles_Execute(t *testing.T) { |
| 57 | + cases := []struct { |
| 58 | + name string |
| 59 | + vectorSum []float32 |
| 60 | + vectorCount int |
| 61 | + similar []domain.SimilarArticle |
| 62 | + articles []domain.Article |
| 63 | + expected []domain.Article |
| 64 | + wantErr bool |
| 65 | + errContains string |
| 66 | + }{ |
| 67 | + { |
| 68 | + name: "no_vector_returns_nil", |
| 69 | + vectorSum: nil, |
| 70 | + vectorCount: 0, |
| 71 | + expected: nil, |
| 72 | + }, |
| 73 | + { |
| 74 | + name: "zero_count_returns_nil", |
| 75 | + vectorSum: []float32{1.0, 2.0}, |
| 76 | + vectorCount: 0, |
| 77 | + expected: nil, |
| 78 | + }, |
| 79 | + { |
| 80 | + name: "successful_recommendation", |
| 81 | + vectorSum: []float32{2.0, 4.0, 6.0}, |
| 82 | + vectorCount: 2, |
| 83 | + similar: []domain.SimilarArticle{ |
| 84 | + {HashID: "rec1", Score: 0.9}, |
| 85 | + {HashID: "rec2", Score: 0.8}, |
| 86 | + }, |
| 87 | + articles: []domain.Article{ |
| 88 | + {HashID: "rec1", Title: "Recommended 1"}, |
| 89 | + {HashID: "rec2", Title: "Recommended 2"}, |
| 90 | + }, |
| 91 | + expected: []domain.Article{ |
| 92 | + {HashID: "rec1", Title: "Recommended 1"}, |
| 93 | + {HashID: "rec2", Title: "Recommended 2"}, |
| 94 | + }, |
| 95 | + }, |
| 96 | + { |
| 97 | + name: "no_similar_articles", |
| 98 | + vectorSum: []float32{1.0, 2.0}, |
| 99 | + vectorCount: 1, |
| 100 | + similar: []domain.SimilarArticle{}, |
| 101 | + expected: nil, |
| 102 | + }, |
| 103 | + } |
| 104 | + |
| 105 | + for _, tc := range cases { |
| 106 | + t.Run(tc.name, func(t *testing.T) { |
| 107 | + vectorSimilarity := mocks.NewMockSimilarArticlesByVectorLister(t) |
| 108 | + articleFetcher := mocks.NewMockArticleFetcher(t) |
| 109 | + userVectorGetter := mocks.NewMockUserVectorGetter(t) |
| 110 | + |
| 111 | + userVectorGetter.EXPECT(). |
| 112 | + GetUserVector(mock.Anything, "user1"). |
| 113 | + Return(tc.vectorSum, tc.vectorCount, nil) |
| 114 | + |
| 115 | + // Only expect similarity and fetch calls when we have a valid vector |
| 116 | + if tc.vectorSum != nil && tc.vectorCount > 0 { |
| 117 | + vectorSimilarity.EXPECT(). |
| 118 | + ListSimilarArticlesByVector(mock.Anything, mock.Anything, mock.Anything, 10). |
| 119 | + Return(tc.similar, nil) |
| 120 | + |
| 121 | + if len(tc.similar) > 0 { |
| 122 | + articleFetcher.EXPECT(). |
| 123 | + FetchArticlesByID(mock.Anything, mock.Anything). |
| 124 | + Return(tc.articles, nil) |
| 125 | + } |
| 126 | + } |
| 127 | + |
| 128 | + cmd := &RecommendArticles{ |
| 129 | + VectorSimilarity: vectorSimilarity, |
| 130 | + ArticleFetcher: articleFetcher, |
| 131 | + UserVectorGetter: userVectorGetter, |
| 132 | + } |
| 133 | + |
| 134 | + result, err := cmd.Execute(context.Background(), "user1", 10) |
| 135 | + |
| 136 | + if tc.wantErr { |
| 137 | + require.Error(t, err) |
| 138 | + assert.Contains(t, err.Error(), tc.errContains) |
| 139 | + } else { |
| 140 | + require.NoError(t, err) |
| 141 | + assert.Equal(t, tc.expected, result) |
| 142 | + } |
| 143 | + }) |
| 144 | + } |
| 145 | +} |
| 146 | + |
| 147 | +func TestRecommendArticles_Execute_GetUserVectorError(t *testing.T) { |
| 148 | + userVectorGetter := mocks.NewMockUserVectorGetter(t) |
| 149 | + userVectorGetter.EXPECT(). |
| 150 | + GetUserVector(mock.Anything, "user1"). |
| 151 | + Return(nil, 0, errors.New("db error")) |
| 152 | + |
| 153 | + cmd := &RecommendArticles{ |
| 154 | + UserVectorGetter: userVectorGetter, |
| 155 | + } |
| 156 | + |
| 157 | + _, err := cmd.Execute(context.Background(), "user1", 10) |
| 158 | + require.Error(t, err) |
| 159 | + assert.Contains(t, err.Error(), "getting user vector") |
| 160 | +} |
0 commit comments