Different settings for different URL's

[aboueleyes]

Would it be possible to have different configs for different auth methods?
for example, for a web login I would like to enable IP blocking
for mobile I don't and so

What do you think? If you are OK with it I would be happy to implement it.

[kencochrane]

Currently, it isn't possible.

How would you tell the difference between web and mobile logins? Do you mean mobile browser or mobile via a native mobile app?

[aboueleyes]

Currently, it isn't possible.

How would you tell the difference between web and mobile logins? Do you mean mobile browser or mobile via a native mobile app?

Mainly different endpoints

[kencochrane]

I see. So, depending on the endpoint, they would have a different configuration. How do you propose that we make the settings configurable based on the endpoint?

[aboueleyes]

@kencochrane

I think it might be something like this

DEFNDER_CONFIG = {
	"default": {
	    "DEFENDER_DISABLE_IP": env.bool("DJANGO_DEFEBDER_DISABLE_IP", True),
	},
    "special_endpoint": {
	    "DEFENDER_DISABLE_IP": env.bool("DJANGO_SPECIAL_ENDPOINT_DEFEBDER_DISABLE_IP", True),
	},
}

default is the old to be backward compatible/global config
and we can add others as stated, and we can add them as prefixes in cache keys

in code, we would do,

settings.DEFENDER_CONFIG.get('speical_config_name', settings.DEFENDER_CONIG['default'])

the speical_config_name would be an optioanl parameter that is used in utils
Added to models maybe?

[kencochrane]

Ok, that seems like a big change because we would have to move all settings from the top level to a new DEFENDER_CONFIG setting and support both going forward, and deprecate the old way.

Before we do something this dramatic, is this a feature other people think is useful for them?

[aboueleyes]

@kencochrane I don't know, so let's keep the issue open if anyone thought it's useful, he would react to the messages : )