Bug: View function of subsections in edit mode throws errors

[stdoma]

I have activated the subsections option in my dev system.
I can create, delete, move and fill them as normal.
In edit mode, the “more” menu has a “view” item. When I call up this function, I get an error:

_Exception - core_courseformat\output\local\content\sectionnavigation::_construct(): Argument #2 ($sectionno) must be of type int, null given, called in [dirroot]/course/format/multitopic/classes/output/courseformat/content/sectionnavigation.php on line 58

Without the relevant editing rights, the function cannot be called as a participant, so the error is not quite so critical.
I'm not sure what the function is needed for, or could the item be removed from the menu?

System 4.5+ (Build: 20241115)
Plugin v4.5.0 (2024102101)

[james-cnz]

Hi @stdoma,
Thanks for reporting this. I guess you're using the Classic theme, or something based on it, because that's where I see an error? I see a different error message, though. I guess it's just different versions of PHP reporting it differently, but are you able to check this branch, and see if it fixes the error for you?
https://github.com/james-cnz/moodle-format_multitopic/tree/moodle_45_fix_subsection_view
(I don't think the view function is really needed, but I'd have to override the subsection menu to remove it, so it would mean more code for me to maintain.)
Also, be aware there's an issue in Moodle generally with duplicating sections containing multiple subsections, so you may not want to use subsections yet anyway:
https://tracker.moodle.org/browse/MDL-83499

[stdoma]

Hi @james-cnz!
Thank you for the quick reply.
I am using Boost-Union (https://moodle.org/plugins/theme_boost_union) which is based on the normal Boost theme.
I have installed PHP 8.2.24 on my dev server.

I have quite a few meetings these days.
I'll take a look at the branch when I have a few minutes.

[stdoma]

Hi @james-cnz!
I have installed the fix branch in my dev systems.
Now everything works normally, without error messages.
Thanks for the quick fix & the upcoming release work.

[james-cnz]

Hi @stdoma,
OK, thanks. I'll see if I can get it released on Monday.