Skip to content

Commit 633d7ed

Browse files
Let Windows gate like everywhere else, and say what the platforms are
Windows went green in three commits, so continue-on-error is gone and it blocks like the others. The README said macOS first and Linux works. Both true, both incomplete now: the install matrix runs on ubuntu, macos and windows every push, and Linux also installs for real and fires the hooks. Windows means Git Bash or WSL. Native PowerShell is not a target and never will be — everything here is a shell script. What is actually macOS-only is smaller than the old wording implied, and neither half is the installer: Conductor is a Mac app, and the claude wrapper is zsh so bash users get the environment without it. The launchd sentence is gone for good — nothing here schedules anything on any platform.
1 parent 57bb4a7 commit 633d7ed

2 files changed

Lines changed: 16 additions & 8 deletions

File tree

.github/workflows/verify.yml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -151,12 +151,11 @@ jobs:
151151
# Windows user running these scripts actually has. Native PowerShell is not a target and the
152152
# README says so; this proves the Git Bash and WSL-shaped path, which is the one people use.
153153
#
154-
# continue-on-error until the platform is green: the job exists to report the truth about
155-
# Windows on every push rather than to gate merges on a platform that was never supported.
156-
# Flip it off once it passes.
154+
# It gates like every other platform. It started as continue-on-error because Windows had
155+
# never been supported and the job existed to report the truth rather than block merges; it
156+
# went green in three commits, so the crutch is gone.
157157
install-windows:
158158
runs-on: windows-latest
159-
continue-on-error: true
160159
defaults:
161160
run:
162161
shell: bash

README.md

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -325,10 +325,19 @@ commits and the full diff of every script the gate executes, and asks before mer
325325
re-recording trust hashes; without a terminal it refuses instead of assuming. The `--yes`
326326
flag exists for automation, and anything automated enough to use it is back to trust-on-pull.
327327

328-
**macOS first.** CI installs and exercises the hooks on Linux every push, so Linux works and
329-
stays working. But Conductor is macOS only, and `setup-machine.sh` reaches for Homebrew first
330-
and falls back to apt, dnf or apk. Nothing here installs a scheduled job on either platform:
331-
`install.sh` writes no launchd plist and no systemd unit, so scheduling is yours to arrange.
328+
**macOS, Linux and Windows all run in CI on every push.** The install matrix runs on
329+
`ubuntu-latest`, `macos-latest` and `windows-latest`, and Linux additionally installs for real
330+
and fires the hooks. Windows means Git Bash or WSL, which is what `shell: bash` selects on a
331+
Windows runner and what a Windows user of these scripts actually has. Native PowerShell is not
332+
a target: everything here is a shell script and none of it is being ported.
333+
334+
Two things are still macOS-only, and neither is the installer. Conductor is a Mac app, so the
335+
`.conductor` lanes only mean something there. The `claude` shell wrapper is written in zsh and
336+
bash cannot source it, so a bash user gets the environment without the wrapper and the
337+
installer says so as it runs.
338+
339+
Nothing here installs a scheduled job on any platform: `install.sh` writes no launchd plist, no
340+
systemd unit and no scheduled task. Scheduling is yours to arrange.
332341

333342
**The counts in this README are enforced, the prose is not.** `.claude/verify.sh` check 12
334343
reads every number back and fails on a mismatch. Nothing checks whether a sentence is still

0 commit comments

Comments
 (0)