Skip to content

DI the \Bugsnag\Client in the ExceptionCatcher class? #17

Description

@Stoux

I was wondering why the Bugsnag client isn't DI'd but created on the spot: https://github.com/interjar/bugsnag-magento2/blob/master/Plugin/ExceptionCatcher.php#L51-L54
Upside of it being DI'd in the constructor is that anyone can extend the Client? Are there any downsides to it?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions