Skip to content
This repository was archived by the owner on Oct 25, 2024. It is now read-only.
This repository was archived by the owner on Oct 25, 2024. It is now read-only.

evaluation Parameter Parsing problem #1676

Description

@1826133674

"In the latest version of the code, you changed the type of the parameter 'args.tasks' to a string. There is an issue with the validation and handling of this parameter in the intel_extension_for_transformers/transformers/llm/evaluation/lm_eval/accuracy.py file.
'''
elif args.tasks == "list":
eval_logger.info(
"Available Tasks:\n - {}".format("\n - ".join(task_manager.all_tasks))
)
sys.exit()
'''

I think it should be modified as follows:

'''
elif isinstance(args.tasks, list):
eval_logger.info(
"Available Tasks:\n - {}".format("\n - ".join(task_manager.all_tasks))
)
sys.exit()
'''

I believe you should also output a corresponding warning here, informing users who have passed 'args.tasks' as a list, what type of parameter they should input to successfully perform the test.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions