RT-ION-Plan file editor does not warn on missing required ApprovalStatus field

[ferdymercury]

Bug description

When loading in the file editor an rtplan.dcm with no field ApprovalStatus, the viewer does not warn about the missing required field.

Also: it does not match on a missing required ReferencedBeamNumber field. (BeamNumber was being used instead).

Also: PatientSetupNumber was inside, but it is not a valid field of BeamSequence, should have warned.

Also: BeamSequence is not a valid field of FractionGroupSequence, it should have been instead ReferencedBeamSequence (should have warned)

Steps for reproduction

Load rtplan.dcm.zip into the file editor

Expected behavior

It warns in red.

[johndgiese]

Hey @ferdymercury ! Thank you for reporting this issue. Just to be up-front, our team is very busy at the moment and is unlikely to have time to look into this issue in the short term. Thank you for the bug report!

[MichaelLeeHobbs]

Response to #121 — RT-ION-Plan file editor does not warn on missing required fields

Two classes of defect here, worth recording separately.

Approval Status (300E,0002) is Type 1C, and the published JSON carries no attribute-level conditions — only module-level ones (315 of 3258 rows in ciod_to_modules.json). Same blocker as #111.

The other three are not conditional at all: PatientSetupNumber inside Beam Sequence where it isn't defined; BeamSequence inside Fraction Group Sequence (should be Referenced Beam Sequence); ReferencedBeamNumber missing with BeamNumber used instead. Those are plain structural violations, detectable from the path field already published in module_to_attributes.json — cheap to implement if the feature were being kept.

Valid, but recommend closing with the File Editor beta — see #96.

(Drive-by triage, not a maintainer.)