Add integration tests for geo service; migrate api.py to lifespan handler

- tests/test_geo.py: 8 tests covering ingest, idempotency, GeoJSON shape,
  point count, 3-D coordinates, 404 on unknown flight
- src/geo/api.py: replace deprecated on_event("shutdown") with lifespan
  context manager (FastAPI docs recommendation)
- pyproject.toml: add httpx>=0.27 to [geo] extra (required by TestClient)

Author: ijancso

pyproject.toml

@@ -26,6 +26,7 @@ geo = [
     "uvicorn[standard]>=0.29",
     "asyncpg>=0.29",
     "psycopg[binary]>=3.1",
+    "httpx>=0.27",
 ]
 
 [build-system]

src/geo/api.py

@@ -1,15 +1,24 @@
 import json
 import os
+from contextlib import asynccontextmanager
 
 import asyncpg
 from fastapi import FastAPI, HTTPException
 from fastapi.responses import JSONResponse
 
-app = FastAPI(title="flightlog geo API")
-
 _pool: asyncpg.Pool | None = None
 
 
+@asynccontextmanager
+async def lifespan(app: FastAPI):
+    yield
+    if _pool:
+        await _pool.close()
+
+
+app = FastAPI(title="flightlog geo API", lifespan=lifespan)
+
+
 async def get_pool() -> asyncpg.Pool:
     global _pool
     if _pool is None:
@@ -18,12 +27,6 @@ async def get_pool() -> asyncpg.Pool:
     return _pool
 
 
-@app.on_event("shutdown")
-async def shutdown() -> None:
-    if _pool:
-        await _pool.close()
-
-
 @app.get("/health")
 async def health() -> JSONResponse:
     """Liveness + readiness: verifies the DB connection is actually usable."""

tests/test_geo.py

@@ -0,0 +1,115 @@
+"""
+Integration tests for the geospatial track service.
+
+Requires a running PostGIS instance. Set DATABASE_URL to point at it, or the
+whole module is skipped. The sample flight CSV is copied to a temp path for
+each test session so the ingest deduplication key is unique and does not
+collide with any manually-ingested data.
+
+Run with:
+    DATABASE_URL=postgresql://geo:geopassword@localhost:5432/flightlog \
+        .venv/bin/pytest tests/test_geo.py -v
+"""
+
+import csv
+import os
+import shutil
+from pathlib import Path
+
+import pytest
+from fastapi.testclient import TestClient
+
+from geo.ingest import ingest
+
+DATABASE_URL = os.environ.get("DATABASE_URL", "")
+DATA_CSV = Path(__file__).parent.parent / "data" / "sample_flight.csv"
+
+pytestmark = pytest.mark.skipif(
+    not DATABASE_URL,
+    reason="DATABASE_URL not set — start PostGIS with docker compose -f docker-compose.geo.yml up",
+)
+
+
+@pytest.fixture(scope="module")
+def csv_path(tmp_path_factory):
+    """A temp copy of the sample CSV so the source_file key is test-session-unique."""
+    dest = tmp_path_factory.mktemp("geo") / "test_flight.csv"
+    shutil.copy(DATA_CSV, dest)
+    return dest
+
+
+@pytest.fixture(scope="module")
+def expected_points(csv_path):
+    """Count data rows in the CSV (excluding header)."""
+    with open(csv_path, newline="") as fh:
+        return sum(1 for _ in csv.DictReader(fh))
+
+
+@pytest.fixture(scope="module")
+def flight_id(csv_path):
+    return ingest(str(csv_path), DATABASE_URL)
+
+
+@pytest.fixture(scope="module")
+def client():
+    os.environ["DATABASE_URL"] = DATABASE_URL
+    # Import after setting the env var so asyncpg pool creation can read it.
+    from geo.api import app  # noqa: PLC0415
+
+    with TestClient(app) as c:
+        yield c
+
+
+# --- ingest ---
+
+
+def test_ingest_returns_positive_id(flight_id):
+    assert isinstance(flight_id, int)
+    assert flight_id > 0
+
+
+def test_ingest_idempotent(csv_path, flight_id):
+    """Running ingest twice on the same file must return the same id, not raise."""
+    second_id = ingest(str(csv_path), DATABASE_URL)
+    assert second_id == flight_id
+
+
+# --- API ---
+
+
+def test_health(client):
+    resp = client.get("/health")
+    assert resp.status_code == 200
+    assert resp.json() == {"status": "ok"}
+
+
+def test_track_is_geojson_feature(client, flight_id):
+    resp = client.get(f"/flights/{flight_id}/track")
+    assert resp.status_code == 200
+    body = resp.json()
+    assert body["type"] == "Feature"
+    assert body["properties"]["flight_id"] == flight_id
+
+
+def test_track_geometry_is_linestring(client, flight_id):
+    body = client.get(f"/flights/{flight_id}/track").json()
+    assert body["geometry"]["type"] == "LineString"
+
+
+def test_track_point_count(client, flight_id, expected_points):
+    """Coordinate count must match CSV row count — no duplicates, no drops."""
+    body = client.get(f"/flights/{flight_id}/track").json()
+    coords = body["geometry"]["coordinates"]
+    assert len(coords) == expected_points
+
+
+def test_track_coordinates_are_3d(client, flight_id):
+    """Each coordinate must be [lon, lat, alt] — three values (LineStringZ)."""
+    body = client.get(f"/flights/{flight_id}/track").json()
+    coords = body["geometry"]["coordinates"]
+    assert all(len(c) == 3 for c in coords)
+
+
+def test_track_unknown_flight_returns_404(client):
+    resp = client.get("/flights/999999/track")
+    assert resp.status_code == 404