Commit aa09bfe
committed
chore: assert sessionSyncContext on all stream-callback handlers
Five SessionImpl handlers reachable from dispatchResponseMessage —
handleSessionParamsResponse, handleSessionRefreshConfigResponse,
handleGoAwayResponse, handleUnknownResponseMessage — and the
dispatchStreamClosed entry point were missing the
throwIfNotInThisSynchronizationContext assertion that the other handlers
already have. The assertions are strictly redundant today (every caller
is either dispatchResponseMessage, which already asserts, or
sessionSyncContext.execute), but the asymmetry is incidental and adding
them uniformly documents the threading contract and guards against
future direct callers.1 parent 5312d04 commit aa09bfe
1 file changed
Lines changed: 5 additions & 0 deletions
File tree
- java-bigtable/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/internal/session
Lines changed: 5 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
538 | 538 | | |
539 | 539 | | |
540 | 540 | | |
| 541 | + | |
541 | 542 | | |
542 | 543 | | |
543 | 544 | | |
| |||
615 | 616 | | |
616 | 617 | | |
617 | 618 | | |
| 619 | + | |
618 | 620 | | |
619 | 621 | | |
620 | 622 | | |
| |||
679 | 681 | | |
680 | 682 | | |
681 | 683 | | |
| 684 | + | |
682 | 685 | | |
683 | 686 | | |
684 | 687 | | |
| |||
707 | 710 | | |
708 | 711 | | |
709 | 712 | | |
| 713 | + | |
710 | 714 | | |
711 | 715 | | |
712 | 716 | | |
713 | 717 | | |
714 | 718 | | |
| 719 | + | |
715 | 720 | | |
716 | 721 | | |
717 | 722 | | |
| |||
0 commit comments