fix: 7 bugs + editOrder raw signing + live-verified on 3 exchanges

CRITICAL: HL editOrder no longer hardcodes "buy" — looks up existing
order side via getOpenOrders() before modifying.

HIGH: Lighter getMarkPrice() now throws instead of returning 0, preventing
broken slippage calculations on market orders.

MEDIUM:
- smartOrder inferTickSize rounds to orderbook precision (fixes float noise
  like 0.10000000000000142)
- cancelAllOrders on Pacifica/Lighter now respects symbol filter instead
  of always cancelling everything
- HL _loadAssetMap logs errors + getAssetIndex retries once on empty map

LOW:
- Pacifica getRecentTrades uses API fee field when available
- cli-spec reads version from package.json via createRequire

BONUS: Extracted _signAndSendAction() from _rawPlaceOrder — universal
EIP-712 signing for any HL exchange action. _sendExchangeAction falls
back to it when SDK postAction is unavailable, fixing editOrder/TWAP/etc.

All 1197 tests pass. Live-verified: market/limit/cancel/close/smart/edit
across Hyperliquid, Pacifica, and Lighter.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: Hiksang

src/__tests__/arb-auto-3dex.test.ts

@@ -371,8 +371,8 @@ describe("computeRoundTripCostPct", () => {
 
   it("uses default slippage of 0.05%", () => {
     const cost = computeRoundTripCostPct("hyperliquid", "lighter");
-    // 2 × (0.035% + 0.035%) + 2 × 0.05% = 0.24%
-    expect(cost).toBeCloseTo(0.24, 4);
+    // lighter taker fee = 0%, so: 2 × (0.035% + 0%) + 2 × 0.05% = 0.17%
+    expect(cost).toBeCloseTo(0.17, 4);
   });
 
   it("handles custom slippage", () => {

src/__tests__/bugfix-v042.test.ts

@@ -0,0 +1,187 @@
+/**
+ * Tests for v0.4.2 bug fixes (BUG 1–7).
+ */
+import { describe, it, expect, vi } from "vitest";
+
+// ── BUG 1: HL editOrder preserves original side ──
+describe("BUG 1: HL editOrder preserves side", () => {
+  it("editOrder passes existing order side (sell) to modifyOrder", async () => {
+    // Dynamically import to avoid top-level side effects
+    const mod = await import("../exchanges/hyperliquid.js");
+    const HyperliquidAdapter = mod.HyperliquidAdapter;
+
+    // Create a partial mock: override getOpenOrders and modifyOrder
+    const adapter = Object.create(HyperliquidAdapter.prototype);
+    adapter.getOpenOrders = vi.fn().mockResolvedValue([
+      { orderId: "42", symbol: "ETH", side: "sell", price: "3000", size: "0.1", filled: "0", status: "open", type: "limit" },
+    ]);
+    adapter.modifyOrder = vi.fn().mockResolvedValue({ status: "ok" });
+
+    await adapter.editOrder("ETH", "42", "3100", "0.1");
+
+    expect(adapter.modifyOrder).toHaveBeenCalledWith("ETH", 42, "sell", "3100", "0.1");
+  });
+
+  it("editOrder defaults to buy when order not found in open orders", async () => {
+    const mod = await import("../exchanges/hyperliquid.js");
+    const HyperliquidAdapter = mod.HyperliquidAdapter;
+
+    const adapter = Object.create(HyperliquidAdapter.prototype);
+    adapter.getOpenOrders = vi.fn().mockResolvedValue([]);
+    adapter.modifyOrder = vi.fn().mockResolvedValue({ status: "ok" });
+
+    await adapter.editOrder("ETH", "999", "3100", "0.1");
+
+    // Falls back to "buy" when order not found
+    expect(adapter.modifyOrder).toHaveBeenCalledWith("ETH", 999, "buy", "3100", "0.1");
+  });
+});
+
+// ── BUG 2: Lighter getMarkPrice throws on 0 ──
+describe("BUG 2: Lighter getMarkPrice throws on zero", () => {
+  it("marketOrder throws when mark price is 0", async () => {
+    const mod = await import("../exchanges/lighter.js");
+    const LighterAdapter = mod.LighterAdapter;
+
+    // Create mock adapter that simulates getMarkPrice returning 0
+    const adapter = Object.create(LighterAdapter.prototype);
+    adapter._readOnly = false;
+    adapter._signer = {};
+    adapter._marketMap = new Map([["BTC", 0]]);
+    adapter._marketDecimals = new Map([["BTC", { size: 4, price: 2 }]]);
+    adapter.ensureSigner = vi.fn();
+    adapter.getNextNonce = vi.fn().mockResolvedValue(1);
+    adapter.getMarketIndex = vi.fn().mockReturnValue(0);
+    adapter.toTicks = vi.fn().mockReturnValue({ baseAmount: 10000, priceTicks: 0 });
+
+    // Mock restGet to return 0 mark price
+    adapter.restGet = vi.fn().mockResolvedValue({
+      order_book_details: [{ symbol: "BTC", last_trade_price: 0 }],
+    });
+
+    await expect(adapter.marketOrder("BTC", "buy", "0.001")).rejects.toThrow(
+      /Cannot determine mark price/
+    );
+  });
+});
+
+// ── BUG 3: inferTickSize float precision ──
+// (Covered in smart-order.test.ts — "rounds tick size to eliminate floating-point noise")
+
+// ── BUG 4: cancelAllOrders respects symbol filter ──
+describe("BUG 4: cancelAllOrders respects symbol filter", () => {
+  it("Pacifica cancelAllOrders filters by symbol", async () => {
+    const mod = await import("../exchanges/pacifica.js");
+    const PacificaAdapter = mod.PacificaAdapter;
+
+    const adapter = Object.create(PacificaAdapter.prototype);
+    adapter.getOpenOrders = vi.fn().mockResolvedValue([
+      { orderId: "1", symbol: "SOL", side: "buy", price: "100", size: "1", filled: "0", status: "open", type: "limit" },
+      { orderId: "2", symbol: "BTC", side: "sell", price: "50000", size: "0.01", filled: "0", status: "open", type: "limit" },
+      { orderId: "3", symbol: "SOL", side: "sell", price: "110", size: "1", filled: "0", status: "open", type: "limit" },
+    ]);
+    adapter.cancelOrder = vi.fn().mockResolvedValue({ ok: true });
+
+    await adapter.cancelAllOrders("SOL");
+
+    // Should only cancel SOL orders (IDs 1 and 3)
+    expect(adapter.cancelOrder).toHaveBeenCalledTimes(2);
+    expect(adapter.cancelOrder).toHaveBeenCalledWith("SOL", "1");
+    expect(adapter.cancelOrder).toHaveBeenCalledWith("SOL", "3");
+  });
+
+  it("Pacifica cancelAllOrders cancels all when no symbol", async () => {
+    const mod = await import("../exchanges/pacifica.js");
+    const PacificaAdapter = mod.PacificaAdapter;
+
+    const adapter = Object.create(PacificaAdapter.prototype);
+    adapter.client = {
+      cancelAllOrders: vi.fn().mockResolvedValue({ ok: true }),
+    };
+    adapter.account = "test-account";
+    adapter.signMessage = vi.fn();
+
+    await adapter.cancelAllOrders();
+
+    expect(adapter.client.cancelAllOrders).toHaveBeenCalledWith(
+      { all_symbols: true, exclude_reduce_only: false },
+      "test-account",
+      expect.any(Function),
+    );
+  });
+
+  it("Lighter cancelAllOrders filters by symbol", async () => {
+    const mod = await import("../exchanges/lighter.js");
+    const LighterAdapter = mod.LighterAdapter;
+
+    const adapter = Object.create(LighterAdapter.prototype);
+    adapter._readOnly = false;
+    adapter.ensureSigner = vi.fn();
+    adapter.getOpenOrders = vi.fn().mockResolvedValue([
+      { orderId: "10", symbol: "ETH", side: "buy", price: "3000", size: "0.1", filled: "0", status: "open", type: "limit" },
+      { orderId: "20", symbol: "BTC", side: "sell", price: "50000", size: "0.01", filled: "0", status: "open", type: "limit" },
+    ]);
+    adapter.cancelOrder = vi.fn().mockResolvedValue({ ok: true });
+
+    await adapter.cancelAllOrders("ETH");
+
+    expect(adapter.cancelOrder).toHaveBeenCalledTimes(1);
+    expect(adapter.cancelOrder).toHaveBeenCalledWith("ETH", "10");
+  });
+});
+
+// ── BUG 5: HL getAssetIndex retries on empty map ──
+describe("BUG 5: HL getAssetIndex retries on empty map", () => {
+  it("retries _loadAssetMap when map is empty", async () => {
+    const mod = await import("../exchanges/hyperliquid.js");
+    const HyperliquidAdapter = mod.HyperliquidAdapter;
+
+    const adapter = Object.create(HyperliquidAdapter.prototype);
+    adapter._assetMap = new Map();
+    adapter._assetMapReverse = new Map();
+    adapter._dex = "";
+
+    // _loadAssetMap populates the map on retry
+    adapter._loadAssetMap = vi.fn().mockImplementation(async () => {
+      adapter._assetMap.set("BTC", 0);
+      adapter._assetMap.set("ETH", 1);
+    });
+    adapter.resolveSymbol = vi.fn().mockReturnValue("BTC");
+
+    const idx = await adapter.getAssetIndex("BTC");
+    expect(adapter._loadAssetMap).toHaveBeenCalledTimes(1);
+    expect(idx).toBe(0);
+  });
+
+  it("does not retry when map is already populated", async () => {
+    const mod = await import("../exchanges/hyperliquid.js");
+    const HyperliquidAdapter = mod.HyperliquidAdapter;
+
+    const adapter = Object.create(HyperliquidAdapter.prototype);
+    adapter._assetMap = new Map([["BTC", 0]]);
+    adapter._assetMapReverse = new Map([[0, "BTC"]]);
+    adapter._loadAssetMap = vi.fn();
+    adapter.resolveSymbol = vi.fn().mockReturnValue("BTC");
+
+    const idx = await adapter.getAssetIndex("BTC");
+    expect(adapter._loadAssetMap).not.toHaveBeenCalled();
+    expect(idx).toBe(0);
+  });
+});
+
+// ── BUG 7: cli-spec version from package.json ──
+describe("BUG 7: cli-spec reads version from package.json", () => {
+  it("version is not hardcoded '0.1.0'", async () => {
+    const { getCliSpec } = await import("../cli-spec.js");
+    const { Command } = await import("commander");
+    const program = new Command();
+    program.name("perp");
+    const spec = getCliSpec(program);
+    expect(spec.version).not.toBe("0.1.0");
+    // Should match the version in package.json
+    const { createRequire } = await import("node:module");
+    const req = createRequire(import.meta.url);
+    const pkg = req("../../package.json") as { version: string };
+    expect(spec.version).toBe(pkg.version);
+  });
+});

src/__tests__/integration/agent-features.integration.test.ts

@@ -538,11 +538,11 @@ describe("Agent Features Integration (Hyperliquid Mainnet)", () => {
       expect(markets.length).toBeGreaterThan(50);
       // Verify we can look up at least one symbol using the exact format from the map
       const firstSymbol = markets[0].symbol;
-      expect(adapter.getAssetIndex(firstSymbol)).toBeGreaterThanOrEqual(0);
+      await expect(adapter.getAssetIndex(firstSymbol)).resolves.toBeGreaterThanOrEqual(0);
     }, 30_000);
 
-    it("adapter getAssetIndex throws for unknown symbol", () => {
-      expect(() => adapter.getAssetIndex("XYZNOTREAL999FAKE")).toThrow(/Unknown/i);
+    it("adapter getAssetIndex throws for unknown symbol", async () => {
+      await expect(adapter.getAssetIndex("XYZNOTREAL999FAKE")).rejects.toThrow(/Unknown/i);
     });
 
     it("adapter getMarkets returns well-formed data from real API", async () => {

src/__tests__/integration/hyperliquid.integration.test.ts

@@ -36,8 +36,8 @@ describe.skipIf(SKIP)("Hyperliquid Integration (Testnet)", () => {
       expect(Number(btc!.markPrice)).toBeGreaterThan(0);
     });
 
-    it("resolves asset index for BTC", () => {
-      const idx = adapter.getAssetIndex("BTC");
+    it("resolves asset index for BTC", async () => {
+      const idx = await adapter.getAssetIndex("BTC");
       expect(typeof idx).toBe("number");
       expect(idx).toBeGreaterThanOrEqual(0);
     });

src/__tests__/smart-order.test.ts

@@ -179,6 +179,22 @@ describe("smartOrder", () => {
     expect(adapter.marketOrder).toHaveBeenCalledWith("BTC", "sell", "0.1");
   });
 
+  it("rounds tick size to eliminate floating-point noise", async () => {
+    // Prices like "1.1" and "1.2" produce diff = 0.10000000000000009 in JS
+    const adapter = mockAdapter({
+      getOrderbook: vi.fn().mockResolvedValue({
+        bids: [["1.2", "10"], ["1.1", "20"], ["1.0", "15"]],
+        asks: [["1.3", "10"], ["1.4", "20"], ["1.5", "15"]],
+      }),
+    });
+    const result = await smartOrder(adapter, "TOKEN", "buy", "100");
+
+    // Tick should be exactly 0.1, not 0.10000000000000009
+    expect(result.tickSize).toBe("0.1");
+    // Price = 1.3 + 0.1 = 1.4
+    expect(result.price).toBe("1.4");
+  });
+
   it("does not fallback on embedded error when fallback=false", async () => {
     const hlResponse = {
       status: "ok",

src/cli-spec.ts

@@ -2,8 +2,12 @@
  * Generates a structured CLI spec from Commander's program tree.
  * Used by `perp api-spec` so agents can discover all commands programmatically.
  */
+import { createRequire } from "node:module";
 import type { Command } from "commander";
 
+const require = createRequire(import.meta.url);
+const { version: pkgVersion } = require("../package.json") as { version: string };
+
 interface ArgSpec {
   name: string;
   required: boolean;
@@ -77,7 +81,7 @@ export function getCliSpec(program: Command): CliSpec {
 
   return {
     name: "perp",
-    version: "0.1.0",
+    version: pkgVersion,
     description: "Multi-DEX Perpetual Futures CLI (Pacifica, Hyperliquid, Lighter)",
     globalOptions,
     commands,