test(slippage): regression tests for thena_cl/algebra_v3/balancer_v3

Pin the SSOT 7.3 invariants for the three remaining adapters in the
F1 fix. Mirrors the pattern from uniswap_v3.test.ts:

- thena_cl.test.ts (4 tests)
  - buildSwap rejects without amount_out_min (no quoter wired).
  - buildSwap forwards amount_out_min override verbatim.
  - buildRemoveLiquidity rejects without amount_{a,b}_min.
  - buildRemoveLiquidity sorts overrides onto amount{0,1}Min.

- balancer_v3.test.ts (2 tests)
  - buildSwap rejects without amount_out_min.
  - buildSwap forwards amount_out_min override verbatim.

- algebra_v3.test.ts (4 tests)
  - buildSwap honors amount_out_min override (skips quote path).
  - buildAddLiquidity defaults to 50 bps slippage on both axes
    (uses NEST-style v2 mint via pool_deployer flag).
  - buildRemoveLiquidity rejects without amount_{a,b}_min.
  - buildRemoveLiquidity sorts overrides onto amount{0,1}Min.

Total monorepo test count: 78 -> 95 (+17 across the F1 PR — uniswap_v3
contributed 7 in an earlier commit; this one adds 10 more).

Verified: 95/95 tests pass, lint clean across 3 packages.

Author: Hiksang

ts/packages/defi-protocols/src/dex/algebra_v3.test.ts

@@ -0,0 +1,128 @@
+// Slippage-protection regression tests for AlgebraV3Adapter (SSOT 7.3).
+//
+// The buildSwap auto-quote path is exercised against a live RPC in
+// integration tests; here we cover the explicit override path and the
+// LP-side guards that don't require an RPC.
+import { ProtocolCategory } from "@hypurrquant/defi-core";
+import type { ProtocolEntry } from "@hypurrquant/defi-core";
+import { decodeFunctionData, parseAbi, type Address, type Hex } from "viem";
+import { describe, expect, it } from "vitest";
+
+import { AlgebraV3Adapter } from "./algebra_v3.js";
+
+const LOW = ("0x" + "01".repeat(20)) as Address;
+const HIGH = ("0x" + "ff".repeat(20)) as Address;
+const RECIPIENT = ("0x" + "be".repeat(20)) as Address;
+
+const ENTRY: ProtocolEntry = {
+  name: "test_algebra_v3",
+  slug: "test-algebra-v3",
+  category: ProtocolCategory.Dex,
+  interface: "algebra_v3",
+  chain: "test",
+  contracts: {
+    router: ("0x" + "01".repeat(20)) as Address,
+    quoter: ("0x" + "02".repeat(20)) as Address,
+    position_manager: ("0x" + "03".repeat(20)) as Address,
+    factory: ("0x" + "04".repeat(20)) as Address,
+  },
+};
+
+const swapAbi = parseAbi([
+  "function exactInputSingle((address tokenIn, address tokenOut, address recipient, uint256 deadline, uint256 amountIn, uint256 amountOutMinimum, uint160 limitSqrtPrice) params) returns (uint256)",
+]);
+
+const v2MintAbi = parseAbi([
+  "function mint((address token0, address token1, int24 tickLower, int24 tickUpper, uint256 amount0Desired, uint256 amount1Desired, uint256 amount0Min, uint256 amount1Min, address recipient, uint256 deadline) params) returns (uint256, uint128, uint256, uint256)",
+]);
+
+const decreaseAbi = parseAbi([
+  "function decreaseLiquidity((uint256 tokenId, uint128 liquidity, uint256 amount0Min, uint256 amount1Min, uint256 deadline) params) returns (uint256, uint256)",
+]);
+
+const multicallAbi = parseAbi(["function multicall(bytes[] data) returns (bytes[])"]);
+
+interface SwapTuple { amountOutMinimum: bigint }
+interface MintTuple { amount0Min: bigint; amount1Min: bigint }
+interface DecreaseTuple { amount0Min: bigint; amount1Min: bigint }
+
+describe("AlgebraV3Adapter slippage protection (SSOT 7.3)", () => {
+  it("buildSwap honors amount_out_min override (skips the quote path)", async () => {
+    const adapter = new AlgebraV3Adapter(ENTRY);
+    const tx = await adapter.buildSwap({
+      protocol: ENTRY.slug,
+      token_in: LOW,
+      token_out: HIGH,
+      amount_in: 1_000_000n,
+      slippage: { bps: 50 },
+      recipient: RECIPIENT,
+      amount_out_min: 12_345n,
+    });
+    const decoded = decodeFunctionData({ abi: swapAbi, data: tx.data as Hex });
+    const params = decoded.args[0] as SwapTuple;
+    expect(params.amountOutMinimum).toBe(12_345n);
+    expect(params.amountOutMinimum).not.toBe(0n);
+  });
+
+  it("buildAddLiquidity defaults to 50 bps slippage on both axes", async () => {
+    // useSingleQuoter is gated on `pool_deployer` (NEST-style Algebra
+    // V2). Add it to land in the v2 mint branch whose ABI matches
+    // v2MintAbi below. The Integral branch (KittenSwap) ships a
+    // `deployer` field and is exercised separately by integration tests.
+    const v2Entry: ProtocolEntry = {
+      ...ENTRY,
+      contracts: {
+        ...(ENTRY.contracts as Record<string, Address>),
+        pool_deployer: ("0x" + "05".repeat(20)) as Address,
+      },
+    };
+    const adapter = new AlgebraV3Adapter(v2Entry);
+    const tx = await adapter.buildAddLiquidity({
+      protocol: v2Entry.slug,
+      token_a: LOW,
+      token_b: HIGH,
+      amount_a: 1_000_000n,
+      amount_b: 2_000_000n,
+      recipient: RECIPIENT,
+    });
+    const decoded = decodeFunctionData({ abi: v2MintAbi, data: tx.data as Hex });
+    const params = decoded.args[0] as MintTuple;
+    // 50 bps = 0.5% → minimum = desired * 9950 / 10000.
+    expect(params.amount0Min).toBe(995_000n);
+    expect(params.amount1Min).toBe(1_990_000n);
+  });
+
+  it("buildRemoveLiquidity refuses to ship without amount_{a,b}_min", async () => {
+    const adapter = new AlgebraV3Adapter(ENTRY);
+    await expect(
+      adapter.buildRemoveLiquidity({
+        protocol: ENTRY.slug,
+        token_a: LOW,
+        token_b: HIGH,
+        liquidity: 100n,
+        recipient: RECIPIENT,
+        token_id: 1n,
+      }),
+    ).rejects.toThrow(/amount_a_min and amount_b_min/);
+  });
+
+  it("buildRemoveLiquidity sorts amount_{a,b}_min onto amount{0,1}Min", async () => {
+    const adapter = new AlgebraV3Adapter(ENTRY);
+    const tx = await adapter.buildRemoveLiquidity({
+      protocol: ENTRY.slug,
+      token_a: LOW,
+      token_b: HIGH,
+      liquidity: 100n,
+      recipient: RECIPIENT,
+      token_id: 7n,
+      amount_a_min: 11n,
+      amount_b_min: 22n,
+    });
+    const outer = decodeFunctionData({ abi: multicallAbi, data: tx.data as Hex });
+    const decreaseData = (outer.args[0] as readonly Hex[])[0];
+    const decoded = decodeFunctionData({ abi: decreaseAbi, data: decreaseData });
+    const params = decoded.args[0] as DecreaseTuple;
+    expect(params.amount0Min).toBe(11n);
+    expect(params.amount1Min).toBe(22n);
+  });
+});

ts/packages/defi-protocols/src/dex/balancer_v3.test.ts

@@ -0,0 +1,57 @@
+// Slippage-protection regression test for BalancerV3Adapter (SSOT 7.3).
+import { ProtocolCategory } from "@hypurrquant/defi-core";
+import type { ProtocolEntry } from "@hypurrquant/defi-core";
+import { decodeFunctionData, parseAbi, type Address, type Hex } from "viem";
+import { describe, expect, it } from "vitest";
+
+import { BalancerV3Adapter } from "./balancer_v3.js";
+
+const LOW = ("0x" + "01".repeat(20)) as Address;
+const HIGH = ("0x" + "ff".repeat(20)) as Address;
+const RECIPIENT = ("0x" + "be".repeat(20)) as Address;
+
+const ENTRY: ProtocolEntry = {
+  name: "test_balancer_v3",
+  slug: "test-balancer-v3",
+  category: ProtocolCategory.Dex,
+  interface: "balancer_v3",
+  chain: "test",
+  contracts: { router: ("0x" + "01".repeat(20)) as Address },
+};
+
+const swapAbi = parseAbi([
+  "function swapSingleTokenExactIn(address pool, address tokenIn, address tokenOut, uint256 exactAmountIn, uint256 minAmountOut, uint256 deadline, bool wethIsEth, bytes userData) returns (uint256)",
+]);
+
+describe("BalancerV3Adapter slippage protection (SSOT 7.3)", () => {
+  it("buildSwap refuses to ship without amount_out_min", async () => {
+    const adapter = new BalancerV3Adapter(ENTRY);
+    await expect(
+      adapter.buildSwap({
+        protocol: ENTRY.slug,
+        token_in: LOW,
+        token_out: HIGH,
+        amount_in: 1_000_000n,
+        slippage: { bps: 50 },
+        recipient: RECIPIENT,
+      }),
+    ).rejects.toThrow(/amount_out_min/);
+  });
+
+  it("buildSwap forwards amount_out_min override verbatim", async () => {
+    const adapter = new BalancerV3Adapter(ENTRY);
+    const tx = await adapter.buildSwap({
+      protocol: ENTRY.slug,
+      token_in: LOW,
+      token_out: HIGH,
+      amount_in: 1_000_000n,
+      slippage: { bps: 50 },
+      recipient: RECIPIENT,
+      amount_out_min: 99_999n,
+    });
+    const decoded = decodeFunctionData({ abi: swapAbi, data: tx.data as Hex });
+    // args order: pool, tokenIn, tokenOut, exactAmountIn, minAmountOut, ...
+    expect((decoded.args as readonly unknown[])[4]).toBe(99_999n);
+    expect((decoded.args as readonly unknown[])[4]).not.toBe(0n);
+  });
+});

ts/packages/defi-protocols/src/dex/thena_cl.test.ts

@@ -0,0 +1,104 @@
+// Slippage-protection regression tests for ThenaCLAdapter (SSOT 7.3).
+import { ProtocolCategory } from "@hypurrquant/defi-core";
+import type { ProtocolEntry } from "@hypurrquant/defi-core";
+import { decodeFunctionData, parseAbi, type Address, type Hex } from "viem";
+import { describe, expect, it } from "vitest";
+
+import { ThenaCLAdapter } from "./thena_cl.js";
+
+const LOW = ("0x" + "01".repeat(20)) as Address;
+const HIGH = ("0x" + "ff".repeat(20)) as Address;
+const RECIPIENT = ("0x" + "be".repeat(20)) as Address;
+
+const ENTRY: ProtocolEntry = {
+  name: "test_thena_cl",
+  slug: "test-thena-cl",
+  category: ProtocolCategory.Dex,
+  interface: "thena_cl",
+  chain: "test",
+  contracts: {
+    router: ("0x" + "01".repeat(20)) as Address,
+    position_manager: ("0x" + "03".repeat(20)) as Address,
+    pool_factory: ("0x" + "04".repeat(20)) as Address,
+  },
+};
+
+const swapAbi = parseAbi([
+  "function exactInputSingle((address tokenIn, address tokenOut, int24 tickSpacing, address recipient, uint256 deadline, uint256 amountIn, uint256 amountOutMinimum, uint160 sqrtPriceLimitX96) params) returns (uint256)",
+]);
+
+const decreaseAbi = parseAbi([
+  "function decreaseLiquidity((uint256 tokenId, uint128 liquidity, uint256 amount0Min, uint256 amount1Min, uint256 deadline) params) returns (uint256, uint256)",
+]);
+
+const multicallAbi = parseAbi(["function multicall(bytes[] data) returns (bytes[])"]);
+
+interface SwapTuple { amountOutMinimum: bigint; amountIn: bigint }
+interface DecreaseTuple { amount0Min: bigint; amount1Min: bigint }
+
+describe("ThenaCLAdapter slippage protection (SSOT 7.3)", () => {
+  it("buildSwap refuses to ship without amount_out_min (no quoter wired)", async () => {
+    const adapter = new ThenaCLAdapter(ENTRY);
+    await expect(
+      adapter.buildSwap({
+        protocol: ENTRY.slug,
+        token_in: LOW,
+        token_out: HIGH,
+        amount_in: 1_000_000n,
+        slippage: { bps: 50 },
+        recipient: RECIPIENT,
+      }),
+    ).rejects.toThrow(/amount_out_min/);
+  });
+
+  it("buildSwap forwards amount_out_min override verbatim", async () => {
+    const adapter = new ThenaCLAdapter(ENTRY);
+    const tx = await adapter.buildSwap({
+      protocol: ENTRY.slug,
+      token_in: LOW,
+      token_out: HIGH,
+      amount_in: 1_000_000n,
+      slippage: { bps: 50 },
+      recipient: RECIPIENT,
+      amount_out_min: 12_345n,
+    });
+    const decoded = decodeFunctionData({ abi: swapAbi, data: tx.data as Hex });
+    const params = decoded.args[0] as SwapTuple;
+    expect(params.amountOutMinimum).toBe(12_345n);
+    expect(params.amountOutMinimum).not.toBe(0n);
+  });
+
+  it("buildRemoveLiquidity refuses to ship without amount_{a,b}_min", async () => {
+    const adapter = new ThenaCLAdapter(ENTRY);
+    await expect(
+      adapter.buildRemoveLiquidity({
+        protocol: ENTRY.slug,
+        token_a: LOW,
+        token_b: HIGH,
+        liquidity: 100n,
+        recipient: RECIPIENT,
+        token_id: 1n,
+      }),
+    ).rejects.toThrow(/amount_a_min and amount_b_min/);
+  });
+
+  it("buildRemoveLiquidity sorts amount_{a,b}_min onto amount{0,1}Min", async () => {
+    const adapter = new ThenaCLAdapter(ENTRY);
+    const tx = await adapter.buildRemoveLiquidity({
+      protocol: ENTRY.slug,
+      token_a: LOW,
+      token_b: HIGH,
+      liquidity: 100n,
+      recipient: RECIPIENT,
+      token_id: 7n,
+      amount_a_min: 11n,
+      amount_b_min: 22n,
+    });
+    const outer = decodeFunctionData({ abi: multicallAbi, data: tx.data as Hex });
+    const decreaseData = (outer.args[0] as readonly Hex[])[0];
+    const decoded = decodeFunctionData({ abi: decreaseAbi, data: decreaseData });
+    const params = decoded.args[0] as DecreaseTuple;
+    expect(params.amount0Min).toBe(11n);
+    expect(params.amount1Min).toBe(22n);
+  });
+});