Within richards jacobian there is a flag `ovlnd_flag`. This is always instantiated to 1 (true) https://github.com/hydroframe/ParFlow_PerfTeam/blob/master/pfsimulator/parflow_lib/richards_jacobian_eval.c#L388 It is frequently checked if it is set to 0 (false) in BC looping such as https://github.com/hydroframe/ParFlow_PerfTeam/blob/master/pfsimulator/parflow_lib/richards_jacobian_eval.c#L1259 https://github.com/hydroframe/ParFlow_PerfTeam/blob/master/pfsimulator/parflow_lib/richards_jacobian_eval.c#L1416 https://github.com/hydroframe/ParFlow_PerfTeam/blob/master/pfsimulator/parflow_lib/richards_jacobian_eval.c#L1460 It is only checked once at https://github.com/hydroframe/ParFlow_PerfTeam/blob/master/pfsimulator/parflow_lib/richards_jacobian_eval.c#L1530 Since this is always 1 (there is nowhere I see that sets it to 0), are these if statements necessary?
Within richards jacobian there is a flag
ovlnd_flag. This is always instantiated to 1 (true) https://github.com/hydroframe/ParFlow_PerfTeam/blob/master/pfsimulator/parflow_lib/richards_jacobian_eval.c#L388It is frequently checked if it is set to 0 (false) in BC looping such as
https://github.com/hydroframe/ParFlow_PerfTeam/blob/master/pfsimulator/parflow_lib/richards_jacobian_eval.c#L1259
https://github.com/hydroframe/ParFlow_PerfTeam/blob/master/pfsimulator/parflow_lib/richards_jacobian_eval.c#L1416
https://github.com/hydroframe/ParFlow_PerfTeam/blob/master/pfsimulator/parflow_lib/richards_jacobian_eval.c#L1460
It is only checked once at
https://github.com/hydroframe/ParFlow_PerfTeam/blob/master/pfsimulator/parflow_lib/richards_jacobian_eval.c#L1530
Since this is always 1 (there is nowhere I see that sets it to 0), are these if statements necessary?