Skip to content

Already known devices not used on second discover #1

Description

@marceljaehn

In doDiscover null is given as second argument, instead of the list of known devices: https://github.com/HouseOS/secure_control_protocol/blob/66d2fdd7e9c55d80089736c2d24e652daa29f906/lib/scp.dart#L59

This leads to the passwort beeing null, because the list of known devices is empty, even when a device is already provisioned and thus not using the default passwort.
https://github.com/HouseOS/secure_control_protocol/blob/66d2fdd7e9c55d80089736c2d24e652daa29f906/lib/scp_response_parser.dart#L32-L38

Due to the usage of the default password, when in fact the device already has a passwort, leads to an incorrect value when calculating the HMac in
https://github.com/HouseOS/secure_control_protocol/blob/66d2fdd7e9c55d80089736c2d24e652daa29f906/lib/scp_crypto.dart#L103-L109

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions