';
$imgId = $this->_genID($var->getVarName(), false) . 'ehelper';
- $page_output = $GLOBALS['injector']->getInstance('Horde_PageOutput');
+ $page_output = $GLOBALS['injector']->get(Horde_PageOutput::class);
$page_output->addScriptFile('open_html_helper.js', 'horde');
if ($var->hasHelper('emoticons')) {
- $filter = $GLOBALS['injector']->getInstance('Horde_Core_Factory_TextFilter')->create('emoticons');
+ $filter = $GLOBALS['injector']->get(Horde_Core_Factory_TextFilter::class)->create('emoticons');
$icon_list = [];
foreach (array_flip($filter->getIcons() ?? []) as $icon => $string) {
@@ -541,7 +541,7 @@ protected function _renderVarInput_monthdayyear($form, &$var, &$vars)
return $this->_renderVarInput_basic($form, $var, $vars);
}
- $GLOBALS['injector']->getInstance('Horde_PageOutput')->addInlineScript(
+ $GLOBALS['injector']->get(Horde_PageOutput::class)->addInlineScript(
"document.observe('Horde_Calendar:select', "
. 'function(e) {'
. 'var elt = e.element();'
@@ -645,7 +645,7 @@ protected function _renderVarInput_colorpicker($form, &$var, &$vars)
. ' value="' . htmlspecialchars((string) $color)
. '" />';
if ($browser->hasFeature('javascript')) {
- $GLOBALS['injector']->getInstance('Horde_PageOutput')->addScriptFile('colorpicker.js', 'horde');
+ $GLOBALS['injector']->get(Horde_PageOutput::class)->addScriptFile('colorpicker.js', 'horde');
$html .= ' '
. Horde::link(
'#',
@@ -663,7 +663,7 @@ protected function _renderVarInput_sorter($form, &$var, &$vars)
{
$instance = $var->getProperty('instance');
- $page = $GLOBALS['injector']->getInstance('Horde_PageOutput');
+ $page = $GLOBALS['injector']->get(Horde_PageOutput::class);
$page->addScriptFile('sorter.js', 'horde');
$page->addInlineScript(
sprintf(
@@ -687,7 +687,7 @@ protected function _renderVarInput_sorter($form, &$var, &$vars)
protected function _renderVarInput_assign($form, &$var, &$vars)
{
- $GLOBALS['injector']->getInstance('Horde_PageOutput')->addScriptFile('form_assign.js', 'horde');
+ $GLOBALS['injector']->get(Horde_PageOutput::class)->addScriptFile('form_assign.js', 'horde');
$name = htmlspecialchars((string) $var->getVarName());
$size = $var->getSize();
@@ -853,7 +853,7 @@ protected function _renderVarInput_set($form, &$var, &$vars)
$disable = Horde_Core_Translation::t('Select none');
$invert = Horde_Core_Translation::t('Invert selection');
$GLOBALS['injector']
- ->getInstance('Horde_PageOutput')
+ ->get(Horde_PageOutput::class)
->addInlineScript(sprintf(
'
function %s()
@@ -1057,7 +1057,7 @@ protected function _renderVarInput_obrowser($form, &$var, &$vars)
$varvalue = $vars->get($varname);
$fieldId = $this->_genID(uniqid(mt_rand()), false) . 'id';
$GLOBALS['injector']
- ->getInstance('Horde_PageOutput')
+ ->get(Horde_PageOutput::class)
->addInlineScript(sprintf(
'
var obrowserWindowName;
@@ -1139,7 +1139,7 @@ protected function _renderVarDisplay_email($form, &$var, &$vars)
$email_val = $var->getValue($vars);
if ($var->getProperty('link_compose')) {
- $addrs = $GLOBALS['injector']->getInstance('Horde_Mail_Rfc822')->parseAddressList($email_val, [
+ $addrs = $GLOBALS['injector']->get('Horde_Mail_Rfc822')->parseAddressList($email_val, [
'limit' => $var->getProperty('allow_multi') ? 0 : 1,
]);
@@ -1167,7 +1167,7 @@ protected function _renderVarDisplay_email($form, &$var, &$vars)
return $link;
} else {
- $addrs = $GLOBALS['injector']->getInstance('Horde_Mail_Rfc822')->parseAddressList($email_val, [
+ $addrs = $GLOBALS['injector']->get('Horde_Mail_Rfc822')->parseAddressList($email_val, [
'limit' => $var->getProperty('allow_multi') ? 0 : 1,
]);
@@ -1461,7 +1461,7 @@ protected function _renderVarDisplay_pgp($form, &$var, &$vars)
return '';
}
return ''
- . $GLOBALS['injector']->getInstance('Horde_Core_Factory_Crypt')->create('Pgp', $var->getPGPParams())->pgpPrettyKey($key)
+ . $GLOBALS['injector']->get(Horde_Core_Factory_Crypt::class)->create('Pgp', $var->getPGPParams())->pgpPrettyKey($key)
. '';
}
@@ -1473,7 +1473,7 @@ protected function _renderVarDisplay_smime($form, &$var, &$vars)
}
try {
return $GLOBALS['injector']
- ->getInstance('Horde_Core_Factory_Crypt')
+ ->get(Horde_Core_Factory_Crypt::class)
->create('Smime', $var->getSMIMEParams())
->certToHTML($cert);
} catch (Horde_Crypt_Exception $e) {
@@ -1626,7 +1626,7 @@ protected function _renderVarDisplay_captcha($form, &$var, &$vars)
}
$cid = hash('md5', $var->getText());
- $cache = $GLOBALS['injector']->getInstance('Horde_Cache');
+ $cache = $GLOBALS['injector']->get('Horde_Cache');
$cache->set($cid, serialize(['data' => $captcha->getCAPTCHAAsJPEG(),
'ctype' => 'image/jpeg']));
@@ -1693,7 +1693,7 @@ protected function _renderVarInput_selectFiles($form, &$var, &$vars)
protected function _renderVarInput_category($form, &$var, &$vars)
{
- $GLOBALS['injector']->getInstance('Horde_PageOutput')->addScriptFile('form_helpers.js', 'horde');
+ $GLOBALS['injector']->get(Horde_PageOutput::class)->addScriptFile('form_helpers.js', 'horde');
$this->_addOnLoadJavascript('addEvent(document.getElementById(\'' . $form->getName() . '\'), \'submit\', checkCategory);');
return ''
. Horde_Prefs_CategoryManager::getJavaScript($form->getName(), $var->getVarName())
diff --git a/lib/Horde/Core/Ui/VarRenderer/TablesetHtml.php b/lib/Horde/Core/Ui/VarRenderer/TablesetHtml.php
index 9da40906..2d356733 100644
--- a/lib/Horde/Core/Ui/VarRenderer/TablesetHtml.php
+++ b/lib/Horde/Core/Ui/VarRenderer/TablesetHtml.php
@@ -26,7 +26,7 @@ protected function _renderVarInput_tableset($form, &$var, &$vars)
$disable = Horde_Core_Translation::t('Select none');
$invert = Horde_Core_Translation::t('Invert selection');
- $page = $GLOBALS['injector']->getInstance('Horde_PageOutput');
+ $page = $GLOBALS['injector']->get(Horde_PageOutput::class);
$page->addScriptFile('tables.js', 'horde');
$page->addInlineScript(sprintf(
'
@@ -99,7 +99,7 @@ protected function _renderVarDisplay_tableset($form, &$var, &$vars)
$values = $var->getValues();
$checkedValues = $var->getValue($vars);
- $GLOBALS['injector']->getInstance('Horde_PageOutput')->addScriptFile('tables.js', 'horde');
+ $GLOBALS['injector']->get(Horde_PageOutput::class)->addScriptFile('tables.js', 'horde');
$html = ''
. '| | ';
foreach ($header as $col_title) {
diff --git a/lib/Horde/Deprecated.php b/lib/Horde/Deprecated.php
index 2414633e..b02e59c7 100644
--- a/lib/Horde/Deprecated.php
+++ b/lib/Horde/Deprecated.php
@@ -185,7 +185,7 @@ public static function base64ImgData($in, $limit = null)
*/
public static function callHook($hook, $args = [], $app = 'horde')
{
- return $GLOBALS['injector']->getInstance('Horde_Core_Hooks')
+ return $GLOBALS['injector']->get(Horde_Core_Hooks::class)
->callHook($hook, $app, $args);
}
@@ -204,7 +204,7 @@ public static function callHook($hook, $args = [], $app = 'horde')
*/
public static function hookExists($hook, $app = 'horde')
{
- return $GLOBALS['injector']->getInstance('Horde_Core_Hooks')
+ return $GLOBALS['injector']->get(Horde_Core_Hooks::class)
->hookExists($hook, $app);
}
diff --git a/lib/Horde/Menu.php b/lib/Horde/Menu.php
index 42c8327b..2d47479b 100644
--- a/lib/Horde/Menu.php
+++ b/lib/Horde/Menu.php
@@ -126,7 +126,7 @@ public function render()
*/
protected function _render()
{
- $sidebar = $GLOBALS['injector']->getInstance('Horde_View_Sidebar');
+ $sidebar = $GLOBALS['injector']->get('Horde_View_Sidebar');
foreach ($this->_menu as $m) {
/* Check for separators. */
diff --git a/lib/Horde/PageOutput.php b/lib/Horde/PageOutput.php
index 5e2420a5..dcdeefe0 100644
--- a/lib/Horde/PageOutput.php
+++ b/lib/Horde/PageOutput.php
@@ -210,7 +210,7 @@ public function includeScriptFiles($full = false)
$this->smartmobileInit = [];
}
- $out = $injector->getInstance('Horde_Core_JavascriptCache')->process($this->hsl, $full);
+ $out = $injector->get('Horde_Core_JavascriptCache')->process($this->hsl, $full);
$this->hsl->clear();
@@ -449,12 +449,8 @@ private function injectSessionApiMetaTags()
return;
}
try {
- $renderer = $GLOBALS['injector']->getInstance(
- Horde\Core\PageOutput\SessionApiMetaRenderer::class
- );
- $session = $GLOBALS['injector']->getInstance(
- Horde\Core\Session\HordeSession::class
- );
+ $renderer = $GLOBALS['injector']->get(Horde\Core\PageOutput\SessionApiMetaRenderer::class);
+ $session = $GLOBALS['injector']->get(Horde\Core\Session\HordeSession::class);
} catch (Throwable $e) {
return;
}
@@ -621,7 +617,7 @@ public function header(array $opts = [])
{
global $injector, $language, $registry, $session;
- $tokenService = $injector->getInstance(Horde\Token\Token::class);
+ $tokenService = $injector->get(Horde\Token\Token::class);
$view = new Horde_View([
'templatePath' => $registry->get('templates', 'horde') . '/common',
@@ -823,7 +819,7 @@ public function header(array $opts = [])
echo $view->render('header');
if ($this->topbar) {
- echo $injector->getInstance('Horde_View_Topbar')->render();
+ echo $injector->get('Horde_View_Topbar')->render();
}
// Send what we have currently output so the browser can start
@@ -858,7 +854,7 @@ protected function _addThemeScripts()
/* The cache instance may come back unserialized; themeScripts() is
* derived on demand (not serialized), like the covered-apps list. */
- $cache = $injector->getInstance('Horde_Core_Factory_ThemesCache')
+ $cache = $injector->get(Horde_Core_Factory_ThemesCache::class)
->create($registry->getApp(), $theme);
foreach ($cache->themeScripts() as $script) {
diff --git a/lib/Horde/Registry.php b/lib/Horde/Registry.php
index f455167c..8661e276 100644
--- a/lib/Horde/Registry.php
+++ b/lib/Horde/Registry.php
@@ -555,12 +555,8 @@ public function __construct($session_flags = 0, array $args = [])
/* Optional injector profiling — activated by env var. */
if (getenv('HORDE_INJECTOR_PROFILE')) {
try {
- $dispatcher = $injector->getInstance(
- EventDispatcherInterface::class
- );
- $provider = $injector->getInstance(
- ListenerProviderInterface::class
- );
+ $dispatcher = $injector->get(EventDispatcherInterface::class);
+ $provider = $injector->get(ListenerProviderInterface::class);
$collector = new \Horde\Injector\BindingMapCollector();
$provider->addListener($collector);
$injector->setEventDispatcher($dispatcher);
@@ -584,7 +580,7 @@ public function __construct($session_flags = 0, array $args = [])
/* Initial Horde-wide settings. */
/* Initialize browser object. */
- $GLOBALS['browser'] = $injector->getInstance('Horde_Browser');
+ $GLOBALS['browser'] = $injector->get('Horde_Browser');
/* Get modified time of registry files. */
$regfiles = [
@@ -635,13 +631,13 @@ public function __construct($session_flags = 0, array $args = [])
* instance; two divergent instances for the same PHP
* session id decrypt each other's ciphertext with
* different keys. See horde/Core#182. */
- $hordeSession = $injector->getInstance(HordeSession::class);
+ $hordeSession = $injector->get(HordeSession::class);
$injector->setInstance(HordeSession::class, $hordeSession);
/* Ensure the per-session CSRF secret exists before closing a
* read-only session, so view/download scripts can validate
* tokens generated on full page views. */
- $injector->getInstance(TokenServiceFactory::class)
+ $injector->get(TokenServiceFactory::class)
->createForSession($hordeSession);
if ($session_flags & self::SESSION_READONLY) {
@@ -667,7 +663,7 @@ public function __construct($session_flags = 0, array $args = [])
$this->setLanguageEnvironment(null, 'horde');
/* Initialize global page output object. */
- $GLOBALS['page_output'] = $injector->getInstance('Horde_PageOutput');
+ $GLOBALS['page_output'] = $injector->get(Horde_PageOutput::class);
/* Initialize notification object. Always attach status listener by
* default. */
@@ -681,7 +677,7 @@ public function __construct($session_flags = 0, array $args = [])
$nclass = 'Horde_Core_Notification_Listener_SmartmobileStatus';
break;
}
- $GLOBALS['notification'] = $injector->getInstance('Horde_Notification');
+ $GLOBALS['notification'] = $injector->get('Horde_Notification');
if (empty($args['nonotificationinit'])) {
$GLOBALS['notification']->attachAllAppHandlers();
}
@@ -760,7 +756,7 @@ public function __sleep()
*/
public function rebuild()
{
- $session = $GLOBALS['injector']->getInstance(HordeSession::class);
+ $session = $GLOBALS['injector']->get(HordeSession::class);
$app = $this->getApp();
@@ -803,7 +799,7 @@ protected function _loadApplications()
]),
[
'lifetime' => 0,
- 'logger' => $injector->getInstance('Horde_Log_Logger'),
+ 'logger' => $injector->get('Horde_Log_Logger'),
]
);
@@ -811,7 +807,7 @@ protected function _loadApplications()
&& ($cdata = $cache->get($cid, 0))) {
try {
[$this->applications, $this->_interfaces]
- = $injector->getInstance('Horde_Pack')->unpack($cdata);
+ = $injector->get('Horde_Pack')->unpack($cdata);
return;
} catch (Horde_Pack_Exception $e) {
}
@@ -829,7 +825,7 @@ protected function _loadApplications()
/* Need to determine hash of generated data, since it is possible that
* there is dynamic data in the config files. This only needs to
* be done once per session. */
- $packed_data = $injector->getInstance('Horde_Pack')->pack([
+ $packed_data = $injector->get('Horde_Pack')->pack([
$this->applications,
$this->_interfaces,
]);
@@ -848,7 +844,7 @@ protected function _loadApplications()
*/
protected function _cacheId($hash = null)
{
- $session = $GLOBALS['injector']->getInstance(HordeSession::class);
+ $session = $GLOBALS['injector']->get(HordeSession::class);
if (!is_null($hash)) {
$hash = hash('md5', $hash);
@@ -919,7 +915,7 @@ public function getApiInstance($app, $type)
* be done here because it is possible to try to load app-specific
* libraries from other applications. */
if (!isset($this->_cache['ob'][$app])) {
- $autoloader = $GLOBALS['injector']->getInstance('Horde_Autoloader');
+ $autoloader = $GLOBALS['injector']->get('Horde_Autoloader');
$app_mappers = [
'Controller' => 'controllers',
@@ -1559,7 +1555,7 @@ public function getServiceLink($type, $app = null, $full = false): Url
->add(
'token',
(string) $GLOBALS['injector']
- ->getInstance(Token::class)
+ ->get(Token::class)
->generate(HordeSession::CSRF_SEED)
);
@@ -1751,7 +1747,7 @@ public function pushApp($app, array $options = [])
}
/* Run authenticated hooks, if necessary. */
- $hooks = $injector->getInstance('Horde_Core_Hooks');
+ $hooks = $injector->get(Horde_Core_Hooks::class);
if ($session->get('horde', 'auth_app_init/' . $app)) {
try {
$error = self::INITCALLBACK_FATAL;
@@ -1787,7 +1783,7 @@ public function pushApp($app, array $options = [])
/* Do login tasks. */
if ($checkPerms
&& !empty($options['logintasks'])
- && ($tasks = $injector->getInstance('Horde_Core_Factory_LoginTasks')->create($app))) {
+ && ($tasks = $injector->get(Horde_Core_Factory_LoginTasks::class)->create($app))) {
$tasks->runTasks();
}
@@ -1885,7 +1881,7 @@ public function hasPermission(
* authentication against the app's auth backend, i.e. IMAP for IMP.
*/
if (($perms != Horde_Perms::SHOW)
- && $GLOBALS['injector']->getInstance('Horde_Core_Factory_Auth')->create($app)->requireAuth()
+ && $GLOBALS['injector']->get(Horde_Core_Factory_Auth::class)->create($app)->requireAuth()
&& !$this->isAuthenticated(['app' => $app, 'notransparent' => !empty($params['notransparent'])])) {
return false;
}
@@ -1893,8 +1889,8 @@ public function hasPermission(
/* Otherwise, allow access for admins, for apps that do not have any
* explicit permissions, or for apps that allow the given permission. */
return $this->isAdmin()
- || ($GLOBALS['injector']->getInstance('Horde_Perms')->exists($app)
- ? $GLOBALS['injector']->getInstance('Horde_Perms')->hasPermission($app, $this->getAuth(), $perms)
+ || ($GLOBALS['injector']->get('Horde_Perms')->exists($app)
+ ? $GLOBALS['injector']->get('Horde_Perms')->hasPermission($app, $this->getAuth(), $perms)
: (bool) $this->getAuth());
}
@@ -1964,7 +1960,7 @@ public function loadPrefs($app = null)
];
}
- $prefs = $injector->getInstance('Horde_Core_Factory_Prefs')->create($app, $opts);
+ $prefs = $injector->get(Horde_Core_Factory_Prefs::class)->create($app, $opts);
}
/**
@@ -2137,7 +2133,7 @@ public function hasView($view, $app = null)
*/
public function setView($view = self::VIEW_BASIC)
{
- $GLOBALS['injector']->getInstance(HordeSession::class)
+ $GLOBALS['injector']->get(HordeSession::class)
->setScoped('horde', 'view', $view);
}
@@ -2148,7 +2144,7 @@ public function setView($view = self::VIEW_BASIC)
*/
public function getView()
{
- $session = $GLOBALS['injector']->getInstance(HordeSession::class);
+ $session = $GLOBALS['injector']->get(HordeSession::class);
return $session->hasScoped('horde', 'view')
? $session->getScoped('horde', 'view')
@@ -2261,7 +2257,7 @@ public function getInitialPage($app = null)
*/
public function clearAuth($destroy = true)
{
- $session = $GLOBALS['injector']->getInstance(HordeSession::class);
+ $session = $GLOBALS['injector']->get(HordeSession::class);
/* Do application logout tasks. */
/* @todo: Replace with exclusively registered logout tasks. */
@@ -2318,7 +2314,7 @@ public function clearAuth($destroy = true)
// shim's `$GLOBALS['session']->destroy()` wrapped exactly this
// call; reaching for SessionLifecycle directly removes the
// last shim hop inside Registry::clearAuth.
- $lifecycle = $GLOBALS['injector']->getInstance(SessionLifecycle::class);
+ $lifecycle = $GLOBALS['injector']->get(SessionLifecycle::class);
$lifecycle->destroy();
// Mark the modern HordeSession destroyed so
@@ -2329,7 +2325,7 @@ public function clearAuth($destroy = true)
// rebuilt instance, not the one we resolved at the top of
// this method.
$GLOBALS['injector']
- ->getInstance(HordeSession::class)
+ ->get(HordeSession::class)
->markDestroyed();
}
}
@@ -2343,7 +2339,7 @@ public function clearAuth($destroy = true)
*/
public function clearAuthApp($app)
{
- $session = $GLOBALS['injector']->getInstance(HordeSession::class);
+ $session = $GLOBALS['injector']->get(HordeSession::class);
if ($session->getScoped('horde', 'auth/credentials') == $app) {
return false;
@@ -2390,7 +2386,7 @@ public function isAdmin(array $options = [])
}
return isset($options['permission'])
- ? $GLOBALS['injector']->getInstance('Horde_Perms')->hasPermission($options['permission'], $user, $options['permlevel'] ?? Horde_Perms::EDIT)
+ ? $GLOBALS['injector']->get('Horde_Perms')->hasPermission($options['permission'], $user, $options['permlevel'] ?? Horde_Perms::EDIT)
: false;
}
@@ -2428,7 +2424,7 @@ public function isAuthenticated(array $opts = [])
$res = true;
} elseif ($transparent) {
try {
- $res = $injector->getInstance('Horde_Core_Factory_Auth')->create($app)->transparent();
+ $res = $injector->get(Horde_Core_Factory_Auth::class)->create($app)->transparent();
} catch (Horde_Exception $e) {
Horde::log($e);
$res = false;
@@ -2480,7 +2476,7 @@ public function getLogoutUrl(array $options = []): Url
if (!isset($options['reason'])) {
// TODO: This only returns the error for Horde-wide
// authentication, not for application auth.
- $options['reason'] = $GLOBALS['injector']->getInstance('Horde_Core_Factory_Auth')->create()->getError();
+ $options['reason'] = $GLOBALS['injector']->get(Horde_Core_Factory_Auth::class)->create()->getError();
}
$params = [];
@@ -2492,7 +2488,7 @@ public function getLogoutUrl(array $options = []): Url
|| ($options['app'] == 'horde')
|| ($options['reason'] == Horde_Auth::REASON_LOGOUT)) {
$params['horde_logout_token'] = (string) $GLOBALS['injector']
- ->getInstance(Token::class)
+ ->get(Token::class)
->generate(HordeSession::CSRF_SEED);
}
@@ -2504,7 +2500,7 @@ public function getLogoutUrl(array $options = []): Url
$params['logout_reason'] = $options['reason'];
if ($options['reason'] == Horde_Auth::REASON_MESSAGE) {
$params['logout_msg'] = empty($options['msg'])
- ? $GLOBALS['injector']->getInstance('Horde_Core_Factory_Auth')->create()->getError(true)
+ ? $GLOBALS['injector']->get(Horde_Core_Factory_Auth::class)->create()->getError(true)
: $options['msg'];
}
}
@@ -2551,7 +2547,7 @@ public function downloadUrl($filename, array $params = []): Url
public function convertUsername($userId, $toHorde)
{
try {
- return $GLOBALS['injector']->getInstance('Horde_Core_Hooks')
+ return $GLOBALS['injector']->get(Horde_Core_Hooks::class)
->callHook('authusername', 'horde', [$userId, $toHorde]);
} catch (Horde_Exception_HookNotSet $e) {
return $userId;
@@ -2577,7 +2573,7 @@ public function getAuth($format = null)
return $this->_cache['auth'];
}
- $session = $GLOBALS['injector']->getInstance(HordeSession::class);
+ $session = $GLOBALS['injector']->get(HordeSession::class);
if ($format == 'original') {
return $session->hasScoped('horde', 'auth/authId')
@@ -2616,7 +2612,7 @@ public function getAuth($format = null)
*/
public function passwordChangeRequested()
{
- return (bool) $GLOBALS['injector']->getInstance(HordeSession::class)
+ return (bool) $GLOBALS['injector']->get(HordeSession::class)
->getScoped('horde', 'auth/change');
}
@@ -2705,7 +2701,7 @@ protected function _getAuthCredentials($app)
*/
private function _credentialStore(): AuthCredentialStore
{
- return $GLOBALS['injector']->getInstance(AuthCredentialStore::class);
+ return $GLOBALS['injector']->get(AuthCredentialStore::class);
}
/**
@@ -2715,7 +2711,7 @@ private function _credentialStore(): AuthCredentialStore
*/
private function _credentialBaseApp(): ?string
{
- $value = $GLOBALS['injector']->getInstance(HordeSession::class)
+ $value = $GLOBALS['injector']->get(HordeSession::class)
->getScoped('horde', 'auth/credentials');
return is_string($value) ? $value : null;
@@ -2769,7 +2765,7 @@ public function remoteHost()
}
// Legacy mode: Perform DNS resolution
- $dns = $injector->getInstance('Net_DNS2_Resolver');
+ $dns = $injector->get('Net_DNS2_Resolver');
if ($dns && !isset($out->host)) {
$out->host = $out->addr;
@@ -2881,21 +2877,21 @@ public function checkExistingAuth($app = 'horde')
&& ($remoteaddr = $session->get('horde', 'auth/remoteAddr'))
&& ($remoteob = $this->remoteHost())
&& ($remoteaddr != $remoteob->addr)) {
- $injector->getInstance('Horde_Core_Factory_Auth')->create()
+ $injector->get(Horde_Core_Factory_Auth::class)->create()
->setError(Horde_Core_Auth_Application::REASON_SESSIONIP);
return false;
}
if (!empty($conf['auth']['checkbrowser'])
&& ($session->get('horde', 'auth/browser') != $browser->getAgentString())) {
- $injector->getInstance('Horde_Core_Factory_Auth')->create()
+ $injector->get(Horde_Core_Factory_Auth::class)->create()
->setError(Horde_Core_Auth_Application::REASON_BROWSER);
return false;
}
if (!empty($conf['session']['max_time'])
&& (($conf['session']['max_time'] + $session->begin) < time())) {
- $injector->getInstance('Horde_Core_Factory_Auth')->create()
+ $injector->get(Horde_Core_Factory_Auth::class)->create()
->setError(Horde_Core_Auth_Application::REASON_SESSIONMAXTIME);
return false;
}
@@ -2903,7 +2899,7 @@ public function checkExistingAuth($app = 'horde')
foreach (array_unique(['horde', $app]) as $val) {
if (!isset($this->_cache['existing'][$val])) {
- $auth = $injector->getInstance('Horde_Core_Factory_Auth')->create($val);
+ $auth = $injector->get(Horde_Core_Factory_Auth::class)->create($val);
if (!$auth->validateAuth()) {
if (!$auth->getError()) {
$auth->setError(Horde_Auth::REASON_SESSION);
@@ -2928,7 +2924,7 @@ public function checkExistingAuth($app = 'horde')
public function removeUser($userId)
{
$GLOBALS['injector']
- ->getInstance('Horde_Core_Factory_Auth')
+ ->get(Horde_Core_Factory_Auth::class)
->create()
->removeUser($userId);
$this->removeUserData($userId);
@@ -2957,7 +2953,7 @@ public function removeUserData($user, $app = null)
$errApps = [];
if (!empty($applist)) {
$prefs_ob = $GLOBALS['injector']
- ->getInstance('Horde_Core_Factory_Prefs')
+ ->get(Horde_Core_Factory_Prefs::class)
->create('horde', ['user' => $user]);
// Remove all preference at once, if possible.
@@ -3014,7 +3010,7 @@ public function removeUserData($user, $app = null)
*/
public function getAuthInfo()
{
- $session = $GLOBALS['injector']->getInstance(HordeSession::class);
+ $session = $GLOBALS['injector']->get(HordeSession::class);
// Reproduce the legacy "prefix get" semantics: read all keys
// starting with "auth/" under the horde scope, return them as a
@@ -3038,7 +3034,7 @@ public function getAuthInfo()
public function getAuthApps()
{
$apps = [];
- foreach ($GLOBALS['injector']->getInstance(HordeSession::class)->keysForApp('horde') as $key) {
+ foreach ($GLOBALS['injector']->get(HordeSession::class)->keysForApp('horde') as $key) {
if (str_starts_with($key, 'auth_app/')) {
$apps[] = substr($key, 9);
}
@@ -3088,7 +3084,7 @@ public function getEmailCharset()
*/
public function preferredLang($lang = null)
{
- $session = $GLOBALS['injector']->getInstance(HordeSession::class);
+ $session = $GLOBALS['injector']->get(HordeSession::class);
/* Check if we have a language set in the session */
if ($session->hasScoped('horde', 'language')) {
@@ -3163,7 +3159,7 @@ public function setLanguage($lang = null)
$lang = $this->preferredLang();
}
- $GLOBALS['injector']->getInstance(HordeSession::class)
+ $GLOBALS['injector']->get(HordeSession::class)
->setScoped('horde', 'language', $lang);
$changed = false;
@@ -3228,7 +3224,7 @@ public function setLanguageEnvironment($lang = null, $app = null)
return;
}
- $session = $GLOBALS['injector']->getInstance(HordeSession::class);
+ $session = $GLOBALS['injector']->get(HordeSession::class);
$session->clearScopeWithPrefixes('horde', ['nls/']);
}
diff --git a/lib/Horde/Registry/Application.php b/lib/Horde/Registry/Application.php
index 92ff10c6..85b7fae8 100644
--- a/lib/Horde/Registry/Application.php
+++ b/lib/Horde/Registry/Application.php
@@ -252,7 +252,7 @@ protected function _backupPrefs(Backup\User $backup, $app)
{
global $injector;
- $prefs = $injector->getInstance('Horde_Core_Factory_Prefs')
+ $prefs = $injector->get(Horde_Core_Factory_Prefs::class)
->create($app, ['user' => $backup->user]);
$prefs->retrieve();
$scope = $prefs->getScopeObject($app);
@@ -284,7 +284,7 @@ protected function _restorePrefs(Backup\Collection $data, $app)
{
global $injector;
- $prefs = $injector->getInstance('Horde_Core_Factory_Prefs')
+ $prefs = $injector->get(Horde_Core_Factory_Prefs::class)
->create($app, ['user' => $data->getUser()]);
$prefs->retrieve();
@@ -534,7 +534,7 @@ final protected function _addSessVars($vars)
*/
final public function updateSessVars()
{
- $session = $GLOBALS['injector']->getInstance(HordeSession::class);
+ $session = $GLOBALS['injector']->get(HordeSession::class);
foreach ($this->_sessVars as $key => $val) {
$session->setScoped($this->_app, $key, $val);
}
diff --git a/lib/Horde/Registry/Logout.php b/lib/Horde/Registry/Logout.php
index 3cec8193..92d49e74 100644
--- a/lib/Horde/Registry/Logout.php
+++ b/lib/Horde/Registry/Logout.php
@@ -67,7 +67,7 @@ public function run()
foreach ($this->_getTasks() as $val) {
try {
- $ob = $injector->getInstance($val);
+ $ob = $injector->get($val);
if ($ob instanceof Horde_Registry_Logout_Task) {
$ob->logoutTask();
}
@@ -105,6 +105,6 @@ private function _setTasks($queue)
*/
private function _session(): SessionAccess
{
- return $GLOBALS['injector']->getInstance(SessionAccess::class);
+ return $GLOBALS['injector']->get(SessionAccess::class);
}
}
diff --git a/lib/Horde/Registry/Nlsconfig.php b/lib/Horde/Registry/Nlsconfig.php
index 8c5f711c..266e9ba2 100644
--- a/lib/Horde/Registry/Nlsconfig.php
+++ b/lib/Horde/Registry/Nlsconfig.php
@@ -165,6 +165,6 @@ public function validLang($lang)
*/
private function _session(): SessionAccess
{
- return $GLOBALS['injector']->getInstance(SessionAccess::class);
+ return $GLOBALS['injector']->get(SessionAccess::class);
}
}
diff --git a/lib/Horde/Script/Cache/HordeCache.php b/lib/Horde/Script/Cache/HordeCache.php
index 48c6390b..2b5281e7 100644
--- a/lib/Horde/Script/Cache/HordeCache.php
+++ b/lib/Horde/Script/Cache/HordeCache.php
@@ -55,7 +55,7 @@ protected function _process($scripts, $full = false)
json_encode($hashes) . $mtime
);
- $cache = $injector->getInstance('Horde_Cache');
+ $cache = $injector->get('Horde_Cache');
$cache_lifetime = empty($this->_params['lifetime'])
? 0
: $this->_params['lifetime'];
diff --git a/lib/Horde/Script/Compress.php b/lib/Horde/Script/Compress.php
index 6c85790c..56e2d68e 100644
--- a/lib/Horde/Script/Compress.php
+++ b/lib/Horde/Script/Compress.php
@@ -59,7 +59,7 @@ public function __construct($driver, array $params = [])
global $injector;
$this->_params = [
- 'logger' => $injector->getInstance('Horde_Log_Logger'),
+ 'logger' => $injector->get('Horde_Log_Logger'),
];
switch ($driver) {
diff --git a/lib/Horde/Session.php b/lib/Horde/Session.php
index 6020a219..2dff3a98 100644
--- a/lib/Horde/Session.php
+++ b/lib/Horde/Session.php
@@ -252,7 +252,7 @@ private function _resolveAccess(): ?SessionAccess
return null;
}
try {
- $access = $GLOBALS['injector']->getInstance(SessionAccess::class);
+ $access = $GLOBALS['injector']->get(SessionAccess::class);
return $access instanceof SessionAccess ? $access : null;
} catch (\Throwable) {
return null;
@@ -270,7 +270,7 @@ private function _resolveAccess(): ?SessionAccess
private function _resolveModernFallback(): HordeSession
{
if (isset($GLOBALS['injector'])) {
- return $GLOBALS['injector']->getInstance(HordeSession::class);
+ return $GLOBALS['injector']->get(HordeSession::class);
}
$sid = (string) (session_id() ?: 'none');
@@ -291,7 +291,7 @@ private function _resolveModernFallback(): HordeSession
private function _resolveLifecycle(): ?SessionLifecycle
{
if (isset($GLOBALS['injector'])) {
- return $GLOBALS['injector']->getInstance(SessionLifecycle::class);
+ return $GLOBALS['injector']->get(SessionLifecycle::class);
}
return null;
}
@@ -436,7 +436,7 @@ public function setup(
* land in HordeSession before this mirror copies them back to
* $_SESSION. addFinal() is single-slot last-writer-wins. */
if (isset($GLOBALS['injector'])) {
- $GLOBALS['injector']->getInstance('Horde_Shutdown')->addFinal($this);
+ $GLOBALS['injector']->get(Horde_Shutdown::class)->addFinal($this);
}
if ($start) {
@@ -869,9 +869,7 @@ private function _tokenService(): ModernToken
}
if (isset($GLOBALS['injector'])) {
- $factory = $GLOBALS['injector']->getInstance(
- TokenServiceFactory::class
- );
+ $factory = $GLOBALS['injector']->get(TokenServiceFactory::class);
$this->tokenService = $factory->createForSession($this->modern());
return $this->tokenService;
}
@@ -948,7 +946,7 @@ public function store($data, $prune = true, $id = null)
}
$ob = new Horde_Core_Cache_SessionObjects();
- $ob->set($id, $injector->getInstance('Horde_Pack')->pack($data));
+ $ob->set($id, $injector->get('Horde_Pack')->pack($data));
return $id;
}
@@ -962,7 +960,7 @@ public function retrieve($id)
$ob = new Horde_Core_Cache_SessionObjects();
try {
- return $injector->getInstance('Horde_Pack')->unpack($ob->get($id));
+ return $injector->get('Horde_Pack')->unpack($ob->get($id));
} catch (Horde_Pack_Exception $e) {
}
diff --git a/lib/Horde/Shutdown.php b/lib/Horde/Shutdown.php
index de51e039..10609883 100644
--- a/lib/Horde/Shutdown.php
+++ b/lib/Horde/Shutdown.php
@@ -53,7 +53,7 @@ class Horde_Shutdown
*/
public static function add(Horde_Shutdown_Task $task)
{
- $GLOBALS['injector']->getInstance('Horde_Shutdown')->addTask($task);
+ $GLOBALS['injector']->get(Horde_Shutdown::class)->addTask($task);
}
/**
diff --git a/lib/Horde/Themes.php b/lib/Horde/Themes.php
index ebf77a41..8674d86a 100644
--- a/lib/Horde/Themes.php
+++ b/lib/Horde/Themes.php
@@ -124,7 +124,7 @@ public static function soundList($app = null, $theme = null)
$theme = $GLOBALS['prefs']->getValue('theme');
}
- $cache = $GLOBALS['injector']->getInstance('Horde_Core_Factory_ThemesCache')->create($app, $theme);
+ $cache = $GLOBALS['injector']->get(Horde_Core_Factory_ThemesCache::class)->create($app, $theme);
$sounds = [];
foreach ($cache->build() as $val) {
diff --git a/lib/Horde/Themes/Css.php b/lib/Horde/Themes/Css.php
index cd923711..5d04c089 100644
--- a/lib/Horde/Themes/Css.php
+++ b/lib/Horde/Themes/Css.php
@@ -99,7 +99,7 @@ public function getStylesheetUrls(array $opts = [])
}
$cache_ob = empty($opts['nocache'])
- ? $injector->getInstance('Horde_Core_CssCache')
+ ? $injector->get('Horde_Core_CssCache')
: new Horde_Themes_Css_Cache_Null();
return $cache_ob->process($css, $this->_cacheid);
@@ -155,7 +155,7 @@ public function getStylesheets($theme = '', array $opts = [])
? null
: $opts['sub'];
- $cache = $injector->getInstance('Horde_Core_Factory_ThemesCache')->create($curr_app, $theme);
+ $cache = $injector->get(Horde_Core_Factory_ThemesCache::class)->create($curr_app, $theme);
$this->_cacheid = $cache->getCacheId();
/* Add external stylesheets first, since they are ALWAYS overwritable
@@ -182,7 +182,7 @@ public function getStylesheets($theme = '', array $opts = [])
}
/* Add user-defined additional stylesheets. */
- $hooks = $injector->getInstance('Horde_Core_Hooks');
+ $hooks = $injector->get(Horde_Core_Hooks::class);
try {
$add_css = array_merge($add_css, $hooks->callHook('cssfiles', 'horde', [$theme]));
} catch (Horde_Exception_HookNotSet $e) {
diff --git a/lib/Horde/Themes/Css/Cache/HordeCache.php b/lib/Horde/Themes/Css/Cache/HordeCache.php
index ab3eb93a..61eb90c9 100644
--- a/lib/Horde/Themes/Css/Cache/HordeCache.php
+++ b/lib/Horde/Themes/Css/Cache/HordeCache.php
@@ -38,7 +38,7 @@ public function process($css, $cacheid)
}
}
- $cache = $injector->getInstance('Horde_Cache');
+ $cache = $injector->get('Horde_Cache');
$sig = hash(
/* Use 64-bit FNV algo (instead of 32-bit) since this is a
* publicly accessible key and we want to guarantee filename
diff --git a/lib/Horde/Themes/Element.php b/lib/Horde/Themes/Element.php
index 06595bf1..17ec58b5 100644
--- a/lib/Horde/Themes/Element.php
+++ b/lib/Horde/Themes/Element.php
@@ -131,7 +131,7 @@ public function __get($name)
'uri' => $registry->get('themesuri', $this->app) . '/' . $theme . '/' . $this->_dirname,
];
} else {
- $cache = $GLOBALS['injector']->getInstance('Horde_Core_Factory_ThemesCache')->create($this->app, $theme);
+ $cache = $GLOBALS['injector']->get(Horde_Core_Factory_ThemesCache::class)->create($this->app, $theme);
$mask = empty($this->_opts['nohorde'])
? 0
: Horde_Themes_Cache::APP_DEFAULT | Horde_Themes_Cache::APP_THEME;
diff --git a/src/Ajax/Application.php b/src/Ajax/Application.php
index cfa36ff9..8d713f63 100644
--- a/src/Ajax/Application.php
+++ b/src/Ajax/Application.php
@@ -40,6 +40,7 @@
use InvalidArgumentException;
use stdClass;
use Throwable;
+use Horde_Core_Hooks;
abstract class Application
{
@@ -122,7 +123,7 @@ public function __construct(
if (!$auth) {
throw new Horde_Exception('Accessing AJAX action without being authenticated.');
}
- $tokenService = $injector->getInstance(Token::class);
+ $tokenService = $injector->get(Token::class);
try {
$valid = $tokenService->isValid((string) $token, HordeSession::CSRF_SEED);
} catch (TokenException) {
@@ -203,7 +204,7 @@ public function doAction()
return;
}
- $hooks = $injector->getInstance('Horde_Core_Hooks');
+ $hooks = $injector->get(Horde_Core_Hooks::class);
/* Look for action in helpers. */
if ($ob = $this->_getHandler()) {
@@ -288,7 +289,7 @@ public function send()
if (!headers_sent()) {
try {
- $fresh = $injector->getInstance(Token::class)
+ $fresh = $injector->get(Token::class)
->generate(HordeSession::CSRF_SEED);
header('X-Csrf-Token: ' . (string) $fresh);
} catch (TokenException) {
@@ -364,7 +365,7 @@ protected function _getHandler()
protected function _tryApiRegistry($injector)
{
try {
- $apiRegistry = $injector->getInstance(ApiRegistry::class);
+ $apiRegistry = $injector->get(ApiRegistry::class);
} catch (Throwable $e) {
return null;
}
@@ -375,7 +376,7 @@ protected function _tryApiRegistry($injector)
}
try {
- $api = $injector->getInstance($apiClass);
+ $api = $injector->get($apiClass);
} catch (Throwable $e) {
return null;
}
diff --git a/src/Auth/AuthCredentialStoreFactory.php b/src/Auth/AuthCredentialStoreFactory.php
index ef688522..1fb89008 100644
--- a/src/Auth/AuthCredentialStoreFactory.php
+++ b/src/Auth/AuthCredentialStoreFactory.php
@@ -32,7 +32,7 @@ class AuthCredentialStoreFactory
public function create(Injector $injector): AuthCredentialStore
{
return new AuthCredentialStore(
- $injector->getInstance(SessionAccess::class),
+ $injector->get(SessionAccess::class),
);
}
}
diff --git a/src/Config/StateFactory.php b/src/Config/StateFactory.php
index 6960405b..989d6861 100644
--- a/src/Config/StateFactory.php
+++ b/src/Config/StateFactory.php
@@ -45,6 +45,6 @@ public function create(Injector $injector): State
}
// Modern path: ConfigLoader reads conf.php directly from disk.
- return $injector->getInstance(ConfigLoader::class)->load('horde');
+ return $injector->get(ConfigLoader::class)->load('horde');
}
}
diff --git a/src/Factory/ActiveSyncOpsSnapshotFactory.php b/src/Factory/ActiveSyncOpsSnapshotFactory.php
index 4cfd3e27..c1c0cf85 100644
--- a/src/Factory/ActiveSyncOpsSnapshotFactory.php
+++ b/src/Factory/ActiveSyncOpsSnapshotFactory.php
@@ -40,7 +40,7 @@ public function create(Horde_Injector|Injector $injector): SnapshotService
$logging = $conf['activesync']['logging'] ?? [];
return new SnapshotService(
- state: $injector->getInstance('Horde_ActiveSyncState'),
+ state: $injector->get('Horde_ActiveSyncState'),
logPaths: new DeviceLogPathResolver(
is_string($logging['type'] ?? null)
? $logging['type']
@@ -49,7 +49,7 @@ public function create(Horde_Injector|Injector $injector): SnapshotService
? $logging['path']
: null
),
- logger: $injector->getInstance('Horde_Log_Logger')
+ logger: $injector->get('Horde_Log_Logger')
);
}
}
diff --git a/src/Factory/ApiRegistryFactory.php b/src/Factory/ApiRegistryFactory.php
index 34425c49..4427fcb8 100644
--- a/src/Factory/ApiRegistryFactory.php
+++ b/src/Factory/ApiRegistryFactory.php
@@ -23,7 +23,7 @@ class ApiRegistryFactory
public function create(Injector $injector): ApiRegistry
{
$registry = new ApiRegistry();
- $registryLoader = $injector->getInstance(RegistryConfigLoader::class);
+ $registryLoader = $injector->get(RegistryConfigLoader::class);
$state = $registryLoader->load();
foreach ($state->listApplications() as $appName) {
@@ -38,7 +38,7 @@ public function create(Injector $injector): ApiRegistry
}
try {
- $appInstance = $injector->getInstance($className);
+ $appInstance = $injector->get($className);
$interfaces = $appInstance->getApiInterfaceList();
} catch (Throwable) {
continue;
@@ -46,7 +46,7 @@ public function create(Injector $injector): ApiRegistry
foreach ($interfaces as $interface => $providerClass) {
try {
- $provider = $injector->getInstance($providerClass);
+ $provider = $injector->get($providerClass);
} catch (Throwable) {
continue;
}
diff --git a/src/Factory/ApplicationServiceFactory.php b/src/Factory/ApplicationServiceFactory.php
index 954e84f2..b9d33263 100644
--- a/src/Factory/ApplicationServiceFactory.php
+++ b/src/Factory/ApplicationServiceFactory.php
@@ -32,7 +32,7 @@ class ApplicationServiceFactory
{
public function create(Injector $injector): ApplicationService
{
- $registryLoader = $injector->getInstance(RegistryConfigLoader::class);
+ $registryLoader = $injector->get(RegistryConfigLoader::class);
return new ApplicationService($registryLoader);
}
}
diff --git a/src/Factory/AuthBaseFactory.php b/src/Factory/AuthBaseFactory.php
index 49a31ac8..d512c1ef 100644
--- a/src/Factory/AuthBaseFactory.php
+++ b/src/Factory/AuthBaseFactory.php
@@ -23,11 +23,12 @@
use Horde_Auth_Base;
use Horde_Core_Factory_Injector;
use Horde\Injector\Injector;
+use Horde_Core_Factory_Auth;
class AuthBaseFactory extends Horde_Core_Factory_Injector
{
public function create(Injector $injector): Horde_Auth_Base
{
- return $injector->getInstance('Horde_Core_Factory_Auth')->create();
+ return $injector->get(Horde_Core_Factory_Auth::class)->create();
}
}
diff --git a/src/Factory/AuthHttpBasicFactory.php b/src/Factory/AuthHttpBasicFactory.php
index 69690500..8894c676 100644
--- a/src/Factory/AuthHttpBasicFactory.php
+++ b/src/Factory/AuthHttpBasicFactory.php
@@ -8,6 +8,7 @@
use Horde_Core_Factory_Injector as InjectorFactory;
use Horde\Injector\Injector as Injector;
use Horde_Registry;
+use Horde_Core_Factory_Auth;
class AuthHttpBasicFactory extends InjectorFactory
{
@@ -21,7 +22,7 @@ class AuthHttpBasicFactory extends InjectorFactory
*/
public function create(Injector $injector): AuthHttpBasic
{
- $driver = $injector->getInstance('Horde_Core_Factory_Auth')->create();
+ $driver = $injector->get(Horde_Core_Factory_Auth::class)->create();
$registry = $injector->get(Horde_Registry::class);
return new AuthHttpBasic($driver, $registry);
}
diff --git a/src/Factory/AuthIsGlobalAdminFactory.php b/src/Factory/AuthIsGlobalAdminFactory.php
index 51e2d0e9..5b1bc08e 100644
--- a/src/Factory/AuthIsGlobalAdminFactory.php
+++ b/src/Factory/AuthIsGlobalAdminFactory.php
@@ -23,7 +23,7 @@ class AuthIsGlobalAdminFactory
{
public function create(Injector $injector): AuthIsGlobalAdmin
{
- $loader = $injector->getInstance(ConfigLoader::class);
+ $loader = $injector->get(ConfigLoader::class);
$state = $loader->load('horde');
$admins = $state->get('auth.admins', []);
diff --git a/src/Factory/AuthLinkRepositoryFactory.php b/src/Factory/AuthLinkRepositoryFactory.php
index abaed00a..25594e8f 100644
--- a/src/Factory/AuthLinkRepositoryFactory.php
+++ b/src/Factory/AuthLinkRepositoryFactory.php
@@ -33,14 +33,14 @@ class AuthLinkRepositoryFactory
public function create(Injector $injector): AuthLinkRepository
{
try {
- $db = $injector->getInstance(Adapter::class);
+ $db = $injector->get(Adapter::class);
return new SqlAuthLinkRepository($db);
} catch (Throwable) {
// SQL not available, try file-based
}
try {
- $loader = $injector->getInstance(ConfigLoader::class);
+ $loader = $injector->get(ConfigLoader::class);
$state = $loader->load('horde');
$filePath = $state->get('auth.authlink_file', '');
diff --git a/src/Factory/AuthServiceFactory.php b/src/Factory/AuthServiceFactory.php
index b121f4a9..d261b10c 100644
--- a/src/Factory/AuthServiceFactory.php
+++ b/src/Factory/AuthServiceFactory.php
@@ -41,7 +41,7 @@ class AuthServiceFactory
{
public function create(Injector $injector): AuthService
{
- $loader = $injector->getInstance(ConfigLoader::class);
+ $loader = $injector->get(ConfigLoader::class);
$state = $loader->load('horde');
$driver = $state->get('auth.driver', 'sql');
@@ -49,7 +49,7 @@ public function create(Injector $injector): AuthService
$provider = $this->buildProvider($driver, $params, $injector);
$policy = $this->buildPolicy($params, $injector);
- $identityBridge = $injector->getInstance(IdentityBridgeService::class);
+ $identityBridge = $injector->get(IdentityBridgeService::class);
return new AuthService($provider, $policy, $identityBridge);
}
@@ -87,7 +87,7 @@ private function buildPolicy(array $params, Injector $injector): AccessPolicy
private function createSqlProvider(array $params, Injector $injector): Sql
{
- $dbService = $injector->getInstance(HordeDbService::class);
+ $dbService = $injector->get(HordeDbService::class);
return new Sql(
db: $dbService->getAdapter(),
@@ -101,7 +101,7 @@ private function createSqlProvider(array $params, Injector $injector): Sql
private function createLdapProvider(array $params, Injector $injector): Ldap
{
- $ldap = $injector->getInstance(Horde_Ldap::class);
+ $ldap = $injector->get(Horde_Ldap::class);
return new Ldap(
ldap: $ldap,
@@ -123,7 +123,7 @@ private function createImapProvider(array $params, Injector $injector): Imap
default => SecureMode::None,
};
- $clientFactory = $injector->getInstance('Horde_Imap_Client_Factory');
+ $clientFactory = $injector->get('Horde_Imap_Client_Factory');
return new Imap(
clientFactory: $clientFactory,
diff --git a/src/Factory/AuthStorageFactory.php b/src/Factory/AuthStorageFactory.php
index 38607730..7ebe9ec5 100644
--- a/src/Factory/AuthStorageFactory.php
+++ b/src/Factory/AuthStorageFactory.php
@@ -28,14 +28,14 @@ class AuthStorageFactory
{
public function createLockManager(Injector $injector): LockManager
{
- $lock = $injector->getInstance(Horde_Lock::class);
+ $lock = $injector->get(Horde_Lock::class);
return new HordeLockAdapter($lock);
}
public function createAttemptTracker(Injector $injector): LoginAttemptTracker
{
- $history = $injector->getInstance(Horde_History::class);
+ $history = $injector->get(Horde_History::class);
return new HistoryAttemptTracker($history);
}
diff --git a/src/Factory/CheckCredentialsFactory.php b/src/Factory/CheckCredentialsFactory.php
index 1c7a941b..72705e0d 100644
--- a/src/Factory/CheckCredentialsFactory.php
+++ b/src/Factory/CheckCredentialsFactory.php
@@ -21,7 +21,7 @@ class CheckCredentialsFactory
{
public function create(Injector $injector): CheckCredentials
{
- $authService = $injector->getInstance(AuthService::class);
+ $authService = $injector->get(AuthService::class);
return new CheckCredentials($authService);
}
diff --git a/src/Factory/ConfigLoaderFactory.php b/src/Factory/ConfigLoaderFactory.php
index 3aff8f89..02eebd57 100644
--- a/src/Factory/ConfigLoaderFactory.php
+++ b/src/Factory/ConfigLoaderFactory.php
@@ -45,7 +45,7 @@ public function create(Injector $injector): ConfigLoader
// Try to get metadata provider if available
$metadataProvider = null;
try {
- $metadataProvider = $injector->getInstance(ConfigMetadataProvider::class);
+ $metadataProvider = $injector->get(ConfigMetadataProvider::class);
} catch (Exception $e) {
// Metadata provider not available, continue without it
}
diff --git a/src/Factory/ConfigMetadataProviderFactory.php b/src/Factory/ConfigMetadataProviderFactory.php
index 9b5d7393..8accb03b 100644
--- a/src/Factory/ConfigMetadataProviderFactory.php
+++ b/src/Factory/ConfigMetadataProviderFactory.php
@@ -43,7 +43,7 @@ public function __construct(
*/
public function create(): ConfigMetadataProvider
{
- $repository = $this->injector->getInstance(DriverRepository::class);
+ $repository = $this->injector->get(DriverRepository::class);
return new ConfigMetadataProvider($repository);
}
}
diff --git a/src/Factory/CssDiscovererFactory.php b/src/Factory/CssDiscovererFactory.php
index 60bd2ca8..9efd2bef 100644
--- a/src/Factory/CssDiscovererFactory.php
+++ b/src/Factory/CssDiscovererFactory.php
@@ -30,19 +30,19 @@ class CssDiscovererFactory
{
public function create(Injector $injector): CssDiscoverer
{
- $pathBuilder = $injector->getInstance(PathBuilderInterface::class);
- $uriBuilder = $injector->getInstance(UriBuilderInterface::class);
- $filesystem = $injector->getInstance(AssetFilesystem::class);
+ $pathBuilder = $injector->get(PathBuilderInterface::class);
+ $uriBuilder = $injector->get(UriBuilderInterface::class);
+ $filesystem = $injector->get(AssetFilesystem::class);
$textDirection = null;
try {
- $textDirection = $injector->getInstance(TextDirectionProvider::class);
+ $textDirection = $injector->get(TextDirectionProvider::class);
} catch (Throwable) {
}
$hookProvider = null;
try {
- $hookProvider = $injector->getInstance(CssHookProvider::class);
+ $hookProvider = $injector->get(CssHookProvider::class);
} catch (Throwable) {
}
diff --git a/src/Factory/DateFormatPrefsFactory.php b/src/Factory/DateFormatPrefsFactory.php
index 2639db23..df036cac 100644
--- a/src/Factory/DateFormatPrefsFactory.php
+++ b/src/Factory/DateFormatPrefsFactory.php
@@ -37,13 +37,13 @@ public function create(Horde_Injector|Injector $injector): DateFormatPrefs
{
$logger = null;
try {
- $logger = $injector->getInstance(LoggerInterface::class);
+ $logger = $injector->get(LoggerInterface::class);
} catch (Throwable) {
// Logger unavailable — proceed without
}
return new DateFormatPrefs(
- prefs: $injector->getInstance('Horde_Prefs'),
+ prefs: $injector->get('Horde_Prefs'),
locale: $GLOBALS['language'] ?? 'en_US',
logger: $logger,
);
diff --git a/src/Factory/DbAdapterFactory.php b/src/Factory/DbAdapterFactory.php
index 2da3d4f8..03d8c585 100644
--- a/src/Factory/DbAdapterFactory.php
+++ b/src/Factory/DbAdapterFactory.php
@@ -64,12 +64,12 @@ public function create(Injector $injector): Adapter
$ob = new $class($config);
try {
- $ob->setCache($injector->getInstance('Horde_Cache'));
+ $ob->setCache($injector->get('Horde_Cache'));
} catch (Throwable) {
}
try {
- $ob->setLogger($injector->getInstance('Horde_Log_Logger'));
+ $ob->setLogger($injector->get('Horde_Log_Logger'));
} catch (Throwable) {
}
diff --git a/src/Factory/DbServiceFactory.php b/src/Factory/DbServiceFactory.php
index be2dfb37..257e17cc 100644
--- a/src/Factory/DbServiceFactory.php
+++ b/src/Factory/DbServiceFactory.php
@@ -60,7 +60,7 @@ class DbServiceFactory
*/
public function create(Injector $injector, string $serviceId = 'horde'): StandardHordeDbService
{
- $loader = $injector->getInstance(ConfigLoader::class);
+ $loader = $injector->get(ConfigLoader::class);
$state = $loader->load('horde');
// Resolve config for this service
diff --git a/src/Factory/ErrorFilterFactory.php b/src/Factory/ErrorFilterFactory.php
index 40aa81fd..53075915 100644
--- a/src/Factory/ErrorFilterFactory.php
+++ b/src/Factory/ErrorFilterFactory.php
@@ -29,7 +29,7 @@ public function create(Injector $injector): ErrorFilter
{
$admins = [];
try {
- $configLoader = $injector->getInstance(ConfigLoader::class);
+ $configLoader = $injector->get(ConfigLoader::class);
$conf = $configLoader->load('horde', 'conf.php');
$admins = $conf->get('auth.admins', []);
if (!is_array($admins)) {
diff --git a/src/Factory/EventDispatcherFactory.php b/src/Factory/EventDispatcherFactory.php
index ace5831b..b3a4f9b9 100644
--- a/src/Factory/EventDispatcherFactory.php
+++ b/src/Factory/EventDispatcherFactory.php
@@ -58,7 +58,7 @@ public function create(Injector $injector): EventDispatcher
$provider = $this->createListenerProvider($injector);
try {
- $logger = $injector->getInstance(LoggerInterface::class);
+ $logger = $injector->get(LoggerInterface::class);
} catch (Throwable) {
$logger = new NullLogger();
}
diff --git a/src/Factory/GraphicDiscovererFactory.php b/src/Factory/GraphicDiscovererFactory.php
index a2b42f8d..18af16a9 100644
--- a/src/Factory/GraphicDiscovererFactory.php
+++ b/src/Factory/GraphicDiscovererFactory.php
@@ -27,9 +27,9 @@ class GraphicDiscovererFactory
{
public function create(Injector $injector): GraphicDiscoverer
{
- $pathBuilder = $injector->getInstance(PathBuilderInterface::class);
- $uriBuilder = $injector->getInstance(UriBuilderInterface::class);
- $filesystem = $injector->getInstance(AssetFilesystem::class);
+ $pathBuilder = $injector->get(PathBuilderInterface::class);
+ $uriBuilder = $injector->get(UriBuilderInterface::class);
+ $filesystem = $injector->get(AssetFilesystem::class);
return new CascadeGraphicDiscoverer($pathBuilder, $uriBuilder, $filesystem);
}
diff --git a/src/Factory/GroupServiceFactory.php b/src/Factory/GroupServiceFactory.php
index 239081fa..472299d8 100644
--- a/src/Factory/GroupServiceFactory.php
+++ b/src/Factory/GroupServiceFactory.php
@@ -55,7 +55,7 @@ class GroupServiceFactory
*/
public function create(Injector $injector): GroupService
{
- $loader = $injector->getInstance(ConfigLoader::class);
+ $loader = $injector->get(ConfigLoader::class);
$state = $loader->load('horde');
$driver = strtolower($state->get('group.driver', 'sql'));
@@ -63,7 +63,7 @@ public function create(Injector $injector): GroupService
return match ($driver) {
'sql' => $this->createSqlBackend($injector, $params),
- 'ldap' => $injector->getInstance(LdapGroupServiceFactory::class)->create($injector),
+ 'ldap' => $injector->get(LdapGroupServiceFactory::class)->create($injector),
default => throw new RuntimeException(
"Unsupported group driver: {$driver}. "
. "Modern GroupService currently supports 'sql' and 'ldap'. "
@@ -95,7 +95,7 @@ private function createSqlBackend(
Injector $injector,
array $params,
): SqlGroupService {
- $dbFactory = $injector->getInstance(DbServiceFactory::class);
+ $dbFactory = $injector->get(DbServiceFactory::class);
$dbService = $dbFactory->create($injector, 'horde:group');
$backend = new Horde_Group_Sql([
diff --git a/src/Factory/HordeLdapServiceFactory.php b/src/Factory/HordeLdapServiceFactory.php
index 4cf628f5..5d76f9c9 100644
--- a/src/Factory/HordeLdapServiceFactory.php
+++ b/src/Factory/HordeLdapServiceFactory.php
@@ -57,7 +57,7 @@ class HordeLdapServiceFactory
*/
public function create(Injector $injector, string $serviceId = 'horde'): StandardHordeLdapService
{
- $loader = $injector->getInstance(ConfigLoader::class);
+ $loader = $injector->get(ConfigLoader::class);
// Parse service ID: 'horde' or 'horde:groups'
[$app, $service] = $this->parseServiceId($serviceId);
@@ -110,7 +110,7 @@ protected function createAdapter(array $ldapConfig, Injector $injector): Horde_L
{
// Add optional cache if available
try {
- $cache = $injector->getInstance('Horde_Cache');
+ $cache = $injector->get('Horde_Cache');
if ($cache instanceof Horde_Cache) {
$ldapConfig['cache'] = $cache;
$ldapConfig['cache_root_dse'] = true;
diff --git a/src/Factory/HttpClientFactory.php b/src/Factory/HttpClientFactory.php
index 687fc532..122cdfba 100644
--- a/src/Factory/HttpClientFactory.php
+++ b/src/Factory/HttpClientFactory.php
@@ -47,8 +47,8 @@ public function create(Injector $injector): ClientInterface
{
$state = $this->loadConfig($injector);
$options = $this->buildOptions($state);
- $responseFactory = $injector->getInstance(ResponseFactoryInterface::class);
- $streamFactory = $injector->getInstance(StreamFactoryInterface::class);
+ $responseFactory = $injector->get(ResponseFactoryInterface::class);
+ $streamFactory = $injector->get(StreamFactoryInterface::class);
if (extension_loaded('curl')) {
return new Curl($responseFactory, $streamFactory, $options);
@@ -59,7 +59,7 @@ public function create(Injector $injector): ClientInterface
private function loadConfig(Injector $injector): State
{
- $loader = $injector->getInstance(ConfigLoader::class);
+ $loader = $injector->get(ConfigLoader::class);
return $loader->load('horde');
}
diff --git a/src/Factory/IdentityHistoryRepositoryFactory.php b/src/Factory/IdentityHistoryRepositoryFactory.php
index 2f2421ec..0bf12fcd 100644
--- a/src/Factory/IdentityHistoryRepositoryFactory.php
+++ b/src/Factory/IdentityHistoryRepositoryFactory.php
@@ -34,7 +34,7 @@ public function create(Injector $injector): IdentityHistoryRepository
{
if (class_exists(SqlIdentityHistoryRepository::class)) {
try {
- $db = $injector->getInstance(Adapter::class);
+ $db = $injector->get(Adapter::class);
return new SqlIdentityHistoryRepository($db);
} catch (Throwable) {
return new InMemoryIdentityHistoryRepository();
diff --git a/src/Factory/IdentityRepositoryFactory.php b/src/Factory/IdentityRepositoryFactory.php
index 96bb639b..c76b597e 100644
--- a/src/Factory/IdentityRepositoryFactory.php
+++ b/src/Factory/IdentityRepositoryFactory.php
@@ -34,7 +34,7 @@ public function create(Injector $injector): IdentityRepository
{
if (class_exists(SqlIdentityRepository::class)) {
try {
- $db = $injector->getInstance(Adapter::class);
+ $db = $injector->get(Adapter::class);
return new SqlIdentityRepository($db);
} catch (Throwable) {
return new InMemoryIdentityRepository();
diff --git a/src/Factory/IdentityServiceFactory.php b/src/Factory/IdentityServiceFactory.php
index c9e85cbc..add70360 100644
--- a/src/Factory/IdentityServiceFactory.php
+++ b/src/Factory/IdentityServiceFactory.php
@@ -40,7 +40,7 @@ class IdentityServiceFactory
*/
public function create(Injector $injector): IdentityService
{
- $prefsService = $injector->getInstance(PrefsService::class);
+ $prefsService = $injector->get(PrefsService::class);
return new IdentityService($prefsService);
}
}
diff --git a/src/Factory/JsDiscovererFactory.php b/src/Factory/JsDiscovererFactory.php
index d0ae9a3b..fbe72b1f 100644
--- a/src/Factory/JsDiscovererFactory.php
+++ b/src/Factory/JsDiscovererFactory.php
@@ -28,10 +28,10 @@ class JsDiscovererFactory
{
public function create(Injector $injector): JsDiscoverer
{
- $pathBuilder = $injector->getInstance(PathBuilderInterface::class);
- $uriBuilder = $injector->getInstance(UriBuilderInterface::class);
- $filesystem = $injector->getInstance(AssetFilesystem::class);
- $themeInfo = $injector->getInstance(ThemeInfoReader::class);
+ $pathBuilder = $injector->get(PathBuilderInterface::class);
+ $uriBuilder = $injector->get(UriBuilderInterface::class);
+ $filesystem = $injector->get(AssetFilesystem::class);
+ $themeInfo = $injector->get(ThemeInfoReader::class);
return new ThemeJsDiscoverer($pathBuilder, $uriBuilder, $filesystem, $themeInfo);
}
diff --git a/src/Factory/LdapGroupServiceFactory.php b/src/Factory/LdapGroupServiceFactory.php
index 87f74900..6e9556ff 100644
--- a/src/Factory/LdapGroupServiceFactory.php
+++ b/src/Factory/LdapGroupServiceFactory.php
@@ -40,13 +40,13 @@ class LdapGroupServiceFactory
*/
public function create(Injector $injector): LdapGroupService
{
- $loader = $injector->getInstance(ConfigLoader::class);
+ $loader = $injector->get(ConfigLoader::class);
$config = $loader->load('horde');
// Resolve the LDAP connection for the 'groups' service specifically:
// falls back to the default 'ldap' config if 'ldap.service.groups'
// isn't set (see HordeLdapServiceFactory::resolveConfig()).
- $ldapFactory = $injector->getInstance(HordeLdapServiceFactory::class);
+ $ldapFactory = $injector->get(HordeLdapServiceFactory::class);
$ldapService = $ldapFactory->create($injector, 'horde:groups');
// Get group configuration (legacy conf.php key is singular: 'group', not 'groups')
diff --git a/src/Factory/LdapPrefsServiceFactory.php b/src/Factory/LdapPrefsServiceFactory.php
index b212c51b..af7c0d68 100644
--- a/src/Factory/LdapPrefsServiceFactory.php
+++ b/src/Factory/LdapPrefsServiceFactory.php
@@ -41,11 +41,11 @@ class LdapPrefsServiceFactory
*/
public function create(Injector $injector): LdapPrefsService
{
- $loader = $injector->getInstance(ConfigLoader::class);
+ $loader = $injector->get(ConfigLoader::class);
$config = $loader->load('horde');
// Get LDAP service (may use service-specific connection)
- $ldapService = $injector->getInstance(HordeLdapService::class);
+ $ldapService = $injector->get(HordeLdapService::class);
// Get prefs configuration
$params = $config->get('prefs.params', []);
diff --git a/src/Factory/OAuthAccessTokenIssuerFactory.php b/src/Factory/OAuthAccessTokenIssuerFactory.php
index 7ec839d0..9f3787b6 100644
--- a/src/Factory/OAuthAccessTokenIssuerFactory.php
+++ b/src/Factory/OAuthAccessTokenIssuerFactory.php
@@ -32,9 +32,9 @@ public function create(Injector $injector): AccessTokenIssuer
$ttl = (int) ($oauthConf['access_token_ttl'] ?? 3600);
return new AccessTokenIssuer(
- $injector->getInstance(TokenEncoder::class),
- $injector->getInstance(Rs256Signer::class),
- $injector->getInstance(AccessTokenRepository::class),
+ $injector->get(TokenEncoder::class),
+ $injector->get(Rs256Signer::class),
+ $injector->get(AccessTokenRepository::class),
$issuer,
$ttl,
);
diff --git a/src/Factory/OAuthAccessTokenRepositoryFactory.php b/src/Factory/OAuthAccessTokenRepositoryFactory.php
index 95948dbe..e9326c66 100644
--- a/src/Factory/OAuthAccessTokenRepositoryFactory.php
+++ b/src/Factory/OAuthAccessTokenRepositoryFactory.php
@@ -29,7 +29,7 @@ public function create(Injector $injector): AccessTokenRepository
{
if (class_exists(SqlOAuthAccessTokenRepository::class)) {
try {
- $db = $injector->getInstance(Adapter::class);
+ $db = $injector->get(Adapter::class);
return new SqlOAuthAccessTokenRepository($db);
} catch (Throwable) {
return new InMemoryAccessTokenRepository();
diff --git a/src/Factory/OAuthAuthorizationCodeGrantFactory.php b/src/Factory/OAuthAuthorizationCodeGrantFactory.php
index 85594a1e..8db1e327 100644
--- a/src/Factory/OAuthAuthorizationCodeGrantFactory.php
+++ b/src/Factory/OAuthAuthorizationCodeGrantFactory.php
@@ -28,10 +28,10 @@ class OAuthAuthorizationCodeGrantFactory
public function create(Injector $injector): AuthorizationCodeGrant
{
return new AuthorizationCodeGrant(
- $injector->getInstance(AuthorizationCodeRepository::class),
- $injector->getInstance(AccessTokenIssuer::class),
- $injector->getInstance(RefreshTokenIssuer::class),
- $injector->getInstance(ScopeRepository::class),
+ $injector->get(AuthorizationCodeRepository::class),
+ $injector->get(AccessTokenIssuer::class),
+ $injector->get(RefreshTokenIssuer::class),
+ $injector->get(ScopeRepository::class),
);
}
}
diff --git a/src/Factory/OAuthAuthorizationCodeRepositoryFactory.php b/src/Factory/OAuthAuthorizationCodeRepositoryFactory.php
index 82e696b4..ed0e85e4 100644
--- a/src/Factory/OAuthAuthorizationCodeRepositoryFactory.php
+++ b/src/Factory/OAuthAuthorizationCodeRepositoryFactory.php
@@ -29,7 +29,7 @@ public function create(Injector $injector): AuthorizationCodeRepository
{
if (class_exists(SqlOAuthAuthorizationCodeRepository::class)) {
try {
- $db = $injector->getInstance(Adapter::class);
+ $db = $injector->get(Adapter::class);
return new SqlOAuthAuthorizationCodeRepository($db);
} catch (Throwable) {
return new InMemoryAuthorizationCodeRepository();
diff --git a/src/Factory/OAuthAuthorizationEndpointFactory.php b/src/Factory/OAuthAuthorizationEndpointFactory.php
index dba5ecc0..87e67b66 100644
--- a/src/Factory/OAuthAuthorizationEndpointFactory.php
+++ b/src/Factory/OAuthAuthorizationEndpointFactory.php
@@ -29,11 +29,11 @@ class OAuthAuthorizationEndpointFactory
public function create(Injector $injector): AuthorizationEndpoint
{
return new AuthorizationEndpoint(
- $injector->getInstance(ClientRepository::class),
- $injector->getInstance(ScopeRepository::class),
- $injector->getInstance(AuthorizationCodeRepository::class),
- $injector->getInstance(ResponseFactoryInterface::class),
- $injector->getInstance(StreamFactoryInterface::class),
+ $injector->get(ClientRepository::class),
+ $injector->get(ScopeRepository::class),
+ $injector->get(AuthorizationCodeRepository::class),
+ $injector->get(ResponseFactoryInterface::class),
+ $injector->get(StreamFactoryInterface::class),
);
}
}
diff --git a/src/Factory/OAuthClientAuthenticatorFactory.php b/src/Factory/OAuthClientAuthenticatorFactory.php
index 0650f7ec..96105252 100644
--- a/src/Factory/OAuthClientAuthenticatorFactory.php
+++ b/src/Factory/OAuthClientAuthenticatorFactory.php
@@ -27,7 +27,7 @@ class OAuthClientAuthenticatorFactory
public function create(Injector $injector): ClientAuthenticatorChain
{
return new ClientAuthenticatorChain(
- $injector->getInstance(ClientRepository::class),
+ $injector->get(ClientRepository::class),
new ClientSecretBasic(),
new ClientSecretPost(),
);
diff --git a/src/Factory/OAuthClientCredentialsGrantFactory.php b/src/Factory/OAuthClientCredentialsGrantFactory.php
index e0a1e388..4e50c597 100644
--- a/src/Factory/OAuthClientCredentialsGrantFactory.php
+++ b/src/Factory/OAuthClientCredentialsGrantFactory.php
@@ -26,8 +26,8 @@ class OAuthClientCredentialsGrantFactory
public function create(Injector $injector): ClientCredentialsGrant
{
return new ClientCredentialsGrant(
- $injector->getInstance(AccessTokenIssuer::class),
- $injector->getInstance(ScopeRepository::class),
+ $injector->get(AccessTokenIssuer::class),
+ $injector->get(ScopeRepository::class),
);
}
}
diff --git a/src/Factory/OAuthClientRepositoryFactory.php b/src/Factory/OAuthClientRepositoryFactory.php
index b69a6aa3..4c88cc10 100644
--- a/src/Factory/OAuthClientRepositoryFactory.php
+++ b/src/Factory/OAuthClientRepositoryFactory.php
@@ -29,7 +29,7 @@ public function create(Injector $injector): ClientRepository
{
if (class_exists(SqlOAuthClientRepository::class)) {
try {
- $db = $injector->getInstance(Adapter::class);
+ $db = $injector->get(Adapter::class);
return new SqlOAuthClientRepository($db);
} catch (Throwable) {
return new InMemoryClientRepository();
diff --git a/src/Factory/OAuthConsentMiddlewareFactory.php b/src/Factory/OAuthConsentMiddlewareFactory.php
index ec2700a3..0c01cad3 100644
--- a/src/Factory/OAuthConsentMiddlewareFactory.php
+++ b/src/Factory/OAuthConsentMiddlewareFactory.php
@@ -31,13 +31,13 @@ class OAuthConsentMiddlewareFactory
public function create(Injector $injector): OAuthConsentMiddleware
{
return new OAuthConsentMiddleware(
- $injector->getInstance(AuthorizationEndpoint::class),
- $injector->getInstance(ConsentRepository::class),
- $injector->getInstance(SessionAccess::class),
- $injector->getInstance(Horde_PageOutput::class),
- $injector->getInstance(Horde_Notification_Handler::class),
- $injector->getInstance(ResponseFactoryInterface::class),
- $injector->getInstance(StreamFactoryInterface::class),
+ $injector->get(AuthorizationEndpoint::class),
+ $injector->get(ConsentRepository::class),
+ $injector->get(SessionAccess::class),
+ $injector->get(Horde_PageOutput::class),
+ $injector->get(Horde_Notification_Handler::class),
+ $injector->get(ResponseFactoryInterface::class),
+ $injector->get(StreamFactoryInterface::class),
);
}
}
diff --git a/src/Factory/OAuthConsentRepositoryFactory.php b/src/Factory/OAuthConsentRepositoryFactory.php
index 1bac0bfc..892f40cb 100644
--- a/src/Factory/OAuthConsentRepositoryFactory.php
+++ b/src/Factory/OAuthConsentRepositoryFactory.php
@@ -29,7 +29,7 @@ public function create(Injector $injector): ConsentRepository
{
if (class_exists(SqlOAuthConsentRepository::class)) {
try {
- $db = $injector->getInstance(Adapter::class);
+ $db = $injector->get(Adapter::class);
return new SqlOAuthConsentRepository($db);
} catch (Throwable) {
return new InMemoryConsentRepository();
diff --git a/src/Factory/OAuthDiscoveryEndpointFactory.php b/src/Factory/OAuthDiscoveryEndpointFactory.php
index 2b06e5de..ed2d27fb 100644
--- a/src/Factory/OAuthDiscoveryEndpointFactory.php
+++ b/src/Factory/OAuthDiscoveryEndpointFactory.php
@@ -27,9 +27,9 @@ class OAuthDiscoveryEndpointFactory
public function create(Injector $injector): DiscoveryEndpoint
{
return new DiscoveryEndpoint(
- $injector->getInstance(ServerMetadata::class),
- $injector->getInstance(ResponseFactoryInterface::class),
- $injector->getInstance(StreamFactoryInterface::class),
+ $injector->get(ServerMetadata::class),
+ $injector->get(ResponseFactoryInterface::class),
+ $injector->get(StreamFactoryInterface::class),
);
}
}
diff --git a/src/Factory/OAuthFlowStoreFactory.php b/src/Factory/OAuthFlowStoreFactory.php
index 76607e3b..366eddb8 100644
--- a/src/Factory/OAuthFlowStoreFactory.php
+++ b/src/Factory/OAuthFlowStoreFactory.php
@@ -28,7 +28,7 @@ class OAuthFlowStoreFactory
{
public function create(Injector $injector): OAuthFlowStore
{
- $loader = $injector->getInstance(ConfigLoader::class);
+ $loader = $injector->get(ConfigLoader::class);
$state = $loader->load('horde');
$driver = strtolower((string) $state->get('oauth_login.flow_store_driver', 'File'));
@@ -50,7 +50,7 @@ private function createFileStore(array $params): FileOAuthFlowStore
private function createSqlStore(Injector $injector, array $params): SqlOAuthFlowStore
{
- $dbService = $injector->getInstance(HordeDbService::class);
+ $dbService = $injector->get(HordeDbService::class);
$table = !empty($params['table']) ? $params['table'] : 'horde_oauth_flows';
return new SqlOAuthFlowStore($dbService->getAdapter(), $table);
diff --git a/src/Factory/OAuthIdTokenBuilderFactory.php b/src/Factory/OAuthIdTokenBuilderFactory.php
index beb0f0cb..5fe42926 100644
--- a/src/Factory/OAuthIdTokenBuilderFactory.php
+++ b/src/Factory/OAuthIdTokenBuilderFactory.php
@@ -33,10 +33,10 @@ public function create(Injector $injector): IdTokenBuilder
$ttl = (int) ($oauthConf['access_token_ttl'] ?? 3600);
return new IdTokenBuilder(
- $injector->getInstance(TokenEncoder::class),
- $injector->getInstance(Rs256Signer::class),
- $injector->getInstance(ClaimsMapper::class),
- $injector->getInstance(ScopeClaimsMapping::class),
+ $injector->get(TokenEncoder::class),
+ $injector->get(Rs256Signer::class),
+ $injector->get(ClaimsMapper::class),
+ $injector->get(ScopeClaimsMapping::class),
$issuer,
$ttl,
);
diff --git a/src/Factory/OAuthIntrospectionEndpointFactory.php b/src/Factory/OAuthIntrospectionEndpointFactory.php
index 4d367764..a216f777 100644
--- a/src/Factory/OAuthIntrospectionEndpointFactory.php
+++ b/src/Factory/OAuthIntrospectionEndpointFactory.php
@@ -29,11 +29,11 @@ class OAuthIntrospectionEndpointFactory
public function create(Injector $injector): IntrospectionEndpoint
{
return new IntrospectionEndpoint(
- $injector->getInstance(ClientAuthenticatorChain::class),
- $injector->getInstance(AccessTokenRepository::class),
- $injector->getInstance(RefreshTokenRepository::class),
- $injector->getInstance(ResponseFactoryInterface::class),
- $injector->getInstance(StreamFactoryInterface::class),
+ $injector->get(ClientAuthenticatorChain::class),
+ $injector->get(AccessTokenRepository::class),
+ $injector->get(RefreshTokenRepository::class),
+ $injector->get(ResponseFactoryInterface::class),
+ $injector->get(StreamFactoryInterface::class),
);
}
}
diff --git a/src/Factory/OAuthJwksEndpointFactory.php b/src/Factory/OAuthJwksEndpointFactory.php
index 602eea86..8196002b 100644
--- a/src/Factory/OAuthJwksEndpointFactory.php
+++ b/src/Factory/OAuthJwksEndpointFactory.php
@@ -30,9 +30,9 @@ public function create(Injector $injector): JwksEndpoint
$oauthConf = $conf['oauth_server'] ?? [];
return new JwksEndpoint(
- $injector->getInstance(PublicKey::class),
- $injector->getInstance(ResponseFactoryInterface::class),
- $injector->getInstance(StreamFactoryInterface::class),
+ $injector->get(PublicKey::class),
+ $injector->get(ResponseFactoryInterface::class),
+ $injector->get(StreamFactoryInterface::class),
$oauthConf['key_id'] ?? 'horde-1',
'RS256',
);
diff --git a/src/Factory/OAuthProviderConfigRepositoryFactory.php b/src/Factory/OAuthProviderConfigRepositoryFactory.php
index 5022c3e8..d32e9095 100644
--- a/src/Factory/OAuthProviderConfigRepositoryFactory.php
+++ b/src/Factory/OAuthProviderConfigRepositoryFactory.php
@@ -42,13 +42,13 @@ public function create(Injector $injector): OAuthProviderConfigRepository
{
if (class_exists(SqlOAuthProviderConfigRepository::class)) {
try {
- $db = $injector->getInstance(Adapter::class);
+ $db = $injector->get(Adapter::class);
} catch (Throwable) {
return new NullOAuthProviderConfigRepository();
}
try {
- $secret = $injector->getInstance(SecretManager::class);
+ $secret = $injector->get(SecretManager::class);
} catch (Throwable) {
$secret = null;
}
diff --git a/src/Factory/OAuthRefreshTokenGrantFactory.php b/src/Factory/OAuthRefreshTokenGrantFactory.php
index 94a9b4df..0a6ca164 100644
--- a/src/Factory/OAuthRefreshTokenGrantFactory.php
+++ b/src/Factory/OAuthRefreshTokenGrantFactory.php
@@ -29,11 +29,11 @@ class OAuthRefreshTokenGrantFactory
public function create(Injector $injector): RefreshTokenGrant
{
return new RefreshTokenGrant(
- $injector->getInstance(RefreshTokenRepository::class),
- $injector->getInstance(AccessTokenRepository::class),
- $injector->getInstance(AccessTokenIssuer::class),
- $injector->getInstance(RefreshTokenIssuer::class),
- $injector->getInstance(ScopeRepository::class),
+ $injector->get(RefreshTokenRepository::class),
+ $injector->get(AccessTokenRepository::class),
+ $injector->get(AccessTokenIssuer::class),
+ $injector->get(RefreshTokenIssuer::class),
+ $injector->get(ScopeRepository::class),
);
}
}
diff --git a/src/Factory/OAuthRefreshTokenIssuerFactory.php b/src/Factory/OAuthRefreshTokenIssuerFactory.php
index f27cda46..7baac8ab 100644
--- a/src/Factory/OAuthRefreshTokenIssuerFactory.php
+++ b/src/Factory/OAuthRefreshTokenIssuerFactory.php
@@ -29,7 +29,7 @@ public function create(Injector $injector): RefreshTokenIssuer
$ttl = (int) ($oauthConf['refresh_token_ttl'] ?? 2592000);
return new RefreshTokenIssuer(
- $injector->getInstance(RefreshTokenRepository::class),
+ $injector->get(RefreshTokenRepository::class),
$ttl,
);
}
diff --git a/src/Factory/OAuthRefreshTokenRepositoryFactory.php b/src/Factory/OAuthRefreshTokenRepositoryFactory.php
index 0ac5cdde..a6870b3a 100644
--- a/src/Factory/OAuthRefreshTokenRepositoryFactory.php
+++ b/src/Factory/OAuthRefreshTokenRepositoryFactory.php
@@ -29,7 +29,7 @@ public function create(Injector $injector): RefreshTokenRepository
{
if (class_exists(SqlOAuthRefreshTokenRepository::class)) {
try {
- $db = $injector->getInstance(Adapter::class);
+ $db = $injector->get(Adapter::class);
return new SqlOAuthRefreshTokenRepository($db);
} catch (Throwable) {
return new InMemoryRefreshTokenRepository();
diff --git a/src/Factory/OAuthRevocationEndpointFactory.php b/src/Factory/OAuthRevocationEndpointFactory.php
index 2edece7e..382db672 100644
--- a/src/Factory/OAuthRevocationEndpointFactory.php
+++ b/src/Factory/OAuthRevocationEndpointFactory.php
@@ -29,11 +29,11 @@ class OAuthRevocationEndpointFactory
public function create(Injector $injector): RevocationEndpoint
{
return new RevocationEndpoint(
- $injector->getInstance(ClientAuthenticatorChain::class),
- $injector->getInstance(AccessTokenRepository::class),
- $injector->getInstance(RefreshTokenRepository::class),
- $injector->getInstance(ResponseFactoryInterface::class),
- $injector->getInstance(StreamFactoryInterface::class),
+ $injector->get(ClientAuthenticatorChain::class),
+ $injector->get(AccessTokenRepository::class),
+ $injector->get(RefreshTokenRepository::class),
+ $injector->get(ResponseFactoryInterface::class),
+ $injector->get(StreamFactoryInterface::class),
);
}
}
diff --git a/src/Factory/OAuthScopeRepositoryFactory.php b/src/Factory/OAuthScopeRepositoryFactory.php
index 65aedd46..7ef9845d 100644
--- a/src/Factory/OAuthScopeRepositoryFactory.php
+++ b/src/Factory/OAuthScopeRepositoryFactory.php
@@ -29,7 +29,7 @@ public function create(Injector $injector): ScopeRepository
{
if (class_exists(SqlOAuthScopeRepository::class)) {
try {
- $db = $injector->getInstance(Adapter::class);
+ $db = $injector->get(Adapter::class);
return new SqlOAuthScopeRepository($db);
} catch (Throwable) {
return new InMemoryScopeRepository();
diff --git a/src/Factory/OAuthTokenEndpointFactory.php b/src/Factory/OAuthTokenEndpointFactory.php
index 4b0b9156..dff2d7a4 100644
--- a/src/Factory/OAuthTokenEndpointFactory.php
+++ b/src/Factory/OAuthTokenEndpointFactory.php
@@ -30,12 +30,12 @@ class OAuthTokenEndpointFactory
public function create(Injector $injector): TokenEndpoint
{
return new TokenEndpoint(
- $injector->getInstance(ClientAuthenticatorChain::class),
- $injector->getInstance(ResponseFactoryInterface::class),
- $injector->getInstance(StreamFactoryInterface::class),
- $injector->getInstance(AuthorizationCodeGrant::class),
- $injector->getInstance(ClientCredentialsGrant::class),
- $injector->getInstance(RefreshTokenGrant::class),
+ $injector->get(ClientAuthenticatorChain::class),
+ $injector->get(ResponseFactoryInterface::class),
+ $injector->get(StreamFactoryInterface::class),
+ $injector->get(AuthorizationCodeGrant::class),
+ $injector->get(ClientCredentialsGrant::class),
+ $injector->get(RefreshTokenGrant::class),
);
}
}
diff --git a/src/Factory/OAuthTokenRepositoryFactory.php b/src/Factory/OAuthTokenRepositoryFactory.php
index b584a90f..7d715c34 100644
--- a/src/Factory/OAuthTokenRepositoryFactory.php
+++ b/src/Factory/OAuthTokenRepositoryFactory.php
@@ -36,7 +36,7 @@ class OAuthTokenRepositoryFactory
{
public function create(Injector $injector): OAuthTokenRepository
{
- $loader = $injector->getInstance(ConfigLoader::class);
+ $loader = $injector->get(ConfigLoader::class);
$state = $loader->load('horde');
$driver = $state->get('oauth.token_driver', 'null');
diff --git a/src/Factory/OAuthUserinfoEndpointFactory.php b/src/Factory/OAuthUserinfoEndpointFactory.php
index ebed7265..a398970e 100644
--- a/src/Factory/OAuthUserinfoEndpointFactory.php
+++ b/src/Factory/OAuthUserinfoEndpointFactory.php
@@ -28,10 +28,10 @@ class OAuthUserinfoEndpointFactory
public function create(Injector $injector): UserinfoEndpoint
{
return new UserinfoEndpoint(
- $injector->getInstance(ClaimsMapper::class),
- $injector->getInstance(ScopeClaimsMapping::class),
- $injector->getInstance(ResponseFactoryInterface::class),
- $injector->getInstance(StreamFactoryInterface::class),
+ $injector->get(ClaimsMapper::class),
+ $injector->get(ScopeClaimsMapping::class),
+ $injector->get(ResponseFactoryInterface::class),
+ $injector->get(StreamFactoryInterface::class),
);
}
}
diff --git a/src/Factory/PathBuilderFactory.php b/src/Factory/PathBuilderFactory.php
index 63b10e61..1028fdf1 100644
--- a/src/Factory/PathBuilderFactory.php
+++ b/src/Factory/PathBuilderFactory.php
@@ -25,7 +25,7 @@ class PathBuilderFactory
{
public function create(Injector $injector): PathBuilderInterface
{
- $registryLoader = $injector->getInstance(RegistryConfigLoader::class);
+ $registryLoader = $injector->get(RegistryConfigLoader::class);
$registryState = $registryLoader->load();
return new PathBuilder($registryState);
diff --git a/src/Factory/PermissionServiceFactory.php b/src/Factory/PermissionServiceFactory.php
index 7a9024cf..bac6e189 100644
--- a/src/Factory/PermissionServiceFactory.php
+++ b/src/Factory/PermissionServiceFactory.php
@@ -53,7 +53,7 @@ class PermissionServiceFactory
*/
public function create(Injector $injector): PermissionService
{
- $loader = $injector->getInstance(ConfigLoader::class);
+ $loader = $injector->get(ConfigLoader::class);
$state = $loader->load('horde');
$driver = strtolower($state->get('perms.driver', 'null'));
@@ -82,10 +82,10 @@ private function createSqlBackend(
array $params
): SqlPermissionService {
// Get database connection via DbServiceFactory with pooling
- $dbFactory = $injector->getInstance(DbServiceFactory::class);
+ $dbFactory = $injector->get(DbServiceFactory::class);
$dbService = $dbFactory->create($injector, 'horde:perms');
- $groupService = $injector->getInstance(GroupService::class);
+ $groupService = $injector->get(GroupService::class);
// Create legacy Horde_Perms_Sql backend. Horde_Perms_Sql calls
// $this->_cache->get() unconditionally in getPermission() and
diff --git a/src/Factory/PermsUi.php b/src/Factory/PermsUi.php
index f6a4bbce..960caf83 100644
--- a/src/Factory/PermsUi.php
+++ b/src/Factory/PermsUi.php
@@ -28,6 +28,7 @@
use Horde_Perms_Base;
use Horde_Registry;
use Psr\Http\Message\ServerRequestInterface;
+use Horde_Core_Factory_Auth;
/**
* Factory selecting the administrative permission UI implementation.
@@ -79,10 +80,10 @@ private function createWithDenies(
$templatePath = $this->resolveTemplatePath($injector);
$groups = $this->resolveGroups($injector);
$auth = $this->resolveAuth($injector);
- $request = $injector->getInstance(ServerRequestInterface::class);
- $tokens = $injector->getInstance(Token::class);
- $uriBuilder = $injector->getInstance(UriBuilderInterface::class);
- $registry = $injector->getInstance(Horde_Registry::class);
+ $request = $injector->get(ServerRequestInterface::class);
+ $tokens = $injector->get(Token::class);
+ $uriBuilder = $injector->get(UriBuilderInterface::class);
+ $registry = $injector->get(Horde_Registry::class);
$notification = $this->resolveNotification($injector);
return new NegativeUi(
@@ -108,7 +109,7 @@ private function createWithDenies(
private function resolveNotification(Injector $injector): ?\Horde_Notification_Handler
{
try {
- $handler = $injector->getInstance('Horde_Notification');
+ $handler = $injector->get('Horde_Notification');
return $handler instanceof \Horde_Notification_Handler ? $handler : null;
} catch (\Throwable $e) {
return null;
@@ -122,7 +123,7 @@ private function resolveNotification(Injector $injector): ?\Horde_Notification_H
*/
private function resolveTemplatePath(Injector $injector): string
{
- $registry = $injector->getInstance(Horde_Registry::class);
+ $registry = $injector->get(Horde_Registry::class);
return $registry->get('templates', 'horde') . '/admin/perms';
}
@@ -134,7 +135,7 @@ private function resolveTemplatePath(Injector $injector): string
private function resolveGroups(Injector $injector): ?Horde_Group
{
try {
- $groups = $injector->getInstance(Horde_Group::class);
+ $groups = $injector->get(Horde_Group::class);
return $groups instanceof Horde_Group ? $groups : null;
} catch (\Throwable $e) {
return null;
@@ -149,7 +150,7 @@ private function resolveGroups(Injector $injector): ?Horde_Group
private function resolveAuth(Injector $injector): ?Horde_Auth_Base
{
try {
- $factory = $injector->getInstance('Horde_Core_Factory_Auth');
+ $factory = $injector->get(Horde_Core_Factory_Auth::class);
$auth = $factory->create();
return $auth instanceof Horde_Auth_Base ? $auth : null;
} catch (\Throwable $e) {
@@ -173,7 +174,7 @@ private function resolveAuth(Injector $injector): ?Horde_Auth_Base
private function negativePermissionsEnabled(Injector $injector): bool
{
try {
- $loader = $injector->getInstance(ConfigLoader::class);
+ $loader = $injector->get(ConfigLoader::class);
$state = $loader->load('horde');
$modern = $state->get('perms.negative_permissions', null);
if ($modern !== null) {
diff --git a/src/Factory/PrefsServiceFactory.php b/src/Factory/PrefsServiceFactory.php
index beae3c28..616d188e 100644
--- a/src/Factory/PrefsServiceFactory.php
+++ b/src/Factory/PrefsServiceFactory.php
@@ -93,7 +93,7 @@ class PrefsServiceFactory
*/
public function create(Injector $injector): PrefsService
{
- $loader = $injector->getInstance(ConfigLoader::class);
+ $loader = $injector->get(ConfigLoader::class);
$state = $loader->load('horde');
$driver = $state->get('prefs.driver', 'sql');
@@ -116,7 +116,7 @@ public function create(Injector $injector): PrefsService
private function createSqlBackend(Injector $injector, array $params): SqlPrefsService
{
// Get DB service (supports 'horde:prefs' pattern in future)
- $dbService = $injector->getInstance(HordeDbService::class);
+ $dbService = $injector->get(HordeDbService::class);
$table = $params['table'] ?? 'horde_prefs';
diff --git a/src/Factory/RouteUrlWriterFactory.php b/src/Factory/RouteUrlWriterFactory.php
index b9b8df37..69f49d64 100644
--- a/src/Factory/RouteUrlWriterFactory.php
+++ b/src/Factory/RouteUrlWriterFactory.php
@@ -25,8 +25,8 @@ class RouteUrlWriterFactory
{
public function create(Injector $injector): RouteUrlWriter
{
- $provider = $injector->getInstance(RuntimeRoutesProvider::class);
- $registryState = $injector->getInstance(RegistryConfigLoader::class)->load();
+ $provider = $injector->get(RuntimeRoutesProvider::class);
+ $registryState = $injector->get(RegistryConfigLoader::class)->load();
$hordeConfig = $registryState->getApplication('horde');
$webroot = $hordeConfig['webroot'] ?? '/horde';
diff --git a/src/Factory/RuntimeRoutesProviderFactory.php b/src/Factory/RuntimeRoutesProviderFactory.php
index 45332ae2..2e5b8108 100644
--- a/src/Factory/RuntimeRoutesProviderFactory.php
+++ b/src/Factory/RuntimeRoutesProviderFactory.php
@@ -32,10 +32,10 @@ class RuntimeRoutesProviderFactory
{
public function create(Injector $injector): RuntimeRoutesProvider
{
- $registryState = $injector->getInstance(RegistryConfigLoader::class)->load();
+ $registryState = $injector->get(RegistryConfigLoader::class)->load();
if ($injector->has(ServerRequestInterface::class)) {
- $request = $injector->getInstance(ServerRequestInterface::class);
+ $request = $injector->get(ServerRequestInterface::class);
} else {
$factory = new RequestFactory();
$method = $_SERVER['REQUEST_METHOD'] ?? 'GET';
diff --git a/src/Factory/SecretManagerFactory.php b/src/Factory/SecretManagerFactory.php
index ab3d6d1a..2ac5833d 100644
--- a/src/Factory/SecretManagerFactory.php
+++ b/src/Factory/SecretManagerFactory.php
@@ -35,7 +35,7 @@ class SecretManagerFactory
{
public function create(Injector $injector): SecretManager
{
- $loader = $injector->getInstance(ConfigLoader::class);
+ $loader = $injector->get(ConfigLoader::class);
$state = $loader->load('horde');
$key = $state->get('secret_key', '');
diff --git a/src/Factory/SessionEncryptionCoordinatorFactory.php b/src/Factory/SessionEncryptionCoordinatorFactory.php
index 554d799f..357060a7 100644
--- a/src/Factory/SessionEncryptionCoordinatorFactory.php
+++ b/src/Factory/SessionEncryptionCoordinatorFactory.php
@@ -34,7 +34,7 @@ class SessionEncryptionCoordinatorFactory
{
public function create(Injector $injector): SessionEncryptionCoordinator
{
- $secret = $injector->getInstance(SessionSecret::class);
+ $secret = $injector->get(SessionSecret::class);
return new SessionEncryptionCoordinator($secret);
}
diff --git a/src/Factory/SessionHandlerFactory.php b/src/Factory/SessionHandlerFactory.php
index 8400374e..44d36cc5 100644
--- a/src/Factory/SessionHandlerFactory.php
+++ b/src/Factory/SessionHandlerFactory.php
@@ -62,7 +62,7 @@ class SessionHandlerFactory
*/
public function create(Injector $injector): SessionHandler
{
- $loader = $injector->getInstance(ConfigLoader::class);
+ $loader = $injector->get(ConfigLoader::class);
$state = $loader->load('horde');
$driver = strtolower((string) $state->get('sessionhandler.type', 'builtin'));
@@ -91,7 +91,7 @@ public function create(Injector $injector): SessionHandler
return new SessionHandler(
backend: $backend,
serializer: new DefaultSessionSerializer(),
- sessionFactory: $injector->getInstance(HordeSessionFactory::class),
+ sessionFactory: $injector->get(HordeSessionFactory::class),
events: $this->getEventDispatcher($injector),
);
}
@@ -109,7 +109,7 @@ private function createBuiltinBackend(array $params): BuiltinBackend
*/
private function createSqlBackend(Injector $injector, array $params): SqlBackend
{
- $dbService = $injector->getInstance(HordeDbService::class);
+ $dbService = $injector->get(HordeDbService::class);
$db = $dbService->getAdapter();
$table = $params['table'] ?? 'horde_sessionhandler';
@@ -135,7 +135,7 @@ private function createHashtableBackend(Injector $injector, array $params): Sess
// Prefer modern LockableHashTable if available.
try {
- $modern = $injector->getInstance(LockableHashTable::class);
+ $modern = $injector->get(LockableHashTable::class);
if ($modern instanceof LockableHashTable) {
return new ModernHashtableBackend(
hashTable: $modern,
@@ -147,7 +147,7 @@ private function createHashtableBackend(Injector $injector, array $params): Sess
// Modern interface not bound; fall through to legacy lookup.
}
- $ht = $injector->getInstance('Horde_HashTable');
+ $ht = $injector->get('Horde_HashTable');
if (!$ht instanceof Horde_HashTable_Base || !$ht instanceof Horde_HashTable_Lock) {
throw new RuntimeException(
@@ -198,7 +198,7 @@ public function createSessionFactory(Injector $injector): HordeSessionFactory
$decryptor = null;
try {
- $secret = $injector->getInstance('Horde_Secret_Cbc');
+ $secret = $injector->get('Horde_Secret_Cbc');
if ($secret instanceof SessionSecret) {
$encryptor = static fn(string $plaintext): string => $secret->write($secret->getKey(), $plaintext);
$decryptor = static fn(string $ciphertext): string => $secret->read($secret->getKey(), $ciphertext);
@@ -216,7 +216,7 @@ public function createSessionFactory(Injector $injector): HordeSessionFactory
private function getEventDispatcher(Injector $injector): ?EventDispatcherInterface
{
try {
- $dispatcher = $injector->getInstance(EventDispatcherInterface::class);
+ $dispatcher = $injector->get(EventDispatcherInterface::class);
return $dispatcher instanceof EventDispatcherInterface ? $dispatcher : null;
} catch (Throwable) {
return null;
diff --git a/src/Factory/SessionSecretFactory.php b/src/Factory/SessionSecretFactory.php
index 370b6346..66a0b0a0 100644
--- a/src/Factory/SessionSecretFactory.php
+++ b/src/Factory/SessionSecretFactory.php
@@ -37,7 +37,7 @@ class SessionSecretFactory
{
public function create(Injector $injector): SessionSecret
{
- $resolved = $injector->getInstance('Horde_Secret_Cbc');
+ $resolved = $injector->get('Horde_Secret_Cbc');
if (!$resolved instanceof SessionSecret) {
throw new LogicException(
diff --git a/src/Factory/SimpleCacheFactory.php b/src/Factory/SimpleCacheFactory.php
index de204fa5..46c8a481 100644
--- a/src/Factory/SimpleCacheFactory.php
+++ b/src/Factory/SimpleCacheFactory.php
@@ -66,7 +66,7 @@ public function create(Injector $injector): Cache
private function loadConfig(Injector $injector): State
{
- $loader = $injector->getInstance(ConfigLoader::class);
+ $loader = $injector->get(ConfigLoader::class);
return $loader->load('horde');
}
@@ -85,7 +85,7 @@ private function resolveDriver(State $state): string
private function getLogger(Injector $injector): LoggerInterface
{
try {
- return $injector->getInstance(LoggerInterface::class);
+ return $injector->get(LoggerInterface::class);
} catch (Throwable) {
return new NullLogger();
}
@@ -126,7 +126,7 @@ private function createFileStorage(State $state, LoggerInterface $logger): FileS
private function createSqlStorage(Injector $injector, LoggerInterface $logger): SqlStorage
{
- $db = $injector->getInstance(Horde_Db_Adapter::class);
+ $db = $injector->get(Horde_Db_Adapter::class);
return new SqlStorage(db: $db, logger: $logger);
}
diff --git a/src/Factory/ThemeInfoReaderFactory.php b/src/Factory/ThemeInfoReaderFactory.php
index e2ba96a9..2b0ca15d 100644
--- a/src/Factory/ThemeInfoReaderFactory.php
+++ b/src/Factory/ThemeInfoReaderFactory.php
@@ -27,8 +27,8 @@ class ThemeInfoReaderFactory
public function create(Injector $injector): ThemeInfoReader
{
return new PhpThemeInfoReader(
- $injector->getInstance(PathBuilderInterface::class),
- $injector->getInstance(AssetFilesystem::class),
+ $injector->get(PathBuilderInterface::class),
+ $injector->get(AssetFilesystem::class),
);
}
}
diff --git a/src/Factory/ThemeResolverFactory.php b/src/Factory/ThemeResolverFactory.php
index 91568423..8ce993ae 100644
--- a/src/Factory/ThemeResolverFactory.php
+++ b/src/Factory/ThemeResolverFactory.php
@@ -25,7 +25,7 @@ class ThemeResolverFactory
{
public function create(Injector $injector): ThemeResolver
{
- $prefsService = $injector->getInstance(PrefsService::class);
+ $prefsService = $injector->get(PrefsService::class);
return new PrefsThemeResolver($prefsService);
}
diff --git a/src/Factory/TinymcePageBinderFactory.php b/src/Factory/TinymcePageBinderFactory.php
index a468533f..23de7cc9 100644
--- a/src/Factory/TinymcePageBinderFactory.php
+++ b/src/Factory/TinymcePageBinderFactory.php
@@ -31,7 +31,7 @@ class TinymcePageBinderFactory
public function create(Injector $injector): TinymcePageBinder
{
return new TinymcePageBinder(
- $injector->getInstance(Tinymce::class),
+ $injector->get(Tinymce::class),
);
}
}
diff --git a/src/Factory/TokenServiceFactory.php b/src/Factory/TokenServiceFactory.php
index 395d2b1c..2eab5e37 100644
--- a/src/Factory/TokenServiceFactory.php
+++ b/src/Factory/TokenServiceFactory.php
@@ -88,7 +88,7 @@ public function __construct(
public function create(Injector $injector): Token
{
return $this->createForSession(
- $this->injector->getInstance(HordeSession::class)
+ $this->injector->get(HordeSession::class)
);
}
@@ -169,7 +169,7 @@ public function createFromSecret(string $secret): Token
private function loadState(): State
{
- $loader = $this->injector->getInstance(ConfigLoader::class);
+ $loader = $this->injector->get(ConfigLoader::class);
return $loader->load('horde');
}
@@ -244,7 +244,7 @@ private function getTimeout(): int
*/
private function buildSqlStorage(array $params): SqlStorage
{
- $dbService = $this->injector->getInstance(HordeDbService::class);
+ $dbService = $this->injector->get(HordeDbService::class);
$table = isset($params['table']) && is_string($params['table'])
? $params['table']
: 'horde_tokens';
diff --git a/src/Factory/TranslationManagerFactory.php b/src/Factory/TranslationManagerFactory.php
index c00b502c..72e445bc 100644
--- a/src/Factory/TranslationManagerFactory.php
+++ b/src/Factory/TranslationManagerFactory.php
@@ -45,7 +45,7 @@ class TranslationManagerFactory
public function create(Injector $injector): TranslationManager
{
$manager = new TranslationManager();
- $registry = $injector->getInstance(Horde_Registry::class);
+ $registry = $injector->get(Horde_Registry::class);
foreach ($registry->listAllApps() as $app) {
try {
diff --git a/src/Factory/UriBuilderFactory.php b/src/Factory/UriBuilderFactory.php
index c884b84c..f630cbbf 100644
--- a/src/Factory/UriBuilderFactory.php
+++ b/src/Factory/UriBuilderFactory.php
@@ -29,20 +29,20 @@ class UriBuilderFactory
{
public function create(Injector $injector): UriBuilderInterface
{
- $registryLoader = $injector->getInstance(RegistryConfigLoader::class);
+ $registryLoader = $injector->get(RegistryConfigLoader::class);
$registryState = $registryLoader->load();
- $routeProvider = $injector->getInstance(RouteMapperProvider::class);
+ $routeProvider = $injector->get(RouteMapperProvider::class);
$request = null;
try {
- $request = $injector->getInstance(ServerRequestInterface::class);
+ $request = $injector->get(ServerRequestInterface::class);
} catch (Throwable) {
}
$configState = null;
try {
- $configState = $injector->getInstance(ConfigLoader::class)->load('horde');
+ $configState = $injector->get(ConfigLoader::class)->load('horde');
} catch (Throwable) {
}
diff --git a/src/Factory/VersionServiceFactory.php b/src/Factory/VersionServiceFactory.php
index f624ebdb..3c0cf0dd 100644
--- a/src/Factory/VersionServiceFactory.php
+++ b/src/Factory/VersionServiceFactory.php
@@ -53,7 +53,7 @@ class VersionServiceFactory
*/
public function create(Injector $injector): VersionService
{
- $appService = $injector->getInstance(ApplicationService::class);
+ $appService = $injector->get(ApplicationService::class);
$installed = new HordeYmlInstalledSource($appService);
$available = $this->createAvailableSource($injector);
@@ -74,11 +74,11 @@ public function create(Injector $injector): VersionService
*/
private function createAvailableSource(Injector $injector): AvailableVersionSource
{
- $httpClient = $injector->getInstance(ClientInterface::class);
- $requestFactory = $injector->getInstance(RequestFactoryInterface::class);
+ $httpClient = $injector->get(ClientInterface::class);
+ $requestFactory = $injector->get(RequestFactoryInterface::class);
try {
- $cache = $injector->getInstance(CacheInterface::class);
+ $cache = $injector->get(CacheInterface::class);
} catch (Throwable $e) {
$logger = $this->getLogger($injector);
$logger->warning(
@@ -94,7 +94,7 @@ private function createAvailableSource(Injector $injector): AvailableVersionSour
private function getLogger(Injector $injector): LoggerInterface
{
try {
- return $injector->getInstance(LoggerInterface::class);
+ return $injector->get(LoggerInterface::class);
} catch (Throwable) {
return new NullLogger();
}
diff --git a/src/Horde.php b/src/Horde.php
index 89e07d1c..42d3c759 100644
--- a/src/Horde.php
+++ b/src/Horde.php
@@ -40,6 +40,7 @@
use Exception;
use PEAR_Error;
use Throwable;
+use Horde_PageOutput;
/**
* Provides the base functionality shared by all Horde applications.
@@ -121,7 +122,7 @@ public static function log(
if (isset($GLOBALS['injector'])
&& Horde_Core_Factory_Logger::available()) {
try {
- $logger = $GLOBALS['injector']->getInstance(Logger::class);
+ $logger = $GLOBALS['injector']->get(Logger::class);
self::drainBuffer($logger);
$logger->log($resolvedPriority, $message, $context);
return;
@@ -130,7 +131,7 @@ public static function log(
}
// Legacy fallback.
$log_ob = new Horde_Core_Log_Object($event, $priority, $options);
- $GLOBALS['injector']->getInstance('Horde_Log_Logger')->logObject($log_ob);
+ $GLOBALS['injector']->get('Horde_Log_Logger')->logObject($log_ob);
} else {
// Framework not yet initialized — buffer for later.
self::bufferLog($resolvedPriority, $message, $context);
@@ -917,7 +918,7 @@ public static function linkTooltip(
Horde_Serialize::JSON
);
$title = '';
- $GLOBALS['injector']->getInstance('Horde_PageOutput')
+ $GLOBALS['injector']->get(Horde_PageOutput::class)
->addScriptFile('tooltips.js', 'horde');
}
@@ -1074,7 +1075,7 @@ public static function getTempFile(
}
$tmpfile = Util::getTempFile($prefix, $delete, $dir, $secure);
if ($session_remove) {
- $session = $GLOBALS['injector']->getInstance(HordeSession::class);
+ $session = $GLOBALS['injector']->get(HordeSession::class);
$stored = $session->getScoped('horde', 'gc_tempfiles');
$gcfiles = is_array($stored) ? $stored : [];
$gcfiles[] = $tmpfile;
@@ -1398,7 +1399,7 @@ public static function permissionDeniedError(
?string $error = null,
): void {
try {
- $GLOBALS['injector']->getInstance('Horde_Core_Hooks')
+ $GLOBALS['injector']->get(Horde_Core_Hooks::class)
->callHook('perms_denied', 'horde', [$app, $perm]);
} catch (Horde_Exception_HookNotSet $e) {
}
diff --git a/src/Middleware/AppRouter.php b/src/Middleware/AppRouter.php
index 468fc6f5..15fe0a41 100644
--- a/src/Middleware/AppRouter.php
+++ b/src/Middleware/AppRouter.php
@@ -100,7 +100,7 @@ public function process(ServerRequestInterface $request, RequestHandlerInterface
$controller = null;
if ($controllerName) {
try {
- $controller = $this->injector->getInstance($controllerName);
+ $controller = $this->injector->get($controllerName);
} catch (Exception $e) {
throw new HordeException(
'Defined controller but could not create: ' . $controllerName . ' — ' . $e->getMessage(),
diff --git a/src/Middleware/HordeCore.php b/src/Middleware/HordeCore.php
index fa476de8..e3016085 100644
--- a/src/Middleware/HordeCore.php
+++ b/src/Middleware/HordeCore.php
@@ -62,7 +62,7 @@ public function process(ServerRequestInterface $request, RequestHandlerInterface
$injector->setInstance(ResponseFactoryInterface::class, new ResponseFactory());
}
- $registry = $injector->getInstance('Horde_Registry');
+ $registry = $injector->get(Horde_Registry::class);
$request = $request->withAttribute('registry', $registry);
// Bridge RuntimeRoutesProvider into legacy injector so controllers can use RoutesProvider
@@ -99,7 +99,7 @@ public function process(ServerRequestInterface $request, RequestHandlerInterface
// Resolve controller
if ($controllerName) {
try {
- $controller = $injector->getInstance($controllerName);
+ $controller = $injector->get($controllerName);
} catch (Exception $e) {
throw new HordeException(
'Defined controller but could not create: ' . $controllerName . ' — ' . $e->getMessage(),
diff --git a/src/PageOutput/ChromeRendererDispatcherFactory.php b/src/PageOutput/ChromeRendererDispatcherFactory.php
index a03250da..c65e37d0 100644
--- a/src/PageOutput/ChromeRendererDispatcherFactory.php
+++ b/src/PageOutput/ChromeRendererDispatcherFactory.php
@@ -23,8 +23,8 @@ class ChromeRendererDispatcherFactory
public function create(Injector $injector): ChromeRendererDispatcher
{
return new ChromeRendererDispatcher(
- $injector->getInstance(DesktopChromeRenderer::class),
- $injector->getInstance(ResponsiveChromeRenderer::class),
+ $injector->get(DesktopChromeRenderer::class),
+ $injector->get(ResponsiveChromeRenderer::class),
);
}
}
diff --git a/src/PageOutput/DesktopChromeRendererFactory.php b/src/PageOutput/DesktopChromeRendererFactory.php
index 7d2f50fe..937f8df3 100644
--- a/src/PageOutput/DesktopChromeRendererFactory.php
+++ b/src/PageOutput/DesktopChromeRendererFactory.php
@@ -28,20 +28,20 @@ class DesktopChromeRendererFactory
{
public function create(Injector $injector): DesktopChromeRenderer
{
- $session = $injector->getInstance(SessionAccess::class);
+ $session = $injector->get(SessionAccess::class);
$themeResolver = $injector->get(ThemeResolver::class);
$authUid = $session->getAuthId();
$theme = $authUid !== null ? $themeResolver->resolve($authUid) : 'default';
return new DesktopChromeRenderer(
- $injector->getInstance(AssetCollector::class),
- $injector->getInstance(PageComposer::class),
- $injector->getInstance(ViewModeConfigurator::class),
- $injector->getInstance(TopbarBuilder::class),
- $injector->getInstance(TopbarRenderer::class),
- $injector->getInstance(SidebarRenderer::class),
- $injector->getInstance(JsDiscoverer::class),
+ $injector->get(AssetCollector::class),
+ $injector->get(PageComposer::class),
+ $injector->get(ViewModeConfigurator::class),
+ $injector->get(TopbarBuilder::class),
+ $injector->get(TopbarRenderer::class),
+ $injector->get(SidebarRenderer::class),
+ $injector->get(JsDiscoverer::class),
$theme,
);
}
diff --git a/src/PageOutput/PageComposerFactory.php b/src/PageOutput/PageComposerFactory.php
index a3233e72..077f325d 100644
--- a/src/PageOutput/PageComposerFactory.php
+++ b/src/PageOutput/PageComposerFactory.php
@@ -32,7 +32,7 @@ class PageComposerFactory
public function create(Horde_Injector|Injector $injector): PageComposer
{
return new PageComposer(
- $injector->getInstance(AssetCollector::class),
+ $injector->get(AssetCollector::class),
);
}
}
diff --git a/src/PageOutput/PageOutputAssetManagerFactory.php b/src/PageOutput/PageOutputAssetManagerFactory.php
index 17ba22ef..6bbee70e 100644
--- a/src/PageOutput/PageOutputAssetManagerFactory.php
+++ b/src/PageOutput/PageOutputAssetManagerFactory.php
@@ -31,7 +31,7 @@ class PageOutputAssetManagerFactory
{
public function create(Horde_Injector|Injector $injector): PageOutputAssetManager
{
- $assetCollector = $injector->getInstance(AssetCollector::class);
+ $assetCollector = $injector->get(AssetCollector::class);
return new PageOutputAssetManager($assetCollector);
}
diff --git a/src/PageOutput/RenderingModeResolverFactory.php b/src/PageOutput/RenderingModeResolverFactory.php
index e5e98a10..f44ac8ec 100644
--- a/src/PageOutput/RenderingModeResolverFactory.php
+++ b/src/PageOutput/RenderingModeResolverFactory.php
@@ -25,8 +25,8 @@ class RenderingModeResolverFactory
public function create(Injector $injector): RenderingModeResolver
{
return new RenderingModeResolver(
- $injector->getInstance(SessionAccess::class),
- $injector->getInstance(Browser::class),
+ $injector->get(SessionAccess::class),
+ $injector->get(Browser::class),
);
}
}
diff --git a/src/PageOutput/ViewModeConfiguratorFactory.php b/src/PageOutput/ViewModeConfiguratorFactory.php
index aeaa25a1..3f349cb7 100644
--- a/src/PageOutput/ViewModeConfiguratorFactory.php
+++ b/src/PageOutput/ViewModeConfiguratorFactory.php
@@ -37,11 +37,11 @@ class ViewModeConfiguratorFactory
public function create(Horde_Injector|Injector $injector): ViewModeConfigurator
{
return new ViewModeConfigurator(
- $injector->getInstance(Horde_Registry::class),
- $injector->getInstance(PrefsService::class),
- $injector->getInstance(SessionAccess::class),
- $injector->getInstance(JsDiscoverer::class),
- $injector->getInstance(Token::class),
+ $injector->get(Horde_Registry::class),
+ $injector->get(PrefsService::class),
+ $injector->get(SessionAccess::class),
+ $injector->get(JsDiscoverer::class),
+ $injector->get(Token::class),
);
}
}
diff --git a/src/Session/HordeSessionFactory.php b/src/Session/HordeSessionFactory.php
index 31db4d20..ad7f2c2b 100644
--- a/src/Session/HordeSessionFactory.php
+++ b/src/Session/HordeSessionFactory.php
@@ -76,7 +76,7 @@ public function restore(SessionId $id, array $payload): Session
*/
public function create(Injector $injector): HordeSession
{
- $secret = $injector->getInstance('Horde_Secret_Cbc');
+ $secret = $injector->get('Horde_Secret_Cbc');
$encryptor = static fn(string $plaintext): string
=> (string) $secret->write($secret->getKey(), $plaintext);
$decryptor = static fn(string $ciphertext): string
diff --git a/src/Session/PublishesModernSessionToAccessorTrait.php b/src/Session/PublishesModernSessionToAccessorTrait.php
index 5d5108bb..a2077cf4 100644
--- a/src/Session/PublishesModernSessionToAccessorTrait.php
+++ b/src/Session/PublishesModernSessionToAccessorTrait.php
@@ -57,7 +57,7 @@ private function publishModernSessionToAccessor(): void
$GLOBALS['injector']->setInstance(HordeSession::class, $fresh);
try {
- $access = $GLOBALS['injector']->getInstance(SessionAccess::class);
+ $access = $GLOBALS['injector']->get(SessionAccess::class);
if ($access instanceof SessionAccessor) {
$access->replaceWith($fresh);
}
diff --git a/src/Session/SessionConfigFactory.php b/src/Session/SessionConfigFactory.php
index ab3be79d..cacb24a7 100644
--- a/src/Session/SessionConfigFactory.php
+++ b/src/Session/SessionConfigFactory.php
@@ -38,7 +38,7 @@ class SessionConfigFactory
*/
public function create(Injector $injector): SessionConfig
{
- $loader = $injector->getInstance(ConfigLoader::class);
+ $loader = $injector->get(ConfigLoader::class);
$state = $loader->load('horde');
return $this->fromState($state);
diff --git a/src/Session/SessionLifecycle.php b/src/Session/SessionLifecycle.php
index a4e3c7c4..cabe8ef2 100644
--- a/src/Session/SessionLifecycle.php
+++ b/src/Session/SessionLifecycle.php
@@ -454,7 +454,7 @@ public function regenerate(): void
*/
private function mintSuccessor(HordeSession $old): HordeSession
{
- $factory = $this->injector->getInstance(HordeSessionFactory::class);
+ $factory = $this->injector->get(HordeSessionFactory::class);
$successor = $factory->restore(
new SessionId((string) (session_id() ?: 'none')),
$old->toPayload(),
@@ -591,7 +591,7 @@ private function accessor(): SessionAccessor
if ($this->accessor === null) {
$resolved = null;
try {
- $resolved = $this->injector->getInstance(SessionAccess::class);
+ $resolved = $this->injector->get(SessionAccess::class);
} catch (\Throwable) {
// No SessionAccess binding — legacy test contexts and
// partial DI setups build a SessionLifecycle without
@@ -637,7 +637,7 @@ private function getSession(): HordeSession
if ($this->accessor()->hasCurrent()) {
return $this->accessor()->current();
}
- return $this->injector->getInstance(HordeSession::class);
+ return $this->injector->get(HordeSession::class);
}
/**
@@ -655,7 +655,7 @@ private function getSession(): HordeSession
* (see horde/Core#190).
* 2. The `HordeSession::class` injector binding — retained in
* parallel because dozens of transient callers still do
- * `$injector->getInstance(HordeSession::class)->…` inline and
+ * `$injector->get(HordeSession::class)->…` inline and
* expect the current value there too.
*
* The instance is also published on `$GLOBALS['injector']` when that
diff --git a/src/Session/SessionLifecycleFactory.php b/src/Session/SessionLifecycleFactory.php
index 5ced4a6e..8866bf34 100644
--- a/src/Session/SessionLifecycleFactory.php
+++ b/src/Session/SessionLifecycleFactory.php
@@ -49,12 +49,12 @@ class SessionLifecycleFactory
*/
public function create(Injector $injector): SessionLifecycle
{
- $handler = $injector->getInstance(SessionHandler::class);
- $config = $injector->getInstance(SessionConfig::class);
+ $handler = $injector->get(SessionHandler::class);
+ $config = $injector->get(SessionConfig::class);
$secret = null;
try {
- $resolved = $injector->getInstance('Horde_Secret_Cbc');
+ $resolved = $injector->get('Horde_Secret_Cbc');
if ($resolved instanceof SessionSecret) {
$secret = $resolved;
}
@@ -76,7 +76,7 @@ public function create(Injector $injector): SessionLifecycle
// clean() uses setKey directly because there's no payload
// to drain.
try {
- $coordinator = $injector->getInstance(SessionEncryptionCoordinator::class);
+ $coordinator = $injector->get(SessionEncryptionCoordinator::class);
} catch (Throwable) {
// No coordinator binding configured. Lifecycle falls
// back to its inline reEncryptAll path; behaviour is
@@ -98,7 +98,7 @@ public function create(Injector $injector): SessionLifecycle
// (correctness-degraded but non-crashing).
$accessor = null;
try {
- $resolvedAccess = $injector->getInstance(SessionAccess::class);
+ $resolvedAccess = $injector->get(SessionAccess::class);
if ($resolvedAccess instanceof SessionAccessor) {
$accessor = $resolvedAccess;
}
diff --git a/src/Sidebar/AdminSidebarPanelFactory.php b/src/Sidebar/AdminSidebarPanelFactory.php
index f76e943e..9b92a1e3 100644
--- a/src/Sidebar/AdminSidebarPanelFactory.php
+++ b/src/Sidebar/AdminSidebarPanelFactory.php
@@ -35,9 +35,9 @@ class AdminSidebarPanelFactory
public function create(Horde_Injector|Injector $injector): AdminSidebarPanel
{
return new AdminSidebarPanel(
- $injector->getInstance(Horde_Registry::class),
- $injector->getInstance(PermissionService::class),
- $injector->getInstance(PrefsService::class),
+ $injector->get(Horde_Registry::class),
+ $injector->get(PermissionService::class),
+ $injector->get(PrefsService::class),
);
}
}
diff --git a/src/Sidebar/SidebarBuilderFactory.php b/src/Sidebar/SidebarBuilderFactory.php
index a0395ef8..a4bb2854 100644
--- a/src/Sidebar/SidebarBuilderFactory.php
+++ b/src/Sidebar/SidebarBuilderFactory.php
@@ -34,8 +34,8 @@ class SidebarBuilderFactory
public function create(Horde_Injector|Injector $injector): SidebarBuilder
{
return new SidebarBuilder(
- $injector->getInstance(Horde_Registry::class),
- $injector->getInstance(PrefsService::class),
+ $injector->get(Horde_Registry::class),
+ $injector->get(PrefsService::class),
);
}
}
diff --git a/src/Sidebar/SidebarRendererFactory.php b/src/Sidebar/SidebarRendererFactory.php
index bdabfef6..2f0a4afe 100644
--- a/src/Sidebar/SidebarRendererFactory.php
+++ b/src/Sidebar/SidebarRendererFactory.php
@@ -25,8 +25,8 @@ class SidebarRendererFactory
public function create(Injector $injector): SidebarRenderer
{
return new SidebarRenderer(
- $injector->getInstance(AssetCollector::class),
- $injector->getInstance(JsDiscoverer::class),
+ $injector->get(AssetCollector::class),
+ $injector->get(JsDiscoverer::class),
);
}
}
diff --git a/src/Topbar/TopbarBuilderFactory.php b/src/Topbar/TopbarBuilderFactory.php
index 4fb917f2..f2424297 100644
--- a/src/Topbar/TopbarBuilderFactory.php
+++ b/src/Topbar/TopbarBuilderFactory.php
@@ -36,10 +36,10 @@ class TopbarBuilderFactory
public function create(Horde_Injector|Injector $injector): TopbarBuilder
{
return new TopbarBuilder(
- $injector->getInstance(Horde_Registry::class),
- $injector->getInstance(PrefsService::class),
- $injector->getInstance(PermissionService::class),
- $injector->getInstance(SessionAccess::class),
+ $injector->get(Horde_Registry::class),
+ $injector->get(PrefsService::class),
+ $injector->get(PermissionService::class),
+ $injector->get(SessionAccess::class),
);
}
}
diff --git a/src/Topbar/TopbarRendererFactory.php b/src/Topbar/TopbarRendererFactory.php
index 3d5e74a0..c240f84e 100644
--- a/src/Topbar/TopbarRendererFactory.php
+++ b/src/Topbar/TopbarRendererFactory.php
@@ -25,8 +25,8 @@ class TopbarRendererFactory
public function create(Injector $injector): TopbarRenderer
{
return new TopbarRenderer(
- $injector->getInstance(AssetCollector::class),
- $injector->getInstance(JsDiscoverer::class),
+ $injector->get(AssetCollector::class),
+ $injector->get(JsDiscoverer::class),
);
}
}
diff --git a/src/View/AccessKeyTrackerFactory.php b/src/View/AccessKeyTrackerFactory.php
index 7f0c7439..df70987b 100644
--- a/src/View/AccessKeyTrackerFactory.php
+++ b/src/View/AccessKeyTrackerFactory.php
@@ -24,8 +24,8 @@ public function create(Horde_Injector|Injector $injector): AccessKeyTracker
{
$accessKeysEnabled = true;
try {
- $prefs = $injector->getInstance(PrefsService::class);
- $session = $injector->getInstance(HordeSession::class);
+ $prefs = $injector->get(PrefsService::class);
+ $session = $injector->get(HordeSession::class);
$uid = $session->getAuthId() ?? '';
if ($uid !== '') {
$accessKeysEnabled = (bool) $prefs->getValue($uid, 'horde', 'widget_accesskey');
@@ -35,7 +35,7 @@ public function create(Horde_Injector|Injector $injector): AccessKeyTracker
$multibyte = false;
try {
- $registry = $injector->getInstance(Horde_Registry::class);
+ $registry = $injector->get(Horde_Registry::class);
$multibyte = !empty($registry->nlsconfig->curr_multibyte);
} catch (Throwable) {
}
diff --git a/test/Integration/Assets/AssetFilesystemFactoryIntegrationTest.php b/test/Integration/Assets/AssetFilesystemFactoryIntegrationTest.php
index 6bd114e3..92971e6e 100644
--- a/test/Integration/Assets/AssetFilesystemFactoryIntegrationTest.php
+++ b/test/Integration/Assets/AssetFilesystemFactoryIntegrationTest.php
@@ -26,7 +26,7 @@ protected function setUp(): void
#[Test]
public function injectorResolvesAssetFilesystem(): void
{
- $fs = $this->injector->getInstance(AssetFilesystem::class);
+ $fs = $this->injector->get(AssetFilesystem::class);
self::assertInstanceOf(AssetFilesystem::class, $fs);
self::assertInstanceOf(LocalAssetFilesystem::class, $fs);
@@ -35,7 +35,7 @@ public function injectorResolvesAssetFilesystem(): void
#[Test]
public function factoryProducedFilesystemChecksFiles(): void
{
- $fs = $this->injector->getInstance(AssetFilesystem::class);
+ $fs = $this->injector->get(AssetFilesystem::class);
self::assertTrue($fs->fileExists(__FILE__));
self::assertFalse($fs->fileExists('/tmp/nonexistent-integration-' . uniqid() . '.php'));
@@ -44,7 +44,7 @@ public function factoryProducedFilesystemChecksFiles(): void
#[Test]
public function localAssetFilesystemAlsoServesAsResponsiveAssetsFilesystem(): void
{
- $fs = $this->injector->getInstance(AssetFilesystem::class);
+ $fs = $this->injector->get(AssetFilesystem::class);
self::assertInstanceOf(ResponsiveAssetsFilesystem::class, $fs);
}
@@ -52,8 +52,8 @@ public function localAssetFilesystemAlsoServesAsResponsiveAssetsFilesystem(): vo
#[Test]
public function injectorReturnsSameInstance(): void
{
- $first = $this->injector->getInstance(AssetFilesystem::class);
- $second = $this->injector->getInstance(AssetFilesystem::class);
+ $first = $this->injector->get(AssetFilesystem::class);
+ $second = $this->injector->get(AssetFilesystem::class);
self::assertSame($first, $second);
}
diff --git a/test/Integration/Assets/CssDiscovererFactoryIntegrationTest.php b/test/Integration/Assets/CssDiscovererFactoryIntegrationTest.php
index f9abbe74..d43e1d73 100644
--- a/test/Integration/Assets/CssDiscovererFactoryIntegrationTest.php
+++ b/test/Integration/Assets/CssDiscovererFactoryIntegrationTest.php
@@ -51,7 +51,7 @@ public function getMapper(string $app): ?Mapper
#[Test]
public function injectorResolvesCssDiscoverer(): void
{
- $discoverer = $this->injector->getInstance(CssDiscoverer::class);
+ $discoverer = $this->injector->get(CssDiscoverer::class);
self::assertInstanceOf(CssDiscoverer::class, $discoverer);
self::assertInstanceOf(CascadeCssDiscoverer::class, $discoverer);
@@ -60,8 +60,8 @@ public function injectorResolvesCssDiscoverer(): void
#[Test]
public function injectorReturnsSameInstance(): void
{
- $first = $this->injector->getInstance(CssDiscoverer::class);
- $second = $this->injector->getInstance(CssDiscoverer::class);
+ $first = $this->injector->get(CssDiscoverer::class);
+ $second = $this->injector->get(CssDiscoverer::class);
self::assertSame($first, $second);
}
diff --git a/test/Integration/Assets/GraphicDiscovererFactoryIntegrationTest.php b/test/Integration/Assets/GraphicDiscovererFactoryIntegrationTest.php
index 8bef18c0..68a76023 100644
--- a/test/Integration/Assets/GraphicDiscovererFactoryIntegrationTest.php
+++ b/test/Integration/Assets/GraphicDiscovererFactoryIntegrationTest.php
@@ -51,7 +51,7 @@ public function getMapper(string $app): ?Mapper
#[Test]
public function injectorResolvesGraphicDiscoverer(): void
{
- $discoverer = $this->injector->getInstance(GraphicDiscoverer::class);
+ $discoverer = $this->injector->get(GraphicDiscoverer::class);
self::assertInstanceOf(GraphicDiscoverer::class, $discoverer);
self::assertInstanceOf(CascadeGraphicDiscoverer::class, $discoverer);
@@ -60,8 +60,8 @@ public function injectorResolvesGraphicDiscoverer(): void
#[Test]
public function injectorReturnsSameInstance(): void
{
- $first = $this->injector->getInstance(GraphicDiscoverer::class);
- $second = $this->injector->getInstance(GraphicDiscoverer::class);
+ $first = $this->injector->get(GraphicDiscoverer::class);
+ $second = $this->injector->get(GraphicDiscoverer::class);
self::assertSame($first, $second);
}
diff --git a/test/Integration/Assets/JsDiscovererFactoryIntegrationTest.php b/test/Integration/Assets/JsDiscovererFactoryIntegrationTest.php
index b2d3bb1c..0a392005 100644
--- a/test/Integration/Assets/JsDiscovererFactoryIntegrationTest.php
+++ b/test/Integration/Assets/JsDiscovererFactoryIntegrationTest.php
@@ -51,7 +51,7 @@ public function getMapper(string $app): ?Mapper
#[Test]
public function injectorResolvesJsDiscoverer(): void
{
- $discoverer = $this->injector->getInstance(JsDiscoverer::class);
+ $discoverer = $this->injector->get(JsDiscoverer::class);
self::assertInstanceOf(JsDiscoverer::class, $discoverer);
self::assertInstanceOf(PathBasedJsDiscoverer::class, $discoverer);
@@ -60,8 +60,8 @@ public function injectorResolvesJsDiscoverer(): void
#[Test]
public function injectorReturnsSameInstance(): void
{
- $first = $this->injector->getInstance(JsDiscoverer::class);
- $second = $this->injector->getInstance(JsDiscoverer::class);
+ $first = $this->injector->get(JsDiscoverer::class);
+ $second = $this->injector->get(JsDiscoverer::class);
self::assertSame($first, $second);
}
diff --git a/test/Integration/Assets/ThemeResolverFactoryIntegrationTest.php b/test/Integration/Assets/ThemeResolverFactoryIntegrationTest.php
index bc0995a4..2fcbca3d 100644
--- a/test/Integration/Assets/ThemeResolverFactoryIntegrationTest.php
+++ b/test/Integration/Assets/ThemeResolverFactoryIntegrationTest.php
@@ -30,7 +30,7 @@ protected function setUp(): void
#[Test]
public function injectorResolvesThemeResolver(): void
{
- $resolver = $this->injector->getInstance(ThemeResolver::class);
+ $resolver = $this->injector->get(ThemeResolver::class);
self::assertInstanceOf(ThemeResolver::class, $resolver);
self::assertInstanceOf(PrefsThemeResolver::class, $resolver);
@@ -39,7 +39,7 @@ public function injectorResolvesThemeResolver(): void
#[Test]
public function factoryProducedResolverReturnsDefault(): void
{
- $resolver = $this->injector->getInstance(ThemeResolver::class);
+ $resolver = $this->injector->get(ThemeResolver::class);
self::assertSame('default', $resolver->resolve('unknown-user'));
}
@@ -47,8 +47,8 @@ public function factoryProducedResolverReturnsDefault(): void
#[Test]
public function injectorReturnsSameInstance(): void
{
- $first = $this->injector->getInstance(ThemeResolver::class);
- $second = $this->injector->getInstance(ThemeResolver::class);
+ $first = $this->injector->get(ThemeResolver::class);
+ $second = $this->injector->get(ThemeResolver::class);
self::assertSame($first, $second);
}
diff --git a/test/Integration/Assets/UrlSignerFactoryIntegrationTest.php b/test/Integration/Assets/UrlSignerFactoryIntegrationTest.php
index 98e22c53..9d8cb184 100644
--- a/test/Integration/Assets/UrlSignerFactoryIntegrationTest.php
+++ b/test/Integration/Assets/UrlSignerFactoryIntegrationTest.php
@@ -24,7 +24,7 @@ public function injectorResolvesHmacWhenSecretConfigured(): void
try {
$injector = new Injector(new TopLevel());
- $signer = $injector->getInstance(UrlSigner::class);
+ $signer = $injector->get(UrlSigner::class);
self::assertInstanceOf(UrlSigner::class, $signer);
self::assertInstanceOf(HmacUrlSigner::class, $signer);
@@ -39,7 +39,7 @@ public function injectorResolvesNullWhenNoSecret(): void
unset($GLOBALS['conf']);
$injector = new Injector(new TopLevel());
- $signer = $injector->getInstance(UrlSigner::class);
+ $signer = $injector->get(UrlSigner::class);
self::assertInstanceOf(NullUrlSigner::class, $signer);
}
@@ -51,8 +51,8 @@ public function injectorReturnsSameInstance(): void
try {
$injector = new Injector(new TopLevel());
- $first = $injector->getInstance(UrlSigner::class);
- $second = $injector->getInstance(UrlSigner::class);
+ $first = $injector->get(UrlSigner::class);
+ $second = $injector->get(UrlSigner::class);
self::assertSame($first, $second);
} finally {
@@ -68,7 +68,7 @@ public function factoryProducedSignerWorksEndToEnd(): void
try {
$injector = new Injector(new TopLevel());
- $signer = $injector->getInstance(UrlSigner::class);
+ $signer = $injector->get(UrlSigner::class);
$now = 1700000000;
$signed = $signer->signUrl('/test/page', $now);
diff --git a/test/Integration/Path/PathBuilderFactoryIntegrationTest.php b/test/Integration/Path/PathBuilderFactoryIntegrationTest.php
index b612909d..71c95566 100644
--- a/test/Integration/Path/PathBuilderFactoryIntegrationTest.php
+++ b/test/Integration/Path/PathBuilderFactoryIntegrationTest.php
@@ -41,7 +41,7 @@ protected function setUp(): void
#[Test]
public function injectorResolvesPathBuilderInterface(): void
{
- $builder = $this->injector->getInstance(PathBuilderInterface::class);
+ $builder = $this->injector->get(PathBuilderInterface::class);
self::assertInstanceOf(PathBuilderInterface::class, $builder);
self::assertInstanceOf(PathBuilder::class, $builder);
@@ -50,7 +50,7 @@ public function injectorResolvesPathBuilderInterface(): void
#[Test]
public function factoryProducedBuilderResolvesRegistry(): void
{
- $builder = $this->injector->getInstance(PathBuilderInterface::class);
+ $builder = $this->injector->get(PathBuilderInterface::class);
$result = $builder->withAppFileroot('turba');
self::assertSame('/srv/www/horde/turba', (string) $result);
@@ -59,7 +59,7 @@ public function factoryProducedBuilderResolvesRegistry(): void
#[Test]
public function factoryProducedBuilderSupportsChaining(): void
{
- $builder = $this->injector->getInstance(PathBuilderInterface::class);
+ $builder = $this->injector->get(PathBuilderInterface::class);
$result = $builder
->withAppFileroot('turba')
->withSlug('config')
@@ -72,8 +72,8 @@ public function factoryProducedBuilderSupportsChaining(): void
#[Test]
public function injectorReturnsSameInstance(): void
{
- $first = $this->injector->getInstance(PathBuilderInterface::class);
- $second = $this->injector->getInstance(PathBuilderInterface::class);
+ $first = $this->injector->get(PathBuilderInterface::class);
+ $second = $this->injector->get(PathBuilderInterface::class);
self::assertSame($first, $second);
}
diff --git a/test/Integration/Sidebar/SidebarRendererFactoryIntegrationTest.php b/test/Integration/Sidebar/SidebarRendererFactoryIntegrationTest.php
index 9434ce4e..40a717bf 100644
--- a/test/Integration/Sidebar/SidebarRendererFactoryIntegrationTest.php
+++ b/test/Integration/Sidebar/SidebarRendererFactoryIntegrationTest.php
@@ -50,7 +50,7 @@ public function getMapper(string $app): ?Mapper
#[Test]
public function injectorResolvesSidebarRenderer(): void
{
- $renderer = $this->injector->getInstance(SidebarRenderer::class);
+ $renderer = $this->injector->get(SidebarRenderer::class);
self::assertInstanceOf(SidebarRenderer::class, $renderer);
}
@@ -58,8 +58,8 @@ public function injectorResolvesSidebarRenderer(): void
#[Test]
public function injectorReturnsSameInstance(): void
{
- $first = $this->injector->getInstance(SidebarRenderer::class);
- $second = $this->injector->getInstance(SidebarRenderer::class);
+ $first = $this->injector->get(SidebarRenderer::class);
+ $second = $this->injector->get(SidebarRenderer::class);
self::assertSame($first, $second);
}
diff --git a/test/Integration/Topbar/TopbarRendererFactoryIntegrationTest.php b/test/Integration/Topbar/TopbarRendererFactoryIntegrationTest.php
index 04a5d46a..48c3c615 100644
--- a/test/Integration/Topbar/TopbarRendererFactoryIntegrationTest.php
+++ b/test/Integration/Topbar/TopbarRendererFactoryIntegrationTest.php
@@ -50,7 +50,7 @@ public function getMapper(string $app): ?Mapper
#[Test]
public function injectorResolvesTopbarRenderer(): void
{
- $renderer = $this->injector->getInstance(TopbarRenderer::class);
+ $renderer = $this->injector->get(TopbarRenderer::class);
self::assertInstanceOf(TopbarRenderer::class, $renderer);
}
@@ -58,8 +58,8 @@ public function injectorResolvesTopbarRenderer(): void
#[Test]
public function injectorReturnsSameInstance(): void
{
- $first = $this->injector->getInstance(TopbarRenderer::class);
- $second = $this->injector->getInstance(TopbarRenderer::class);
+ $first = $this->injector->get(TopbarRenderer::class);
+ $second = $this->injector->get(TopbarRenderer::class);
self::assertSame($first, $second);
}
diff --git a/test/Integration/Uri/UriBuilderFactoryIntegrationTest.php b/test/Integration/Uri/UriBuilderFactoryIntegrationTest.php
index db21681b..8470486c 100644
--- a/test/Integration/Uri/UriBuilderFactoryIntegrationTest.php
+++ b/test/Integration/Uri/UriBuilderFactoryIntegrationTest.php
@@ -51,7 +51,7 @@ public function getMapper(string $app): ?Mapper
#[Test]
public function injectorResolvesUriBuilderInterface(): void
{
- $builder = $this->injector->getInstance(UriBuilderInterface::class);
+ $builder = $this->injector->get(UriBuilderInterface::class);
self::assertInstanceOf(UriBuilderInterface::class, $builder);
self::assertInstanceOf(UriBuilder::class, $builder);
@@ -60,7 +60,7 @@ public function injectorResolvesUriBuilderInterface(): void
#[Test]
public function factoryProducedBuilderResolvesRegistry(): void
{
- $builder = $this->injector->getInstance(UriBuilderInterface::class);
+ $builder = $this->injector->get(UriBuilderInterface::class);
$result = $builder->withAppWebroot('kronolith');
self::assertSame('/horde/kronolith', $result->getPath());
@@ -69,7 +69,7 @@ public function factoryProducedBuilderResolvesRegistry(): void
#[Test]
public function factoryProducedBuilderSupportsPsr7Chain(): void
{
- $builder = $this->injector->getInstance(UriBuilderInterface::class);
+ $builder = $this->injector->get(UriBuilderInterface::class);
$result = $builder
->withScheme('https')
->withHost('example.com')
@@ -87,8 +87,8 @@ public function factoryProducedBuilderSupportsPsr7Chain(): void
#[Test]
public function injectorReturnsSameInstance(): void
{
- $first = $this->injector->getInstance(UriBuilderInterface::class);
- $second = $this->injector->getInstance(UriBuilderInterface::class);
+ $first = $this->injector->get(UriBuilderInterface::class);
+ $second = $this->injector->get(UriBuilderInterface::class);
self::assertSame($first, $second);
}
diff --git a/test/Unit/Config/LegacyMergedConfigInjectorTest.php b/test/Unit/Config/LegacyMergedConfigInjectorTest.php
index 76875a49..e6e334f0 100644
--- a/test/Unit/Config/LegacyMergedConfigInjectorTest.php
+++ b/test/Unit/Config/LegacyMergedConfigInjectorTest.php
@@ -57,7 +57,7 @@ public function testLegacyMergedConfigCanBeBoundToInjector(): void
$this->injector->setInstance(LegacyMergedConfig::class, $config);
- $retrieved = $this->injector->getInstance(LegacyMergedConfig::class);
+ $retrieved = $this->injector->get(LegacyMergedConfig::class);
$this->assertSame($config, $retrieved);
$this->assertEquals('value', $retrieved->get('test'));
@@ -74,7 +74,7 @@ public function testRebindingUpdatesInjectorInstance(): void
$hordeConfig = new LegacyMergedConfig(['app' => 'horde', 'cache' => ['driver' => 'file']]);
$this->injector->setInstance(LegacyMergedConfig::class, $hordeConfig);
- $retrieved1 = $this->injector->getInstance(LegacyMergedConfig::class);
+ $retrieved1 = $this->injector->get(LegacyMergedConfig::class);
$this->assertEquals('horde', $retrieved1->get('app'));
$this->assertEquals('file', $retrieved1->get('cache.driver'));
@@ -82,7 +82,7 @@ public function testRebindingUpdatesInjectorInstance(): void
$impConfig = new LegacyMergedConfig(['app' => 'imp', 'cache' => ['driver' => 'memcache']]);
$this->injector->setInstance(LegacyMergedConfig::class, $impConfig);
- $retrieved2 = $this->injector->getInstance(LegacyMergedConfig::class);
+ $retrieved2 = $this->injector->get(LegacyMergedConfig::class);
$this->assertEquals('imp', $retrieved2->get('app'));
$this->assertEquals('memcache', $retrieved2->get('cache.driver'));
@@ -107,7 +107,7 @@ public function testSimulatePushPopAppConfigSwitching(): void
]);
$this->injector->setInstance(LegacyMergedConfig::class, $hordeConfig);
- $config1 = $this->injector->getInstance(LegacyMergedConfig::class);
+ $config1 = $this->injector->get(LegacyMergedConfig::class);
$this->assertEquals('horde', $config1->get('app'));
$this->assertEquals('horde-db', $config1->get('database.host'));
@@ -120,7 +120,7 @@ public function testSimulatePushPopAppConfigSwitching(): void
]);
$this->injector->setInstance(LegacyMergedConfig::class, $impConfig);
- $config2 = $this->injector->getInstance(LegacyMergedConfig::class);
+ $config2 = $this->injector->get(LegacyMergedConfig::class);
$this->assertEquals('imp', $config2->get('app'));
$this->assertEquals('horde-db', $config2->get('database.host'));
$this->assertEquals('imap.example.com', $config2->get('mail.server'));
@@ -129,7 +129,7 @@ public function testSimulatePushPopAppConfigSwitching(): void
// (restore horde config)
$this->injector->setInstance(LegacyMergedConfig::class, $hordeConfig);
- $config3 = $this->injector->getInstance(LegacyMergedConfig::class);
+ $config3 = $this->injector->get(LegacyMergedConfig::class);
$this->assertEquals('horde', $config3->get('app'));
$this->assertEquals('horde-db', $config3->get('database.host'));
$this->assertNull($config3->get('mail.server')); // imp-specific gone
@@ -147,8 +147,8 @@ public function testMultipleFactoriesShareSameConfigInstance(): void
$this->injector->setInstance(LegacyMergedConfig::class, $config);
// Simulate two factories requesting config
- $instance1 = $this->injector->getInstance(LegacyMergedConfig::class);
- $instance2 = $this->injector->getInstance(LegacyMergedConfig::class);
+ $instance1 = $this->injector->get(LegacyMergedConfig::class);
+ $instance2 = $this->injector->get(LegacyMergedConfig::class);
// Should be same instance (singleton per binding)
$this->assertSame($instance1, $instance2);
@@ -163,12 +163,12 @@ public function testLegacyMergedConfigBindingIndependentOfState(): void
$this->injector->setInstance(LegacyMergedConfig::class, $legacyConfig);
// Verify LegacyMergedConfig is bound
- $retrieved = $this->injector->getInstance(LegacyMergedConfig::class);
+ $retrieved = $this->injector->get(LegacyMergedConfig::class);
$this->assertSame($legacyConfig, $retrieved);
// Verify State is NOT bound (would throw exception)
try {
- $this->injector->getInstance(State::class);
+ $this->injector->get(State::class);
$this->fail('State should not be bound to injector');
} catch (Exception $e) {
// Expected - State is not bound, throws from State constructor or injector
@@ -184,7 +184,7 @@ public function testInjectedConfigIsImmutable(): void
$config = new LegacyMergedConfig(['value' => 'original']);
$this->injector->setInstance(LegacyMergedConfig::class, $config);
- $retrieved = $this->injector->getInstance(LegacyMergedConfig::class);
+ $retrieved = $this->injector->get(LegacyMergedConfig::class);
$this->expectException(RuntimeException::class);
$this->expectExceptionMessage('ConfigState is immutable');
diff --git a/test/Unit/Factory/GroupTest.php b/test/Unit/Factory/GroupTest.php
index e7c2c333..5d667011 100644
--- a/test/Unit/Factory/GroupTest.php
+++ b/test/Unit/Factory/GroupTest.php
@@ -34,7 +34,7 @@ public function testMock()
$GLOBALS['conf']['group']['driver'] = 'mock';
$this->assertInstanceOf(
'Horde_Group_Mock',
- $injector->getInstance('Horde_Group')
+ $injector->get('Horde_Group')
);
}
}
diff --git a/test/Unit/Session/HordeSessionNullTest.php b/test/Unit/Session/HordeSessionNullTest.php
index 49b58fb3..c5382ced 100644
--- a/test/Unit/Session/HordeSessionNullTest.php
+++ b/test/Unit/Session/HordeSessionNullTest.php
@@ -132,7 +132,7 @@ public function testPublishedSessionIsAlsoRegisteredAsSharedSingleton(): void
// through the other during the request.
self::assertSame(
$accessor->current(),
- $injector->getInstance(HordeSession::class),
+ $injector->get(HordeSession::class),
'HordeSession singleton and SessionAccessor current() diverged',
);
}
|