(Fix) Add support for Android (FCL, Pojav, etc.)

[donmor]

Confirmation

• I have read the wiki

Bug description

I have to create this issue here because nothing is changed in this repo (all changes are in dependencies), and this is the only proper (?) issue template

Add support for android launchers by adding native libraries built with NDK; fix #773.

Patches:

• Add initial support for android native libraries native-utils#1
• Add build scripts for android opus4j#10
• Add build scripts for android lame4j#4
• Add build scripts for android speex4j#1
• Add build scripts for android rnnoise4j#7

Built jar: voicechat-forge-1.20.1-2.6.7.zip

Tested on my own device (FCL-Team/FoldCraftLauncher, Redmi Note 11T Pro, MediaTek Dimensity 8100, aarch64)

Minecraft version

1.20.1

Mod/Plugin version

1.20.1-2.6.7

Mod/Plugin loader and version

Forge 47.4.10

Steps to reproduce

None

Expected behavior

No response

Log files

None

Screenshots

[henkelmax]

I'm sorry, but I didn't add android natives for a reason. I rewrote all natives in C to save a couple of megabytes storage. The mod only contains natives that cover the majority of installations. Adding natives for android would increase the jar even more which I worked hard on saving a couple of megabytes. There are also fallbacks in the mod that makes it work with a reduced feature set on unsupported systems. The amount of users on android is so small, that it wouldn't make sense to increase the jar size for everyone. We also officially don't support Android (Read the wiki). So if I'd add android natives it would not make sense to not provide support for android, which I don't want to do. I also don't own an android device, so I can't verify if builds run or to verify potential bugs.

I really appreciate the work you did, but I'm sorry, I won't add this.

[henkelmax]

I might consider adding support in the future if there will be a bigger demand though, so I'll keep your PRs open for now.

[donmor]

Okay... May I build and deploy android-compatible jars in my private experimental servers (as well as clients)? I may add more architectures to fit my linux boxes (riscv64, loong64, etc.)

[henkelmax]

Yeah, sure. Just don't distribute the voice chat jars publicly.

[alexytomi]

It is possible to add the .so files within the launcher so we take the hit instead.

Can we be allowed to distribute the natives ourselves as part of the apk file? Cause, well, ARR.

However that would need changing how the natives are loaded because currently it does not fall back on System.loadLibrary and thus would never load the native.

It's safe to assume they are in java.library.path as all the mainstream android launchers and the iOS one are based on pojavlauncher, which include two directories we store natives in, the dedicated android directory, and the libs/ directory in the JRE, in java.library.path

[donmor]

It is possible to add the .so files within the launcher so we take the hit instead.

Can we be allowed to distribute the natives ourselves as part of the apk file? Cause, well, ARR.

It's safe to assume they are in java.library.path as all the mainstream android launchers and the iOS one are based on pojavlauncher, which include two directories we store natives in, the dedicated android directory, and the libs/ directory in the JRE, in java.library.path

To detect and use natives libraries for android, at least henkelmax/native-utils#1 should be merged (it contains some detection code), and all dependants should be rebuilt against the patched version

[henkelmax]

Yeah, that sounds good, I'll take a look at it.