Skip to content

Fix -Wpattern-namespace-specifier warnings #137

Description

@jorisdral

Since ghc-9.14, we get these warnings:

src/Botan/Bindings/Utility.hsc:21:5: error: [GHC-68383] [-Wpattern-namespace-specifier, Werror=pattern-namespace-specifier]
    The ‘pattern’ namespace specifier is deprecated.
    Suggested fix:
      Use the ‘ExplicitNamespaces’ extension (implied by ‘TypeFamilies’ and ‘TypeOperators’)
      and replace ‘pattern’ with ‘data’.
   |
21 |   , pattern BOTAN_FFI_HEX_UPPER_CASE
   |     ^^^^^^^

We currently ignore the warnings in the common warnings stanzas in the cabal files:

  if impl(ghc >=9.14)
    ghc-options:
      -Wno-pattern-namespace-specifier

We should fix these warnings properly instead, preferably in a way that we don't need much conditional compilation

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions