Add Postgres 17, 18, 19 support

- Raise version_compat.h upper bound to PG20 (allows PG19 compilation)
- Add PG19 to PGVERSIONS in Makefile; use Citus v14.1.0 for PG18/19
- Extend CI matrices (run-tests.yml, run-pgaftest.yml) to cover PG18/19
  with correct Citus version per release; bump pgaftest builder to PG18
- Fix #1116: thread dbname through ReplicationSource so primary_conninfo
  includes a dbname keyword, required by PG17 synchronized_standby_slots
  for logical replication slot failover
- Guard pg_stat_wal_receiver.received_tli against NULL: PG18 introduced
  WALRCV_CONNECTING state where received_tli is NULL; fall back to
  pg_control_checkpoint() timeline_id during that transient state

Fixes #1116

Author: dimitri

.github/workflows/run-pgaftest.yml

@@ -43,7 +43,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        PGVERSION: [14, 15, 16, 17]
+        PGVERSION: [14, 15, 16, 17, 18, 19]
 
     steps:
       - uses: actions/checkout@v7.0.0
@@ -54,11 +54,11 @@ jobs:
       - name: Build pgaf:run image (PG${{ matrix.PGVERSION }})
         run: |
           # Match the CITUSTAG-per-PGVERSION logic from the top-level Makefile:
-          # PG14–15 require Citus v12 (last version supporting those releases).
-          # PG16+ use the current default.
+          # PG14–15 require Citus v12, PG16–17 require v13, PG18+ require v14.
           case "${{ matrix.PGVERSION }}" in
             14|15) CITUSTAG=v12.1.5 ;;
-            *)     CITUSTAG=v13.2.0 ;;
+            16|17) CITUSTAG=v13.2.0 ;;
+            *)     CITUSTAG=v14.1.0 ;;
           esac
           docker build \
             --build-arg PGVERSION=${{ matrix.PGVERSION }} \
@@ -73,7 +73,8 @@ jobs:
           # this step only adds the pg_createcluster layer on top.
           case "${{ matrix.PGVERSION }}" in
             14|15) CITUSTAG=v12.1.5 ;;
-            *)     CITUSTAG=v13.2.0 ;;
+            16|17) CITUSTAG=v13.2.0 ;;
+            *)     CITUSTAG=v14.1.0 ;;
           esac
           docker build \
             --build-arg PGVERSION=${{ matrix.PGVERSION }} \
@@ -117,7 +118,7 @@ jobs:
     needs: style_checker
     runs-on: ubuntu-latest
     env:
-      PGVERSION: 17
+      PGVERSION: 18
 
     steps:
       - uses: actions/checkout@v7.0.0
@@ -129,7 +130,7 @@ jobs:
         run: |
           docker build \
             --build-arg PGVERSION=${{ env.PGVERSION }} \
-            --build-arg CITUSTAG=v13.2.0 \
+            --build-arg CITUSTAG=v14.1.0 \
             --target pgaftest \
             -t pgaf:pgaftest \
             .
@@ -169,24 +170,33 @@ jobs:
           - { PGVERSION: 15, schedule: quick }
           - { PGVERSION: 16, schedule: quick }
           - { PGVERSION: 17, schedule: quick }
+          - { PGVERSION: 18, schedule: quick }
+          - { PGVERSION: 19, schedule: quick }
           # node: create_standby_with_pgdata, maintenance_and_drop, auth,
           #       monitor_disabled, replace_monitor, extension_update,
           #       debian_clusters, tablespaces
           - { PGVERSION: 14, schedule: node }
           - { PGVERSION: 15, schedule: node }
           - { PGVERSION: 16, schedule: node }
           - { PGVERSION: 17, schedule: node }
+          - { PGVERSION: 18, schedule: node }
+          - { PGVERSION: 19, schedule: node }
           # ssl: enable_ssl, ssl_self_signed, ssl_cert
           - { PGVERSION: 14, schedule: ssl }
           - { PGVERSION: 15, schedule: ssl }
           - { PGVERSION: 16, schedule: ssl }
           - { PGVERSION: 17, schedule: ssl }
-          # slow schedules: PG17 only
+          - { PGVERSION: 18, schedule: ssl }
+          - { PGVERSION: 19, schedule: ssl }
+          # slow schedules: PG17 only (FSM logic, not version-specific code paths)
           - { PGVERSION: 17, schedule: multi-alternate }  # multi_alternate
           - { PGVERSION: 17, schedule: multi-misc }       # multi_standbys, multi_maintenance, ensure, multi_ifdown
           - { PGVERSION: 17, schedule: multi-async }      # multi_async
           - { PGVERSION: 17, schedule: citus-1 }          # citus_cluster_name, citus_force_failover, citus_multi_standbys
           - { PGVERSION: 17, schedule: citus-2 }          # basic_citus_operation, nonha_citus_operation, citus_skip_pg_hba
+          # slow schedules on PG18 to validate new-version behaviour
+          - { PGVERSION: 18, schedule: multi-alternate }
+          - { PGVERSION: 18, schedule: multi-misc }
 
     steps:
       - uses: actions/checkout@v7.0.0
@@ -257,7 +267,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        PGVERSION: [14, 15, 16, 17]
+        PGVERSION: [14, 15, 16, 17, 18, 19]
 
     steps:
       - uses: actions/checkout@v7.0.0
@@ -278,7 +288,8 @@ jobs:
         run: |
           case "${{ matrix.PGVERSION }}" in
             14|15) CITUSTAG=v12.1.5 ;;
-            *)     CITUSTAG=v13.2.0 ;;
+            16|17) CITUSTAG=v13.2.0 ;;
+            *)     CITUSTAG=v14.1.0 ;;
           esac
           docker build \
             --build-arg PGVERSION=${{ matrix.PGVERSION }} \

.github/workflows/run-tests.yml

@@ -40,6 +40,8 @@ jobs:
           - 15
           - 16
           - 17
+          - 18
+          - 19
     steps:
       - name: Checkout repository
         uses: actions/checkout@v7.0.0
@@ -69,6 +71,8 @@ jobs:
           - 15
           - 16
           - 17
+          - 18
+          - 19
         TEST:
           - multi
           - single

Makefile

@@ -4,7 +4,7 @@
 .DEFAULT_GOAL := all
 
 # Supported PostgreSQL versions:
-PGVERSIONS = 13 14 15 16 17 18
+PGVERSIONS = 13 14 15 16 17 18 19
 
 # Default version:
 PGVERSION ?= $(lastword $(PGVERSIONS))
@@ -305,7 +305,8 @@ BUILD_ARGS_pg14 = --build-arg PGVERSION=14 --build-arg CITUSTAG=v12.1.5
 BUILD_ARGS_pg15 = --build-arg PGVERSION=15 --build-arg CITUSTAG=v12.1.5
 BUILD_ARGS_pg16 = --build-arg PGVERSION=16 --build-arg CITUSTAG=$(CITUSTAG)
 BUILD_ARGS_pg17 = --build-arg PGVERSION=17 --build-arg CITUSTAG=$(CITUSTAG)
-BUILD_ARGS_pg18 = --build-arg PGVERSION=18 --build-arg CITUSTAG=$(CITUSTAG)
+BUILD_ARGS_pg18 = --build-arg PGVERSION=18 --build-arg CITUSTAG=v14.1.0
+BUILD_ARGS_pg19 = --build-arg PGVERSION=19 --build-arg CITUSTAG=v14.1.0
 
 # DOCKER BUILDS
 

src/bin/common/pgctl.c

@@ -2350,12 +2350,22 @@ prepare_recovery_settings(const char *pgdata,
 				  primaryNode->host,
 				  primaryNode->port);
 
+		/*
+		 * PG17 introduced synchronized_standby_slots for logical slot
+		 * failover; pg_sync_replication_slots() requires primary_conninfo
+		 * to include a dbname keyword.  Pass it when available.
+		 */
+		const char *dbname =
+			IS_EMPTY_STRING_BUFFER(replicationSource->dbname)
+			? NULL
+			: replicationSource->dbname;
+
 		if (!prepare_primary_conninfo(primaryConnInfo,
 									  MAXCONNINFO,
 									  primaryNode->host,
 									  primaryNode->port,
 									  replicationSource->userName,
-									  NULL, /* no database */
+									  dbname,
 									  replicationSource->password,
 									  replicationSource->applicationName,
 									  replicationSource->sslOptions,

src/bin/common/pgsql.c

@@ -2616,7 +2616,10 @@ pgsql_get_postgres_metadata(PGSQL *pgsql,
 		" end as current_lsn,"
 		" pg_control_version, catalog_version_no, system_identifier,"
 		" case when pg_is_in_recovery()"
-		" then (select received_tli from pg_stat_wal_receiver)"
+		" then coalesce("
+		"        (select received_tli from pg_stat_wal_receiver"
+		"          where status <> 'connecting'),"
+		"        (select timeline_id from pg_control_checkpoint()))"
 		" else (select timeline_id from pg_control_checkpoint()) "
 		" end as timeline_id "
 		" from (values(1)) as dummy"

src/bin/common/pgsql.h

@@ -243,6 +243,7 @@ typedef struct ReplicationSource
 {
 	NodeAddress primaryNode;
 	char userName[NAMEDATALEN];
+	char dbname[NAMEDATALEN];      /* database name for primary_conninfo (PG17+) */
 	char slotName[MAXCONNINFO];
 	char password[MAXCONNINFO];
 	char maximumBackupRate[MAXIMUM_BACKUP_RATE_LEN];

src/bin/pg_autoctl/primary_standby.c

@@ -849,6 +849,7 @@ standby_init_replication_source(LocalPostgresServer *postgres,
 	}
 
 	strlcpy(upstream->userName, username, NAMEDATALEN);
+	strlcpy(upstream->dbname, postgres->postgresSetup.dbname, NAMEDATALEN);
 
 	if (password != NULL)
 	{

src/monitor/version_compat.h

@@ -14,8 +14,8 @@
 
 #include "postgres.h"
 
-/* we support Postgres versions 10, 11, 12, 13, 14, 15, 16, 17, 18. */
-#if (PG_VERSION_NUM < 100000 || PG_VERSION_NUM >= 190000)
+/* we support Postgres versions 10, 11, 12, 13, 14, 15, 16, 17, 18, 19. */
+#if (PG_VERSION_NUM < 100000 || PG_VERSION_NUM >= 200000)
 #error "Unknown or unsupported postgresql version"
 #endif