From 3556005dc7923b4c84214f975ee3ac6098f2ce6f Mon Sep 17 00:00:00 2001 From: Dev Date: Wed, 14 Feb 2018 09:40:52 -0800 Subject: [PATCH] Code Review Great job overall. You've definitely shown some improvement in some areas: - Great job using functions to break down the code - Great commenting - Small improvement with use of space - Creative solutions to animations and transitions! - Well done usage of Codepen for snippets! But you've really got to work on neatness and polish. - Typos are OK -- but constant mispellings cause you to make mistakes and breaks readability. - Spacing: Use a linter and install some tools help you keep things neat - Variable names need a lot of work. These may seem nitpicky but code that's readable is also codew with far fewer bugs. It's code that makes errors easier to find. It's code that helps you to literally see what's missing, can be improved, or is broken. Resources: - https://git.generalassemb.ly/sf-wdi-43/study-resources/blob/master/editor_cheatsheet.md This is really well done and I'm really glad to see you take pride in your CSS and design! I hope you enjoyed it. --- index.html | 19 ++++++++++++++----- script/script.js | 31 +++++++++++++++++++++++++++++-- 2 files changed, 43 insertions(+), 7 deletions(-) diff --git a/index.html b/index.html index c734c33..a55df69 100644 --- a/index.html +++ b/index.html @@ -3,12 +3,18 @@ - +