refactor: use distinct constants for CLI subcommand names

- Replaced hardcoded strings with specific constants to improve maintainability.
- Split shared command values (e.g., "add") into domain-specific constants
  (e.g., UsersAddCmdName, GroupsAddCmdName) to better reflect the logical
  context, even where the underlying string values are identical.
- No changes to existing functionality; the CLI interface remains unchanged.

Author: halacs

cli/cmd/autologin.go

@@ -9,7 +9,7 @@ import (
 )
 
 func loginRequired(name string) bool {
-	loginRequiredCommands := []string{StatusCmdUse, SetStateCmdUse, AddCmdUse, InheritCmdUse, RemoveCmdUse}
+	loginRequiredCommands := []string{StatusCmdName, SetStateCmdName, PortsAddCmdName, UsersAddCmdName, InheritCmdName, PortsRemoveCmdName, UsersRemoveCmdName}
 
 	for _, i := range loginRequiredCommands {
 		if name == i {

cli/cmd/consts.go

@@ -24,18 +24,28 @@ const (
 	ArgMqttDeviceNameName          = "mqttDeviceName"
 	ArgMqttTelePeriodName          = "mqttTelePeriod"
 	ArgMqttTelePeriodFastName      = "mqttTelePeriodFast"
-	UsersCmdUse                    = "users"
-	StatusCmdUse                   = "status"
-	SetStateCmdUse                 = "set-state"
-	GroupsCmdName                  = "groups"
-	LoginCmdName                   = "login"
-	LogoutCmdName                  = "logout"
-	PingCmdName                    = "ping"
 	HomeAssistantCmdName           = "ha"
 	ArgDoorStatusSupported         = "doorStatusSupported"
 	ArgDevicePortsName             = "devicePorts"
 	PortsCmdName                   = "ports"
-	AddCmdUse                      = "add"
-	InheritCmdUse                  = "inherit"
-	RemoveCmdUse                   = "remove"
+	PortsAddCmdName                = "add"
+	UsersAddCmdName                = "add"
+	InheritCmdName                 = "inherit"
+	PortsRemoveCmdName             = "remove"
+	UsersRemoveCmdName             = "remove"
+	GroupsListCmdName              = "list"
+	UsersListCmdName               = "list"
+	PortsListCmdName               = "ports-list"
+	PasswordChangeCmdName          = "password-change"
+	DeleteCmdName                  = "delete"
+	GroupsAddCmdName               = "create"
+	GetNameCmdName                 = "get-name"
+	DiscoverCmdName                = "discover"
+	UsersCmdName                   = "users"
+	StatusCmdName                  = "status"
+	SetStateCmdName                = "set-state"
+	GroupsCmdName                  = "groups"
+	LoginCmdName                   = "login"
+	LogoutCmdName                  = "logout"
+	PingCmdName                    = "ping"
 )

cli/cmd/discover.go

@@ -1,9 +1,9 @@
 package cmd
 
 import (
+	"context"
 	"halsecur/cli"
 	"halsecur/sdk"
-	"context"
 	"os"
 	"time"
 
@@ -16,7 +16,7 @@ func init() {
 	)
 
 	discoverCmd := &cobra.Command{
-		Use:     "discover",
+		Use:     DiscoverCmdName,
 		Short:   "Discover Hörmann BiSecur gateways on the local network",
 		Long:    ``,
 		PreRunE: preRunFuncs,

cli/cmd/getName.go

@@ -13,7 +13,7 @@ import (
 
 func init() {
 	getNameCmd := &cobra.Command{
-		Use:     "get-name",
+		Use:     GetNameCmdName,
 		Short:   "Queries the name of the Hörmann BiSecur gateway",
 		Long:    ``,
 		PreRunE: preRunFuncs,

cli/cmd/groupsAdd.go

@@ -2,11 +2,12 @@ package cmd
 
 import (
 	"halsecur/cli"
+
 	"github.com/spf13/cobra"
 )
 
 var groupsCreateCmd = &cobra.Command{
-	Use:     "create",
+	Use:     GroupsAddCmdName,
 	Short:   "Create a new gateway group",
 	Long:    `Create a new gateway group`,
 	PreRunE: preRunFuncs,

cli/cmd/groupsDelete.go

@@ -2,11 +2,12 @@ package cmd
 
 import (
 	"halsecur/cli"
+
 	"github.com/spf13/cobra"
 )
 
 var groupsDeleteCmd = &cobra.Command{
-	Use:     "delete",
+	Use:     DeleteCmdName,
 	Short:   "Delete a gateway group",
 	Long:    `Delete a gateway group`,
 	PreRunE: preRunFuncs,

cli/cmd/groupsList.go

@@ -12,7 +12,7 @@ import (
 )
 
 var groupsListCmd = &cobra.Command{
-	Use:     "list",
+	Use:     GroupsListCmdName,
 	Short:   "List current gateway groups",
 	Long:    `List current gateway groups`,
 	PreRunE: preRunFuncs,

cli/cmd/passwordChange.go

@@ -17,7 +17,7 @@ func init() {
 	)
 
 	passwordChangeCmd := &cobra.Command{
-		Use:   "password-change",
+		Use:   PasswordChangeCmdName,
 		Short: "Change password of a gateway user",
 		Long:  `Change password of a gateway user`,
 		Run: func(cmd *cobra.Command, args []string) {

cli/cmd/portsAdd.go

@@ -12,7 +12,7 @@ import (
 )
 
 var portsAddCmd = &cobra.Command{
-	Use:   AddCmdUse,
+	Use:   PortsAddCmdName,
 	Short: "Pair a new door by cloning a hand remote signal (ADD_PORT)",
 	Long: `Pair a new door by cloning a hand remote's radio signal.
 

cli/cmd/portsInherit.go

@@ -12,7 +12,7 @@ import (
 )
 
 var portsInheritCmd = &cobra.Command{
-	Use:   InheritCmdUse,
+	Use:   InheritCmdName,
 	Short: "Pair a new door by transmitting the gateway's radio code (INHERIT_PORT)",
 	Long: `Pair a new door by having the gateway transmit its own radio code.