[feature request] mRetry/mRedo or similar?

[geemus]

I find in my workflow I frequently want to retry a prompt and end up running mDelete and mChat in rapid succession. It seems like it might be nice to have one command that would do both, but my initial naive attempts to do so didn't work (I think maybe I was running into timing issues of delete not finishing before chat started, but I'm not sure).

I'd be happy to work on this, but since I got a bit stuck I might need some guidance/pointers to proceed.

Thanks!

[gsuuon]

That'd be useful! Would be great to have it work for completion as well and not just chat. IIRC I half-way started this by making completion segments keep data about it's handler and prompt but didn't finish implementing re-do.

Most operations that modify a buffer go through :h vim.schedule (or vim.schedule_wrap), I think these are meant to execute in the order they're requested. If you're running Mdelete and then synchronously Mchat, the buffer probably hasn't updated yet. I think scheduling the Mchat command might get around the timing issue.

[geemus]

@gsuuon Thanks, that gives me more to dig into and try. I made a couple more somewhat naive attempts and didn't immediately nail it. From the docs it looks like vim.schedule relates to deferring the start, but doesn't pay attention to when/if previous things have finished. It looks like if you want that you have to do it yourself (callbacks seem like the most common approach). In any event, I'd still like to figure something out here, but it seems like it might be more involved. ie Unfortunately, I think we may need to schedule a single thing that does all the operations in order, rather than trying to schedule the bits independently.

[gsuuon]

I think modifying the segment methods to take a callback would be the easiest path.

    delete = vim.schedule_wrap(function(cont)
      local mark = get_details()
      ...

      cont()

Then we can create an MchatRedo command next to the others in lua/model/init:

  vim.api.nvim_create_user_command('MchatRedo', function()
    local seg = segment.query(util.cursor.position())
    if seg then
      flash(6, 80, seg, 'DiffChange', function()
        seg.delete(function()
          -- call command Mchat, or extract Mchat to a function and call the function
          -- this may need to be schedule_wrap'ed as well
        end)

This would be the basics for a chat buffer redo. A general redo that also works with completion mode might be more difficult. I think the pieces are there though, iirc it's possible to store and retrieve data from the segment to figure out what the prompt/handler was.