Skip to content

Commit 4821e7f

Browse files
committed
lf_multi_traffic.py : Add android reporting for zoom in overall report.
Verified CLI : python3 lf_multi_traffic.py --mgr 192.168.245.117 --upstream_port eth3 --parallel_tests zoom_test --zoom_signin_email '<zoom_mail>' --zoom_signin_passwd '<zoom_passwd>' --zoom_duration 2 --zoom_host 1.34 --zoom_participants 3 --zoom_device_list 1.34,1.36,1.40 --zoom_audio --zoom_video --api_stats_collection Signed-off-by: Sidartha-CT <neelapu.sidartha@candelatech.com>
1 parent 5c36eb1 commit 4821e7f

1 file changed

Lines changed: 19 additions & 22 deletions

File tree

py-scripts/lf_multi_traffic.py

Lines changed: 19 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -11399,7 +11399,7 @@ def add_frames_graphs_to_report(current_cord, current_angle, curr_yt_obj=curr_yt
1139911399
max_video_latency_r, min_video_latency_r = [], []
1140011400
max_video_pktloss_s, min_video_pktloss_s = [], []
1140111401
max_video_pktloss_r, min_video_pktloss_r = [], []
11402-
for i in range(0, len(curr_zoom_obj.device_names)):
11402+
for i in range(0, len(curr_zoom_obj.real_sta_hostname)):
1140311403
temp_max_audio_jitter_s, temp_min_audio_jitter_s = 0.0, 0.0
1140411404
temp_max_audio_jitter_r, temp_min_audio_jitter_r = 0.0, 0.0
1140511405
temp_max_audio_latency_s, temp_min_audio_latency_s = 0.0, 0.0
@@ -11429,13 +11429,16 @@ def add_frames_graphs_to_report(current_cord, current_angle, curr_yt_obj=curr_yt
1142911429
}
1143011430
try:
1143111431
if not self.do_bandsteering:
11432-
if self.dowebgui:
11433-
file_path = os.path.join(curr_zoom_obj.report.path_date_time, f'{curr_zoom_obj.device_names[i]}.csv')
11434-
else:
11435-
file_path = os.path.join(curr_zoom_obj.report.path_date_time, f'{curr_zoom_obj.device_names[i]}.csv')
11432+
# CSV files are written keyed by real_sta_hostname (the Zoom
11433+
# join name / API participant match target), not device_names
11434+
# (the raw LANforge resource hostname). For non-Android clients
11435+
# the two are identical, but Android substitutes the LANforge
11436+
# "user" field for real_sta_hostname, so looking this up by
11437+
# device_names silently dropped Android clients from this report.
11438+
file_path = os.path.join(curr_zoom_obj.report.path_date_time, f'{curr_zoom_obj.real_sta_hostname[i]}.csv')
1143611439
if not os.path.exists(file_path):
1143711440
logger.error(
11438-
f'File not found for client {curr_zoom_obj.device_names[i]}: {file_path}'
11441+
f'File not found for client {curr_zoom_obj.real_sta_hostname[i]}: {file_path}'
1143911442
)
1144011443
continue
1144111444
with open(
@@ -11524,16 +11527,10 @@ def add_frames_graphs_to_report(current_cord, current_angle, curr_yt_obj=curr_yt
1152411527
temp_min_video_pktloss_r = vo_loss if temp_min_video_pktloss_r == 0 else min(temp_min_video_pktloss_r, vo_loss)
1152511528

1152611529
elif self.do_bandsteering:
11527-
if not self.dowebgui:
11528-
file_path = os.path.join(
11529-
curr_zoom_obj.report.path_date_time,
11530-
f'{curr_zoom_obj.device_names[i]}.csv'
11531-
)
11532-
else:
11533-
file_path = os.path.join(
11534-
curr_zoom_obj.report.path_date_time,
11535-
f'{curr_zoom_obj.device_names[i]}.csv'
11536-
)
11530+
file_path = os.path.join(
11531+
curr_zoom_obj.report.path_date_time,
11532+
f'{curr_zoom_obj.real_sta_hostname[i]}.csv'
11533+
)
1153711534
with open(file_path, mode='r', encoding='utf-8', errors='ignore') as file:
1153811535
csv_reader = csv.DictReader(file)
1153911536

@@ -11630,12 +11627,12 @@ def add_frames_graphs_to_report(current_cord, current_angle, curr_yt_obj=curr_yt
1163011627
temp_min_video_pktloss_r = vo_loss if temp_min_video_pktloss_r == 0 else min(temp_min_video_pktloss_r, vo_loss)
1163111628

1163211629
except Exception as e:
11633-
logging.error(f"Error in reading data in client {self.zoom_obj_dict[ce][obj_name]['obj'].device_names[i]}: {e}")
11634-
no_csv_client.append(curr_zoom_obj.device_names[i])
11635-
rejected_clients.append(curr_zoom_obj.device_names[i])
11636-
if curr_zoom_obj.device_names[i] not in no_csv_client:
11637-
client_array.append(curr_zoom_obj.device_names[i])
11638-
accepted_clients.append(curr_zoom_obj.device_names[i])
11630+
logging.error(f"Error in reading data in client {self.zoom_obj_dict[ce][obj_name]['obj'].real_sta_hostname[i]}: {e}")
11631+
no_csv_client.append(curr_zoom_obj.real_sta_hostname[i])
11632+
rejected_clients.append(curr_zoom_obj.real_sta_hostname[i])
11633+
if curr_zoom_obj.real_sta_hostname[i] not in no_csv_client:
11634+
client_array.append(curr_zoom_obj.real_sta_hostname[i])
11635+
accepted_clients.append(curr_zoom_obj.real_sta_hostname[i])
1163911636
accepted_ostypes.append(curr_zoom_obj.real_sta_os_type[i])
1164011637
max_audio_jitter_s.append(temp_max_audio_jitter_s)
1164111638
min_audio_jitter_s.append(temp_min_audio_jitter_s)

0 commit comments

Comments
 (0)